From: Jeremy Drake <cygwin@jdrake.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v2] Cygwin: respect PC_SYM_FOLLOW and PC_SYM_NOFOLLOW_REP with inner links
Date: Mon, 31 May 2021 10:55:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.BSO.2.21.2105311039080.30039@resin.csoft.net> (raw)
In-Reply-To: <YLSbqEipANVY8KSZ@calimero.vinschen.de>
On Mon, 31 May 2021, Corinna Vinschen wrote:
> > So you're trying to keep the path length of the native CWD below
> > MAX_PATH? I understand what you're trying to accomplish, but are
> > you sure this doesn't break Cygwin processes? The idea of what
> > the native path of a directory is differs depending on calling
> > chdir and stuff like mkdir.
I'm not sure. I've been running builds with this patch for a bit, and
haven't seen any issue, but MSYS2 doesn't use native symlinks so that
aspect of it hasn't been exercised.
>
> What bugs me here is that there's no guarantee that you can keep your
> path below MAX_PATH, independently of what you do here. This is all
> a bit like patching up left and right just to keep dumb native tools
> running even in scenarios where they just fail otherwise.
Basically. I wish there was a viable alternative (requiring everyone
trying to use them to set a registry value/policy, manifesting them for
long paths, and potentially patching them to be safe with long paths isn't
very viable).
> So we have two contradict problems, one which is solved by following
> inner symlinks, one which is solved by not doing that... I'm not overly
> keen to support this scenario.
>
> Wouldn't that be something more suited for an MSYS2-local patch?
Just the changing of the flag in chdir? Because it seems like not
respecting the symlink-related PC flags for native inner links is a
bona-fide issue.
next prev parent reply other threads:[~2021-05-31 17:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 20:34 [PATCH] Cygwin: tweak handling of native symlinks from chdir Jeremy Drake
2021-05-29 23:15 ` Jeremy Drake
2021-05-30 6:05 ` Jeremy Drake
2021-05-30 19:58 ` [PATCH v2] Cygwin: respect PC_SYM_FOLLOW and PC_SYM_NOFOLLOW_REP with inner links Jeremy Drake
2021-05-31 8:02 ` Corinna Vinschen
2021-05-31 8:17 ` Corinna Vinschen
2021-05-31 17:55 ` Jeremy Drake [this message]
2021-07-03 21:01 ` Jeremy Drake
2021-07-07 18:52 ` Jeremy Drake
2021-07-08 14:48 ` Corinna Vinschen
2021-06-03 20:29 ` [PATCH v3] " Jeremy Drake
2021-06-03 20:57 ` Jeremy Drake
2021-07-06 14:57 ` Corinna Vinschen
2021-07-06 17:38 ` Jeremy Drake
2021-07-06 17:40 ` [PATCH v4] " Jeremy Drake
2021-07-07 8:47 ` Corinna Vinschen
2021-07-07 6:50 ` [PATCH v3] " Jeremy Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSO.2.21.2105311039080.30039@resin.csoft.net \
--to=cygwin@jdrake.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).