From: Jeremy Drake <cygwin@jdrake.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v3] Cygwin: respect PC_SYM_FOLLOW and PC_SYM_NOFOLLOW_REP with inner links
Date: Tue, 6 Jul 2021 10:38:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.BSO.2.21.2107061031580.56404@resin.csoft.net> (raw)
In-Reply-To: <YORvS4cn1fQX3O70@calimero.vinschen.de>
On Tue, 6 Jul 2021, Corinna Vinschen wrote:
> This formatting is just ugly. I suggest to move the PC_SYM_* test
> to the block after the 32 bit code and reuse the existing braces,
> just with adapted indentation, i. e.:
+1. I was trying to avoid reformatting otherwise unchanged lines to
reduce patch size.
> > @@ -3704,7 +3708,8 @@ chdir (const char *in_dir)
> >
> > /* Convert path. PC_NONULLEMPTY ensures that we don't check for
> > NULL/empty/invalid again. */
> > - path_conv path (in_dir, PC_SYM_FOLLOW | PC_POSIX | PC_NONULLEMPTY);
> > + path_conv path (in_dir, PC_SYM_FOLLOW | PC_POSIX | PC_NONULLEMPTY
> > + | PC_SYM_NOFOLLOW_REP);
> > if (path.error)
> > {
> > set_errno (path.error);
>
> I'm still not convinced that we should do this. I'm pretty certain this
> will result in problems in Cygwin processes when you least expect them.
>
> Consider that the output of getcwd and realpath/readlink on the same
> path may differ after this patch. Using PC_SYM_NOFOLLOW_REP like this
> also changes the normal sym follow handling for the last path component
> in path_copnv::check, potentially.
>
> This looks like here be dragons. A good solution would change the
> used native tools to allow paths > MAX_PATH finally, or to use other,
> equivalent tools already allowing that.
I am not convinced that this even completely solved the issues I was
seeing, or some of the reports of issues with unc paths suddenly showing
up instead of mapped drives in native tools that weren't expecting them.
But, I do think respecting the PC_SYM_NOFOLLOW_REP flag for inner links is
correct, and I am sending a new version.
next prev parent reply other threads:[~2021-07-06 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 20:34 [PATCH] Cygwin: tweak handling of native symlinks from chdir Jeremy Drake
2021-05-29 23:15 ` Jeremy Drake
2021-05-30 6:05 ` Jeremy Drake
2021-05-30 19:58 ` [PATCH v2] Cygwin: respect PC_SYM_FOLLOW and PC_SYM_NOFOLLOW_REP with inner links Jeremy Drake
2021-05-31 8:02 ` Corinna Vinschen
2021-05-31 8:17 ` Corinna Vinschen
2021-05-31 17:55 ` Jeremy Drake
2021-07-03 21:01 ` Jeremy Drake
2021-07-07 18:52 ` Jeremy Drake
2021-07-08 14:48 ` Corinna Vinschen
2021-06-03 20:29 ` [PATCH v3] " Jeremy Drake
2021-06-03 20:57 ` Jeremy Drake
2021-07-06 14:57 ` Corinna Vinschen
2021-07-06 17:38 ` Jeremy Drake [this message]
2021-07-06 17:40 ` [PATCH v4] " Jeremy Drake
2021-07-07 8:47 ` Corinna Vinschen
2021-07-07 6:50 ` [PATCH v3] " Jeremy Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSO.2.21.2107061031580.56404@resin.csoft.net \
--to=cygwin@jdrake.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).