Re: PATCH: rm MessageBox() (was: Virus that deletes everything under c:/cygwin?)

Re: PATCH: rm MessageBox() (was: Virus that deletes everything under c:/cygwin?)

[Warren Young]

On 3/28/2011 11:07 AM, Dante Allegria wrote:
> --- On Mon, 3/28/11, Damon Register<damon.w.register@lmco.com>  wrote:
>
> No, turns out it was because someone committed this into the nightly build scripts:
>     rm -rf $(DOES_NOT_EXIST)/*
>
> <sigh>  Should cygwin's rm have some built-in safeguards for this? :)

I'd like to propose a patch adding a series of MessageBox()es to 
Cygwin's unlink(2) syscall to make it ask "Are you sure?" then "Are you 
really sure?" then "Are you really really double-dog sure?" every time 
you try to remove a file.

Additionally, I propose adding a patch to rm(1) so that if you give -r, 
it will activate UAC on Vista/7 systems before doing any work, because 
everyone loves it when the screen dims and you get yet another dialog 
you must okay before the system will do anything else.

I will start this work on April 1, if there are no objections.

Re: PATCH: rm MessageBox() (was: Virus that deletes everything under c:/cygwin?)

[Christopher Faylor]

On Mon, Mar 28, 2011 at 03:37:03PM -0600, Warren Young wrote:
>On 3/28/2011 11:07 AM, Dante Allegria wrote:
>> --- On Mon, 3/28/11, Damon Register<damon.w.register@lmco.com>  wrote:
>>
>> No, turns out it was because someone committed this into the nightly build scripts:
>>     rm -rf $(DOES_NOT_EXIST)/*
>>
>> <sigh>  Should cygwin's rm have some built-in safeguards for this? :)
>
>I'd like to propose a patch adding a series of MessageBox()es to 
>Cygwin's unlink(2) syscall to make it ask "Are you sure?" then "Are you 
>really sure?" then "Are you really really double-dog sure?" every time 
>you try to remove a file.
>
>Additionally, I propose adding a patch to rm(1) so that if you give -r, 
>it will activate UAC on Vista/7 systems before doing any work, because 
>everyone loves it when the screen dims and you get yet another dialog 
>you must okay before the system will do anything else.
>
>I will start this work on April 1, if there are no objections.

We look forward to the final product.  Make sure that you sign an
assignment with RedHat since this will be a substantial amount of work.
But, it is obviously valuable work since it brings CygWin further down
the path towards being a true GUI and everyone knows that's a good
thing.

cgf