public inbox for cygwin-xfree@sourceware.org
help / color / mirror / Atom feed
From: Charles Wilson <cygwin@cwilson.fastmail.fm>
To: Ryan Pavlik <rpavlik@iastate.edu>
Cc: cygwin-xfree@cygwin.com
Subject: Re: Built XWin on mingw - with patches
Date: Thu, 10 Nov 2011 22:58:00 -0000 [thread overview]
Message-ID: <4EBC56E8.2020001@cwilson.fastmail.fm> (raw)
In-Reply-To: <CABMFTE8wrNqbNLX+jmd7WcxT-xqfxYctB-ZgmxfwBg38_g5xmw@mail.gmail.com>
On 11/10/2011 11:29 AM, Ryan Pavlik wrote:
> On Wed, Nov 9, 2011 at 1:11 PM, Charles Wilson wrote:
>> You *think* you're safe in assuming that WIN32 == !__CYGWIN__,
>> but...#include<jpeg.h> breaks all your assumptions. But jpeg.h *did
>> nothing wrong*.
>>
>> It's better to be explicit.
>>
>> --
>> Chuck
>
> OK, so this leads me to the next question: The existing codebase has
> substantial numbers of places with #if defined(WIN32) - do these all
> imply #if defined(WIN32)&& !defined(__CYGWIN__) ?
That I don't know.
> I generally
> avoided touching things I didn't have to,
A good policy.
> but this may be worth
> clarifying codebase-wide.
Perhaps -- I'll leave that call to others. I suspect a global patch that
affected only #if lines should be a separate patch from any other
changes, if taking this action was desirable.
--
Chuck
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://x.cygwin.com/docs/
FAQ: http://x.cygwin.com/docs/faq/
next prev parent reply other threads:[~2011-11-10 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 20:40 Ryan Pavlik
2011-11-03 19:18 ` Jon TURNEY
2011-11-04 23:39 ` Ryan Pavlik
2011-11-07 18:10 ` Jon TURNEY
2011-11-07 19:36 ` Charles Wilson
2011-11-09 18:46 ` Jon TURNEY
2011-11-09 19:11 ` Charles Wilson
[not found] ` <CABMFTE8wrNqbNLX+jmd7WcxT-xqfxYctB-ZgmxfwBg38_g5xmw@mail.gmail.com>
2011-11-10 22:58 ` Charles Wilson [this message]
2011-11-10 16:50 ` Ryan Pavlik
2011-11-22 2:55 ` SeongNam Oh
2012-01-09 19:31 ` Jon TURNEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBC56E8.2020001@cwilson.fastmail.fm \
--to=cygwin@cwilson.fastmail.fm \
--cc=cygwin-xfree@cygwin.com \
--cc=rpavlik@iastate.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).