public inbox for cygwin-xfree@sourceware.org help / color / mirror / Atom feed
From: Jon TURNEY <jon.turney@dronecode.org.uk> To: cygwin-xfree@cygwin.com Cc: rpavlik@iastate.edu Subject: Re: Built XWin on mingw - with patches Date: Thu, 03 Nov 2011 19:18:00 -0000 [thread overview] Message-ID: <4EB2E8FE.6020305@dronecode.org.uk> (raw) In-Reply-To: <CABMFTE8Q3BHEvUN=YPt4nSVvVc=mVHnhe8-jx4=o1QRom1_iSQ@mail.gmail.com> On 01/11/2011 20:39, Ryan Pavlik wrote: > Not sure if this is the right forum for this, but it seemed more This is absolutely the correct list. Thanks very much for putting in the effort to do this. > specific and probably more appropriate than the overall xorg lists. > I wanted to build a native windows X server (essentially an > open-source Xming). I had to patch a number of the packages along the > way, but did eventually arrive at a build that worked. I looked at > and used a few of the Xming patches, but only generally went to those > when the naive approach didn't work. This may be a problem. The material on the Xming website is licensed under a Creative Commons license, which is not compatible with the X11 license. So, patches from the Xming website are not acceptable unless the author has agreed to re-license them appropriately. > I'm looking for some feedback on the patches so that they can get into > the main line of the projects. > > I built using mingw-cross-env, with my fork here that includes the > dependency packages: https://bitbucket.org/rpavlik/mingw-cross-env/ > This builds everything except the xorg-server module (ignore the fact > there's an xorg-server makefile there - the patches aren't up to date > for that module.) > > Patches for these dependencies are as follows, in that mingw-cross-env > repo (These should all have commit messages from being exported from > git format-patch): > libX11-1-add-xwinsock-include, libX11-2-windows-threads, > libX11-3-MinGW-lacks-caddr_t > libXaw-1-need-winsock > libXfont-1-dummy-readlink > libxcb-1-fix-include-order-with-Xdmcp, libxcb-2-wsastartup - this last > one fixes running libX11 apps built for Windows, including the > integrated multi-window WM. > xkbcomp-1-Use-X11-Xwindows.h, xkbcomp-2-Look-in-windows-base-dir-too - > this last one supports the "RELOCATE_PROJECTROOT" option in the XWin > server - should still work fine in the normal case though. I've quickly looked over these patches and in general they look good, and I'd be happy to help get them merged upstream. A couple of general points I'd make though: It helps a great deal in reviewing if the comments state why the change is a good idea (e.g. what problem it fixes), rather than just describing the change which is made. I also noticed that a bit more care might be needed with the define you are using to enable platform specific code: WIN32 and __MINGW__ should not be used interchangeably. WIN32 will also be defined when building VcXsrv, and neither is defined on Cygwin. So, can you post your patches here, preferably in git-send-email format so we can review them in detail? -- Jon TURNEY Volunteer Cygwin/X X Server maintainer -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Problem reports: http://cygwin.com/problems.html Documentation: http://x.cygwin.com/docs/ FAQ: http://x.cygwin.com/docs/faq/
next prev parent reply other threads:[~2011-11-03 19:18 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-11-01 20:40 Ryan Pavlik 2011-11-03 19:18 ` Jon TURNEY [this message] 2011-11-04 23:39 ` Ryan Pavlik 2011-11-07 18:10 ` Jon TURNEY 2011-11-07 19:36 ` Charles Wilson 2011-11-09 18:46 ` Jon TURNEY 2011-11-09 19:11 ` Charles Wilson [not found] ` <CABMFTE8wrNqbNLX+jmd7WcxT-xqfxYctB-ZgmxfwBg38_g5xmw@mail.gmail.com> 2011-11-10 22:58 ` Charles Wilson 2011-11-10 16:50 ` Ryan Pavlik 2011-11-22 2:55 ` SeongNam Oh 2012-01-09 19:31 ` Jon TURNEY
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4EB2E8FE.6020305@dronecode.org.uk \ --to=jon.turney@dronecode.org.uk \ --cc=cygwin-xfree@cygwin.com \ --cc=rpavlik@iastate.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).