[PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Jannick]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Attached a tiny patch to i686-pc-mingw32' glob.h which remedies a function
prototype definition error thrown upon compilation.

I am hoping that this is the correct one of cygwin's mail-lists, please
advise otherwise. 

Thanks,
J.

---
C:/cygwin32/usr/i686-pc-mingw32/sys-root/mingw/include/nppBackup/glob.h.2017
-06-25_142140.bak	Tue Jul 16 00:34:26 2013
+++ C:/cygwin32/usr/i686-pc-mingw32/sys-root/mingw/include/glob.h	Sun
Jun 25 14:21:40 2017
@@ -142,7 +142,8 @@
 #define GLOB_INLINE  static __inline__ __attribute__((__always_inline__))
 
 GLOB_INLINE int glob
-( const char *__pattern, int __flags, int (*__errfunc)(), glob_t *__data )
+( const char *__pattern, int __flags, int (*__errfunc) (const char *, int),
glob_t *__data )
 { return __mingw_glob( __pattern, __flags, __errfunc, __data ); }
 
 GLOB_INLINE void globfree( glob_t *__data )

[-- Attachment #2: glob.h.patch --]
[-- Type: application/octet-stream, Size: 630 bytes --]

--- C:/cygwin32/usr/i686-pc-mingw32/sys-root/mingw/include/nppBackup/glob.h.2017-06-25_142140.bak	Tue Jul 16 00:34:26 2013
+++ C:/cygwin32/usr/i686-pc-mingw32/sys-root/mingw/include/glob.h	Sun Jun 25 14:21:40 2017
@@ -142,7 +142,8 @@
 #define GLOB_INLINE  static __inline__ __attribute__((__always_inline__))
 
 GLOB_INLINE int glob
-( const char *__pattern, int __flags, int (*__errfunc)(), glob_t *__data )
+( const char *__pattern, int __flags, int (*__errfunc) (const char *, int), glob_t *__data )
 { return __mingw_glob( __pattern, __flags, __errfunc, __data ); }
 
 GLOB_INLINE void globfree( glob_t *__data )


[-- Attachment #3: Type: text/plain, Size: 219 bytes --]


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Hi Jannick,

On Jul  1 15:44, Jannick wrote:
> Attached a tiny patch to i686-pc-mingw32' glob.h which remedies a function
> prototype definition error thrown upon compilation.
> 
> I am hoping that this is the correct one of cygwin's mail-lists, please
> advise otherwise. 

This is, in fact, the wrong mailing list.  The files for the mingw cross
build environment are maintained via the mingw-w64-public mailing list
on sourceforge, see

  https://sourceforge.net/p/mingw-w64/mailman/

Ideally you provide your patches there.


HTH,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

RE: [PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Jannick]

On Mon, 3 Jul 2017 09:25:51 +0200, Corinna Vinschen wrote:

> This is, in fact, the wrong mailing list.  The files for the mingw 
> cross build environment are maintained via the mingw-w64-public 
> mailing list on sourceforge, see
> 
>   https://sourceforge.net/p/mingw-w64/mailman/
> 
> Ideally you provide your patches there.

Thanks for this - just for the record: https://sourceforge.net/p/mingw-w64/mailman/message/35924907/

> HTH,
> Corinna

Many thanks,
J. 



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

RE: [PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Jannick]

On Jul 03, 2017 at 01:12 PM, Jannick wrote:
> of function 'glob'
> 
> On Mon, 3 Jul 2017 09:25:51 +0200, Corinna Vinschen wrote:
> 
> > This is, in fact, the wrong mailing list.  The files for the mingw
> > cross build environment are maintained via the mingw-w64-public
> > mailing list on sourceforge, see
> >
> >   https://sourceforge.net/p/mingw-w64/mailman/
> >
> > Ideally you provide your patches there.
> 
> Thanks for this - just for the record: https://sourceforge.net/p/mingw-w64/mailman/message/35924907/

The mingw-w64 list turned out to be the wrong list, too, unfortunately.

For the MinGW32 distribution glob.h is maintained here
https://sourceforge.net/p/mingw/mingw-org-wsl/ci/5.0-active/tree/mingwrt/include/glob.h.

I am not sure what the code basis of i686-pc-mingw32 is, so am back here on this list with the patch.
Maybe there is someone out here who knows how which version of glob.h finds its way into cygwin's 
i686-pc-mingw32 distribution.

Kind regards,
J.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Jon Turney]

On 08/07/2017 09:32, Jannick wrote:
> On Jul 03, 2017 at 01:12 PM, Jannick wrote:
>> On Mon, 3 Jul 2017 09:25:51 +0200, Corinna Vinschen wrote:
[...]
> 
> I am not sure what the code basis of i686-pc-mingw32 is, so am back here on this list with the patch.
> Maybe there is someone out here who knows how which version of glob.h finds its way into cygwin's
> i686-pc-mingw32 distribution.

The i686-pc-mingw32 toolchain was removed from Cygwin a while ago [1].

The correct upstream for this is mingw.org.

[1] https://cygwin.com/ml/cygwin-announce/2016-03/msg00069.html

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

RE: [PATCH] glob.h (i686-pc-mingw32) b/c wrong function prototype of function 'glob'

[Jannick]

On Sat, 8 Jul 2017 13:45:38 +0100, Jon Turney wrote:
> The i686-pc-mingw32 toolchain was removed from Cygwin a while ago [1].

Many thanks - very enlightening! Obviously I missed this info. So a useless patch.

> [1] https://cygwin.com/ml/cygwin-announce/2016-03/msg00069.html



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple