Package pinfo-0.6.10 - fix for very old bug

Package pinfo-0.6.10 - fix for very old bug

[Henning]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

In src/parse_confic.c there are two typos which cause an error message

	Parse error in config file on line nnn

if you try to assign function keys f9 or f10 using the usual KEY_F(<n>)
syntax. These two require KEY_(F<n>).
This bug was present as early as 2002 and is still present in the latest
version 0.6.13.

The attached patch applies to 0.6.10 (the current version in cygwin) and
also to 0.6.13. I've also sent it to the maintainer, Bas Zoetekouw. So
it might be taken intp account in 0.6.14.

Henning




[-- Attachment #2: f9f10.diff --]
[-- Type: text/plain, Size: 544 bytes --]

--- a/src/parse_config.c	2006-06-24 17:16:14.000000000 +0200
+++ b/src/parse_config.c	2019-06-04 21:29:14.902420800 +0200
@@ -867,9 +867,9 @@
 					*key = KEY_F(7);
 				else if (!(strncmp(temp + 4, "F(8)", 4)))
 					*key = KEY_F(8);
-				else if (!(strncmp(temp + 4, "(F9)", 4)))
+				else if (!(strncmp(temp + 4, "F(9)", 4)))
 					*key = KEY_F(9);
-				else if (!(strncmp(temp + 4, "(F10)", 5)))
+				else if (!(strncmp(temp + 4, "F(10)", 5)))
 					*key = KEY_F(10);
 				else if (!(strncmp(temp + 4, "F(11)", 5)))
 					*key = KEY_F(11);

[-- Attachment #3: Type: text/plain, Size: 219 bytes --]


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Package pinfo-0.6.10 - fix for very old bug

[Andrew Schulman]

> In src/parse_confic.c there are two typos which cause an error message
> 
> 	Parse error in config file on line nnn
> 
> if you try to assign function keys f9 or f10 using the usual KEY_F(<n>)
> syntax. These two require KEY_(F<n>).
> This bug was present as early as 2002 and is still present in the latest
> version 0.6.13.
> 
> The attached patch applies to 0.6.10 (the current version in cygwin) and
> also to 0.6.13. I've also sent it to the maintainer, Bas Zoetekouw. So
> it might be taken intp account in 0.6.14.

Thanks Henning. I'll push out a test release soon with this patch, so you
can tell me if it fixes the problem for you.

I may update pinfo to 0.6.13. I seem to recall that I tried that before and
ran into build trouble. I'll take another look.

Andrew


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Package pinfo-0.6.10 - fix for very old bug

[Henning]

On 06/06/2019 17:16, Andrew Schulman wrote:
> 
> Thanks Henning. I'll push out a test release soon with this patch, so you
> can tell me if it fixes the problem for you.
> 
> I may update pinfo to 0.6.13. I seem to recall that I tried that before and
> ran into build trouble. I'll take another look.
> 
> Andrew

I thought I'll try. At first autogen.sh failed with autopoint not found.
After installing gettext-devel, which, among other packages, according
to cygwin package search contained autopoint, autogen'ing, configure'ing
and make'ing succeeded.
What puzzled me were the very different sizes of the executables:
     0.6.10		104,974
     0.6.13		 27,662
(stripping didn't change sizes.)

I thought I re-compile 0.6.10 to check. But that failed because
configure considered curses.h (ncurses 6.0-12.20171125) unusable:

checking location of curses.h file... /usr/include/ncursesw/ncurses.h
checking if curses is usable... no
configure: error: Curses not found. You need curses to compile pinfo

Henning

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Package pinfo-0.6.10 - fix for very old bug

[Henning]

On 08/06/2019 10:08, Henning wrote:
> On 06/06/2019 17:16, Andrew Schulman wrote:
>>
>> I may update pinfo to 0.6.13. I seem to recall that I tried that 
>> before and
>> ran into build trouble. I'll take another look.
>>
>> Andrew
> 
> I thought I'll try. At first autogen.sh failed with autopoint not found.
> After installing gettext-devel, which, among other packages, according
> to cygwin package search contained autopoint, autogen'ing, configure'ing
> and make'ing succeeded.
> What puzzled me were the very different sizes of the executables:
>      0.6.10        104,974
>      0.6.13         27,662
> (stripping didn't change sizes.)
> 

Sorry, my fault. Doing 'make install' revealed that not the executable
in src/ but instead the one in /src/.libs is installed. Size is now
559k/91k

Henning

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Package pinfo-0.6.10 - fix for very old bug

[Henning]

On 06/06/2019 17:16, Andrew Schulman wrote:
> 
> Thanks Henning. I'll push out a test release soon with this patch, so you
> can tell me if it fixes the problem for you.

Andrew, no problems so far with 0.6.13-3. Everything is perfect.
Thank you for your time.

Henning

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple