public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: [64bit] cygwin-devel headers broken
Date: Sat, 02 May 2015 13:38:00 -0000	[thread overview]
Message-ID: <20150502130940.GA12723@calimero.vinschen.de> (raw)
In-Reply-To: <5543E431.6060203@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

On May  1 14:38, Eric Blake wrote:
> On 05/01/2015 02:12 PM, Marco Atzeri wrote:
> >>> It seems that sys/select.h is no longer implicitly included by some
> >>> other header, I think probably sys/time.h.
> 
> POSIX says:
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_time.h.html#tag_13_64
> 
> "Inclusion of the <sys/time.h> header may make visible all symbols from
> the <sys/select.h> header."
> 
> which means <sys/time.h> may (but not must) pollute the namespace with
> select().  This means two things:
> 
> 1. Portable applications should not depend on the pollution (so
> reporting it to upstream projects is the right thing to do)
> 
> 2. Cygwin should do better at emulating Linux and include the namespace
> pollution, for the sake of applications that have not yet been patched.

I screwed that up, didn't I?

This is a result of the newlib change to sys/time.h.  It has been
updated to the latest stuff from FreeBSD in March.

Before, we had a <cygwin/sys_time.h> header which defines futimes and
lutimes.  Since these symbols are now defined in newlib's new sys/time.h,
I concluded razor-sharp, that we don't need the cygwin-specific
cygwin/sys_time.h anymore.

Unfortunately I missed the fact that this file also includes <sys/select.h>.

> Anyone want to tackle the patch to cygwin's sys/time.h?

I applied a patch.  A new version of Cygwin has to wait until I'm back
from vaca, sorry.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-05-02 13:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 18:52 Thomas Wolff
2015-05-01  5:03 ` Marco Atzeri
2015-05-01 12:10   ` Jon TURNEY
2015-05-01 18:19     ` Thomas Wolff
2015-05-01 20:12       ` Michael Enright
2015-05-02 17:38         ` Csaba Raduly
2015-05-01 20:23       ` Marco Atzeri
2015-05-01 20:38         ` Eric Blake
2015-05-02 13:38           ` Corinna Vinschen [this message]
2015-05-01 20:25     ` J. Offerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150502130940.GA12723@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).