Tmux crashes on copy

Tmux crashes on copy

[David Stephenson]

[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]

When using the copy function in tmux it crashes on Enter.

Steps:

ctrl-[ (enter copy mode)
Navigate to text
space (start copy)
Navigate to end of text
Enter (to select highlighted text) at this point tmux crashes

cygcheck.out (email redacted) and tmux.exe.stackdump attached

Thanks

[-- Attachment #2: cygcheck.out --]
[-- Type: application/octet-stream, Size: 87942 bytes --]

[-- Attachment #3: tmux.exe.stackdump --]
[-- Type: application/octet-stream, Size: 2929 bytes --]

Exception: STATUS_ACCESS_VIOLATION at rip=00010046962C
rax=0000000000000000 rbx=0000000000000011 rcx=00007FFEB890C600
rdx=0000000000000000 rsi=00000007FFFFC360 rdi=0000000100469650
r8 =0000000000000003 r9 =00007FFEB89BE0A8 r10=0000000800000000
r11=00000003FF53108D r12=0000000A000784B8 r13=000000000000000C
r14=0000000A00029150 r15=0000000A000CFE20
rbp=0000000A000778E0 rsp=00000007FFFFC2B0
program=C:\cygwin64\bin\tmux.exe, pid 4706, thread main
cs=0033 ds=002B es=002B fs=0053 gs=002B ss=002B
Stack trace:
Frame         Function      Args
000A000778E0  00010046962C (00000000000D, 00000000000C, 000A00029150, 00000000000C) tmux.exe+0x6962C
000A000778E0  00010046955C (000100474C69, 000000000000, 000100492C7B, 000A00108B20) tmux.exe+0x6955C
000A000778E0  0001004525FE (000100474DA0, 000A001A2B20, 000000000000, 000A0006E3C0) tmux.exe+0x525FE
000A000778E0  0001004733F1 (000000000001, 000A001A3540, 0007FFFFC5A0, 000A001A2B20) tmux.exe+0x733F1
000A000778E0  000100474F91 (0001004C7560, 0000454E4F4E, 000A0005E050, 000A0005C7B0) tmux.exe+0x74F91
7FFEB89BF1B0  00010047731E (7FFEB8883AB7, 00007FFE0358, 7FFF12900453, 0000041B3950) tmux.exe+0x7731E
7FFEB89BF1B0  00010047755F (5D0CAA74764981ED, 0001004940E8, 0001004940F4, 000A0005D0E0) tmux.exe+0x7755F
000000000000  000100417A41 (000A0008F540, 000100000001, 000A001A2B20, 000000000000) tmux.exe+0x17A41
000A00078380  00010041401D (000A00018860, 7FFEB89BF1B0, 000018010000, 000A00018CD0) tmux.exe+0x1401D
7FFEB89BF1B0  00010045A1C5 (000A00000001, 000000000002, 000000000002, 000A00018860) tmux.exe+0x5A1C5
7FFEB89BF1B0  00010044B292 (1DA485C14E63BB0, 1DA485C152117A1, 000000000024, 000000000000) tmux.exe+0x4B292
7FFEB89BF1B0  00010045A972 (7FFEB891F3F6, 00000000006F, 000000000030, 000A00019310) tmux.exe+0x5A972
0007FFFFCA30  000100404EEB (7FFE00000000, 000A000184F0, 0001004B0FCC, 000800000001) tmux.exe+0x4EEB
000008010000  00010048B55C (000000000000, 000000000000, 000000000000, 000000000000) tmux.exe+0x8B55C
0007FFFFCD30  7FFEB86E80A3 (000000000000, 000000000000, 000000000000, 000000000000) cygwin1.dll+0x80A3
0007FFFFFFF0  7FFEB86E5C86 (000000000000, 000000000000, 000000000000, 000000000000) cygwin1.dll+0x5C86
0007FFFFFFF0  7FFEB86E5D34 (000000000000, 000000000000, 000000000000, 000000000000) cygwin1.dll+0x5D34
End of stack trace
Loaded modules:
000100400000 tmux.exe
7FFF128F0000 ntdll.dll
7FFF11020000 KERNEL32.DLL
7FFF0FDC0000 KERNELBASE.dll
7FFEB86E0000 cygwin1.dll
0003FFA60000 cygevent-2-0-5.dll
0003FF500000 cygncursesw-10.dll
7FFF11A30000 advapi32.dll
7FFF10D10000 msvcrt.dll
7FFF12680000 sechost.dll
7FFF10610000 bcrypt.dll
7FFF11B60000 RPCRT4.dll
7FFF0F4B0000 CRYPTBASE.DLL
7FFF0FC30000 bcryptPrimitives.dll
7FFF10C90000 ws2_32.dll
7FFF0F180000 mswsock.dll
7FFF0E710000 iphlpapi.dll
7FFF0E740000 DNSAPI.dll
7FFF12670000 NSI.dll
7FFF05490000 dhcpcsvc6.DLL
7FFF05470000 dhcpcsvc.DLL
7FFF0CE10000 WINNSI.DLL

Re: Tmux crashes on copy

[Yasuhiro Kimura]

From: David Stephenson via Cygwin <cygwin@cygwin.com>
Subject: Tmux crashes on copy
Date: Wed, 17 Jan 2024 12:30:59 +0000

> When using the copy function in tmux it crashes on Enter.
> 
> Steps:
> 
> ctrl-[ (enter copy mode)
> Navigate to text
> space (start copy)
> Navigate to end of text
> Enter (to select highlighted text) at this point tmux crashes
> 
> cygcheck.out (email redacted) and tmux.exe.stackdump attached
> 
> Thanks

I have same problem with Windows 11 2023H2, and it disappears if I
rollback libncursesw10 package from 6.4-20231230 to 6.4-3.20230114.
So we may hit the bug of libncursesw10 6.4-20231230.

Regards.

---
Yasuhiro Kimura

Re: Tmux crashes on copy

[Takashi Yano]

On Thu, 18 Jan 2024 16:37:59 +0900 (JST)
Yasuhiro Kimura wrote:
> From: David Stephenson via Cygwin <cygwin@cygwin.com>
> Subject: Tmux crashes on copy
> Date: Wed, 17 Jan 2024 12:30:59 +0000
> 
> > When using the copy function in tmux it crashes on Enter.
> > 
> > Steps:
> > 
> > ctrl-[ (enter copy mode)
> > Navigate to text
> > space (start copy)
> > Navigate to end of text
> > Enter (to select highlighted text) at this point tmux crashes
> > 
> > cygcheck.out (email redacted) and tmux.exe.stackdump attached
> > 
> > Thanks
> 
> I have same problem with Windows 11 2023H2, and it disappears if I
> rollback libncursesw10 package from 6.4-20231230 to 6.4-3.20230114.
> So we may hit the bug of libncursesw10 6.4-20231230.

TO: Brian

BTW, shouldn't the package name
libncursesw10-6.4-20231230 
be
libncursesw10-6.4-4.20231230 
?

Or is this intentional?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

Re: Tmux crashes on copy

[Brian Inglis]

On 2024-01-18 01:24, Takashi Yano via Cygwin wrote:
> On Thu, 18 Jan 2024 16:37:59 +0900 (JST)
> Yasuhiro Kimura wrote:
>> On Wed, 17 Jan 2024 12:30:59 +0000, David Stephenson via Cygwin wrote:

>>> When using the copy function in tmux it crashes on Enter.
>>> Steps:
>>> ctrl-[ (enter copy mode)
>>> Navigate to text
>>> space (start copy)
>>> Navigate to end of text
>>> Enter (to select highlighted text) at this point tmux crashes
>>> cygcheck.out (email redacted) and tmux.exe.stackdump attached

Known issue also on Fedora with tmux:

	https://github.com/tmux/tmux/issues/3699

https://github.com/tmux/tmux/commit/b202a2f1b517a3de7141fc35fbd9e39ed5ac5284

new release not yet available - maintainer will have to apply upstream patch, or 
users will have to downgrade ncurses.

It looks like ncurses maintenance lagged, while tmux was updated; now ncurses is 
being updated, so tmux needs updated to 3.3a, with above patch and any prereqs.

>> I have same problem with Windows 11 2023H2, and it disappears if I
>> rollback libncursesw10 package from 6.4-20231230 to 6.4-3.20230114.
>> So we may hit the bug of libncursesw10 6.4-20231230.

> TO: Brian
> BTW, shouldn't the package name
> libncursesw10-6.4-20231230
> be
> libncursesw10-6.4-4.20231230
> Or is this intentional?

Previous maintainer added some artificial single digit release prefixes (in a 
few packages), but we decided to drop those and use the release date directly as 
used in the package.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                  -- Antoine de Saint-Exupéry

Re: Tmux crashes on copy

[ASSI]

Brian Inglis via Cygwin writes:
> Previous maintainer added some artificial single digit release
> prefixes (in a few packages), but we decided to drop those and use the
> release date directly as used in the package.

That is the upstream versioning scheme for patch releases or beta
versions, which can't be used directly on Cygwin without losing the
release part of the package version.

You might want to go for something like 6.4+20240120-1 instead.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Waldorf MIDI Implementation & additional documentation:
http://Synth.Stromeko.net/Downloads.html#WaldorfDocs

Re: Tmux crashes on copy

[Brian Inglis]

On 2024-01-21 14:12, ASSI via Cygwin wrote:
> Brian Inglis via Cygwin writes:
>> Previous maintainer added some artificial single digit release
>> prefixes (in a few packages), but we decided to drop those and use the
>> release date directly as used in the package.

> That is the upstream versioning scheme for patch releases or beta
> versions, which can't be used directly on Cygwin without losing the
> release part of the package version.
> You might want to go for something like 6.4+20240120-1 instead.

Good point, but I figured we could add the suffix .1 or something if we could 
not get a change merged upstream: the snapshots are weekly or better in ncurses, 
although others not so often, and I have no idea how they decide when to release 
a new GNU version 6.5?

What happens if we change versioning from 6.4-yyyymmdd to 6.4+yyyymmdd-1?

My rpm-ver.bash shell script says okay, but rpmdev-vercmp (from rpmdevtools 9.6) 
now complains, rpm{,-build,-devel}, python3{,9}-rpm are installed and OK, any idea?

/usr/local/lib/python3.9/site-packages/rpm.py:15: UserWarning: The RPM Python 
bindings are not currently available via PyPI.

Please install them with your distro package manager (typically called
'python2-rpm' or 'python3-rpm'), and ensure that any virtual environments
needing the API are configured to be able to see the system site packages
directory.

   warnings.warn(warning_msg)
Traceback (most recent call last):
   File "/mnt/c/Users/bwi/src/fedora/rpmdevtools-RPMDEVTOOLS_9_6/rpmdev-vercmp", 
line 121, in <module>
     main()
   File "/mnt/c/Users/bwi/src/fedora/rpmdevtools-RPMDEVTOOLS_9_6/rpmdev-vercmp", 
line 108, in main
     rc = rpm.labelCompare((e1 or None, v1 or None, r1 or None),
AttributeError: module 'rpm' has no attribute 'labelCompare'

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

Re: Tmux crashes on copy

[Jon Turney]

On 21/01/2024 22:13, Brian Inglis via Cygwin wrote:
> On 2024-01-21 14:12, ASSI via Cygwin wrote:
>> Brian Inglis via Cygwin writes:
>>> Previous maintainer added some artificial single digit release
>>> prefixes (in a few packages), but we decided to drop those and use the
>>> release date directly as used in the package.
> 
>> That is the upstream versioning scheme for patch releases or beta
>> versions, which can't be used directly on Cygwin without losing the
>> release part of the package version.
>> You might want to go for something like 6.4+20240120-1 instead.

I'm not sure that's the right solution

Ideally, V should be the upstream version label.

If upstream really is making multiple releases called '6.4', which we're 
supposed to distinguish by some other means, then there aren't really 
any good answers...

See the mess that is https://repology.org/project/ncurses/information, 
where everyone makes up there own scheme.

> Good point, but I figured we could add the suffix .1 or something if we 
> could not get a change merged upstream: the snapshots are weekly or 
> better in ncurses, although others not so often, and I have no idea how 
> they decide when to release a new GNU version 6.5?
> 
> What happens if we change versioning from 6.4-yyyymmdd to 6.4+yyyymmdd-1?

Re: Tmux crashes on copy

[marco atzeri]

On Wed, Jan 31, 2024 at 2:39 PM Jon Turney via Cygwin  wrote:
>
> On 21/01/2024 22:13, Brian Inglis via Cygwin wrote:
> > On 2024-01-21 14:12, ASSI via Cygwin wrote:
> >> Brian Inglis via Cygwin writes:
> >>> Previous maintainer added some artificial single digit release
> >>> prefixes (in a few packages), but we decided to drop those and use the
> >>> release date directly as used in the package.
> >
> >> That is the upstream versioning scheme for patch releases or beta
> >> versions, which can't be used directly on Cygwin without losing the
> >> release part of the package version.
> >> You might want to go for something like 6.4+20240120-1 instead.
>
> I'm not sure that's the right solution
>
> Ideally, V should be the upstream version label.
>
> If upstream really is making multiple releases called '6.4', which we're
> supposed to distinguish by some other means, then there aren't really
> any good answers...
>
> See the mess that is https://repology.org/project/ncurses/information,
> where everyone makes up there own scheme.
>
> > Good point, but I figured we could add the suffix .1 or something if we
> > could not get a change merged upstream: the snapshots are weekly or
> > better in ncurses, although others not so often, and I have no idea how
> > they decide when to release a new GNU version 6.5?
> >
> > What happens if we change versioning from 6.4-yyyymmdd to 6.4+yyyymmdd-1?
>

 for me  will make more sense a scheme like

6.4-5+GITID
6.4-6+GITID
..

just my 2c€

Regards
Marco

Re: Tmux crashes on copy

[ASSI]

Jon Turney via Cygwin writes:
> If upstream really is making multiple releases called '6.4', which
> we're supposed to distinguish by some other means, then there aren't
> really any good answers...

There's only one official 6.4 release, but just about everyone packages
one of the roughly weekly snapshots inbetween releases (depending on
where you are looking they are also called beta versions), which are
named 6.4-yyyymmdd upstream.  We can't have a "-" in the version number,
hence the suggestion to replace it with a "+".


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

Re: ncurses version (was: Tmux crashes on copy)

[Brian Inglis]

On 2024-01-31 10:36, ASSI via Cygwin wrote:
> Jon Turney via Cygwin writes:
>> If upstream really is making multiple releases called '6.4', which
>> we're supposed to distinguish by some other means, then there aren't
>> really any good answers...

> There's only one official 6.4 release, but just about everyone packages
> one of the roughly weekly snapshots inbetween releases (depending on
> where you are looking they are also called beta versions), which are
> named 6.4-yyyymmdd upstream.  We can't have a "-" in the version number,
> hence the suggestion to replace it with a "+".

[moving discussion to -apps]

Upstream developer is Thomas Dickey at invisible-island.net so no git.

My only concern is if 6.4+20240203-1 !> 6.4-20240120 as strvercmp test beds 
disagree, presumably about the effect of the delimiter, possibly because the + 
may be treated similarly to a prefix for an RC preceding the 6.4 release?

For guidance I have looked at:

	https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

which states that ~ prefixes pre-stable "snapshot" releases and ^ prefixes 
post-stable "snapshot" releases where . or nothing prefixes upstream bugfix or 
patch level releases, so perhaps we should just use version suffix .yyyymmdd?

I have downloaded and locally installed Fedora rpmdevtools package but Cygwin 
python rpm module seems to lack labelCompare():

$ rpmdev-vercmp 6.4+20240203-1 6.4-20240120
/usr/local/lib/python3.9/site-packages/rpm.py:15: UserWarning: The RPM Python 
bindings are not currently available via PyPI.

Please install them with your distro package manager (typically called
'python2-rpm' or 'python3-rpm'), and ensure that any virtual environments
needing the API are configured to be able to see the system site packages
directory.

   warnings.warn(warning_msg)
Traceback (most recent call last):
   File "/home/BWI/bin/rpmdev-vercmp", line 121, in <module>
     main()
   File "/home/BWI/bin/rpmdev-vercmp", line 108, in main
     rc = rpm.labelCompare((e1 or None, v1 or None, r1 or None),
AttributeError: module 'rpm' has no attribute 'labelCompare'

I also pip3 installed SAS SW rpm_vercmp which seems okay:

$ python3 -c 'import 
rpm_vercmp;print(rpm_vercmp.vercmp("6.4+20240203-1","6.4-20240120"))
'
1

and wrote a wrapper for shell script functions I found which agrees:

$ ~/src/fedora/rpm-ver.bash 6.4+20240203-1 6.4-20240120
0 6 4 20240203 1
0 6 4 20240120
6.4+20240203-1   6.4-20240120
0 6 4 20240203 1         0 6 4 20240120
sizes 5 4 max 5
20240203 != 20240120
8 ? 8
1

How are Cygwin pre-stable RC releases defined differently from post-stable 
snapshot releases and upstream patch releases?

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry