public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?
Date: Sat, 14 Jan 2017 15:38:00 -0000	[thread overview]
Message-ID: <20170114153756.GB9762@calimero.vinschen.de> (raw)
In-Reply-To: <326b4885-182e-841c-8522-2ec48841c9a4@waldmann-edv.de>

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On Jan 13 20:07, Thomas Waldmann wrote:
> On 01/13/2017 07:18 PM, Thomas Waldmann wrote:
> > It was a bug in our code that was triggered frequently by the small
> > cygwin pipe buffer size of only 64kiB.
> > 
> > borgbackup fix/workaround see there:
> > 
> > https://github.com/borgbackup/borg/pull/2032
> > 
> > It (almost?) never happened on other OSes, due to their bigger buffers.
> 
> Hmm, the last phrase seems not to be the real reason why it worked
> there, but rather that neither Linux nor *BSD ever do partial writes on
> blocking pipes.
> 
> So, should cygwin also behave that ^^^ way on blocking pipes?

Yes.  I inspected the code and the current behaviout was apparently
an accident when refactoring the pipe write code.  I applied a patch
and uploaded new developer snapshots to https://cygwin.com/snapshots/
Please give them a try.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-01-14 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  3:47 Thomas Waldmann
2017-01-12 16:53 ` cyg Simple
2017-01-12 17:32   ` Thomas Waldmann
2017-01-13 18:19   ` Thomas Waldmann
2017-01-13 19:08     ` Thomas Waldmann
2017-01-14 15:38       ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170114153756.GB9762@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).