From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: OpenBLAS patch for Cygwin
Date: Tue, 06 Feb 2018 14:24:00 -0000 [thread overview]
Message-ID: <20180206142400.GC30794@calimero.vinschen.de> (raw)
In-Reply-To: <a00f8d46-aca4-7eac-22c7-e035e001253d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Feb 6 15:15, Marco Atzeri wrote:
> On 06/02/2018 13:10, Erik Bray wrote:
> > Hello,
> >
> > Users/maintainers of OpenBLAS on Cygwin may be interested in this
> > patch to improve support for fork():
> > https://github.com/xianyi/OpenBLAS/pull/1450
> >
> > Assuming this looks good (feedback welcome) it might be nice to have
> > this patch included in the next release of the official OpenBLAS
> > package for Cygwin since its incompatibility with fork() has caused
> > problems in the past [1].
> >
> >
> > Thanks,
> > E
> >
> > [1] https://trac.sagemath.org/ticket/22822
> >
>
>
> Noted.
> Do you have a test case to show the failure with current build ?
>
> Any reason to use OS_CYGWIN_NT and not __CYGWIN__ in the patch ?
Also, it should really use pthread functions and drop the notion that
Cygwin is a Windows target. Assuming you're running fork from another
thread than the main thread, does it still work with native Windows
threads?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-06 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 12:10 Erik Bray
2018-02-06 14:15 ` Marco Atzeri
2018-02-06 14:24 ` Corinna Vinschen [this message]
2018-02-13 18:23 ` Erik Bray
2018-02-06 18:07 ` Achim Gratz
2018-02-13 18:26 ` Erik Bray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206142400.GC30794@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).