From: Erik Bray <erik.m.bray@gmail.com>
To: cygwin@cygwin.com
Subject: Re: OpenBLAS patch for Cygwin
Date: Tue, 13 Feb 2018 18:26:00 -0000 [thread overview]
Message-ID: <CAOTD34b2Mom2uRY86BF+sATtUs2bwy2x2x3-s7xVs+0SNZ+iJQ@mail.gmail.com> (raw)
In-Reply-To: <874lmu6lgx.fsf@Rainer.invalid>
On Tue, Feb 6, 2018 at 7:07 PM, Achim Gratz wrote:
> Erik Bray writes:
>> Assuming this looks good (feedback welcome) it might be nice to have
>> this patch included in the next release of the official OpenBLAS
>> package for Cygwin since its incompatibility with fork() has caused
>> problems in the past [1].
>
> It would be vastly preferrable if OPenBLAS ditched the (unfortunately
> quite common) notion that "Cygwin is some sort of Windows" for "Cygwin
> is some sort of Linux". I've patched out quite some bit of conditionals
> like that in some other packages and it was almost always for the
> better. The worst ones are those that go into the Windows conditional
> branch and then on to "oh wait, but for Cygwin we need something else".
Yup--OpenBLAS treats Cygwin as "some sort of Windows" and you can see
in my pull requests that there are some conditions like "if WINDOWS &&
!CYGWIN".
I will probably try another patch to remove that notion in general.
I've had a little other experience with patching OpenBLAS for Cygwin
and it's one of those cases where upstream is, fortunately, receptive
to supporting it as a platform. Their existing Cygwin support has
just been a bit janky (a previous patch I submitted installed the DLL
as cygopenblas.dll instead of libopenblas.dll, for example).
Best,
E
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
prev parent reply other threads:[~2018-02-13 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 12:10 Erik Bray
2018-02-06 14:15 ` Marco Atzeri
2018-02-06 14:24 ` Corinna Vinschen
2018-02-13 18:23 ` Erik Bray
2018-02-06 18:07 ` Achim Gratz
2018-02-13 18:26 ` Erik Bray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOTD34b2Mom2uRY86BF+sATtUs2bwy2x2x3-s7xVs+0SNZ+iJQ@mail.gmail.com \
--to=erik.m.bray@gmail.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).