public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
* GNU screen and tmux cannot read tty input if they are started in a telnet session
@ 2019-03-09  1:35 Takashi Yano
  2019-03-10  6:05 ` Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session) Takashi Yano
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Yano @ 2019-03-09  1:35 UTC (permalink / raw)
  To: cygwin

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Hello,

I would like to propose a patch attached for login package.

This fixes the issue that GNU screen and tmux cannot read tty input
if they are started in a telnet session.

This issue is due to the ownership of tty. With login 1.12-1, tty
is owned by cyg_server after logging in via telnet. This results
in freeze of GNU screen and tmux.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

[-- Attachment #2: 0001-Fix-the-issue-that-GNU-screen-and-tmux-cannot-read-t.patch --]
[-- Type: application/octet-stream, Size: 766 bytes --]

From f652446932eac5811f0ae82d12c69a77fb2b959f Mon Sep 17 00:00:00 2001
From: Takashi Yano <takashi.yano@nifty.ne.jp>
Date: Sat, 9 Mar 2019 10:11:54 +0900
Subject: [PATCH] Fix the issue that GNU screen and tmux cannot read tty input
 if they are started in a telnet session.

* login.c (main): Add chown() and chmod() to change the ownership
and the permissions of tty.
---
 login.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/login.c b/login.c
index 271d5e8..918f228 100644
--- a/login.c
+++ b/login.c
@@ -280,6 +280,8 @@ main (int argc, char **argv)
 	  sleep ((u_int) ((cnt - 3) * 5));
 	}
     }
+  chown (ttyn, pwd->pw_uid, pwd->pw_gid);
+  chmod (ttyn, 0600);
 
   /* committed to login -- turn off timeout */
   (void) alarm ((u_int) 0);
-- 
2.17.0


[-- Attachment #3: Type: text/plain, Size: 219 bytes --]


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session)
  2019-03-09  1:35 GNU screen and tmux cannot read tty input if they are started in a telnet session Takashi Yano
@ 2019-03-10  6:05 ` Takashi Yano
  2019-03-16 13:06   ` Takashi Yano
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Yano @ 2019-03-10  6:05 UTC (permalink / raw)
  To: cygwin

I try to clarify the title a little.

On Sat, 9 Mar 2019 10:35:13 +0900 Takashi Yano wrote:
> Hello,
> 
> I would like to propose a patch attached for login package.
> 
> This fixes the issue that GNU screen and tmux cannot read tty input
> if they are started in a telnet session.
> 
> This issue is due to the ownership of tty. With login 1.12-1, tty
> is owned by cyg_server after logging in via telnet. This results
> in freeze of GNU screen and tmux.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session)
  2019-03-10  6:05 ` Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session) Takashi Yano
@ 2019-03-16 13:06   ` Takashi Yano
  2019-03-16 15:34     ` Corinna Vinschen
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Yano @ 2019-03-16 13:06 UTC (permalink / raw)
  To: cygwin

Hi Corinna and Yaakov,

I know you are busy, but could you please have a look?

On Sun, 10 Mar 2019 15:05:48 +0900 Takashi Yano wrote:
> I try to clarify the title a little.
> 
> On Sat, 9 Mar 2019 10:35:13 +0900 Takashi Yano wrote:
> > Hello,
> > 
> > I would like to propose a patch attached for login package.
> > 
> > This fixes the issue that GNU screen and tmux cannot read tty input
> > if they are started in a telnet session.
> > 
> > This issue is due to the ownership of tty. With login 1.12-1, tty
> > is owned by cyg_server after logging in via telnet. This results
> > in freeze of GNU screen and tmux.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session)
  2019-03-16 13:06   ` Takashi Yano
@ 2019-03-16 15:34     ` Corinna Vinschen
  2019-03-16 16:50       ` Takashi Yano
  0 siblings, 1 reply; 5+ messages in thread
From: Corinna Vinschen @ 2019-03-16 15:34 UTC (permalink / raw)
  To: Takashi Yano; +Cc: cygwin

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Mar 16 22:06, Takashi Yano wrote:
> Hi Corinna and Yaakov,
> 
> I know you are busy, but could you please have a look?
> 
> On Sun, 10 Mar 2019 15:05:48 +0900 Takashi Yano wrote:
> > I try to clarify the title a little.
> > 
> > On Sat, 9 Mar 2019 10:35:13 +0900 Takashi Yano wrote:
> > > Hello,
> > > 
> > > I would like to propose a patch attached for login package.
> > > 
> > > This fixes the issue that GNU screen and tmux cannot read tty input
> > > if they are started in a telnet session.
> > > 
> > > This issue is due to the ownership of tty. With login 1.12-1, tty
> > > is owned by cyg_server after logging in via telnet. This results
> > > in freeze of GNU screen and tmux.

Pushed and new release uploaded.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session)
  2019-03-16 15:34     ` Corinna Vinschen
@ 2019-03-16 16:50       ` Takashi Yano
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Yano @ 2019-03-16 16:50 UTC (permalink / raw)
  To: cygwin

Hi Corinna,

On Sat, 16 Mar 2019 16:34:41 +0100 Corinna Vinschen wrote:
> Pushed and new release uploaded.

I confirmed that the issue has been fixed in login 1.13-1.
Thank you very much!

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-03-16 16:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09  1:35 GNU screen and tmux cannot read tty input if they are started in a telnet session Takashi Yano
2019-03-10  6:05 ` Problem of login (Re: GNU screen and tmux cannot read tty input if they are started in a telnet session) Takashi Yano
2019-03-16 13:06   ` Takashi Yano
2019-03-16 15:34     ` Corinna Vinschen
2019-03-16 16:50       ` Takashi Yano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).