From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Takashi Yano <takashi.yano@nifty.ne.jp>
Cc: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.1
Date: Sun, 18 Aug 2019 12:07:00 -0000 [thread overview]
Message-ID: <20190818115849.GE11632@calimero.vinschen.de> (raw)
In-Reply-To: <20190818014317.38e23198147dad936da1ac94@nifty.ne.jp>
[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]
On Aug 18 01:43, Takashi Yano wrote:
> Hi Corinna,
>
> On Fri, 16 Aug 2019 16:48:11 +0200
> Corinna Vinschen wrote:
> > I now had an idea, but I'm not entirely sure if it's the right thing to
> > do. Can you please test this? It consists of two patches, one with the
> > revamped signalfd handling, and one with the revert of the signalfd
> > patch I applied a couple of days ago.
> >
> > Quick description: I dropped signalfd_select_wait entirely. Instead,
> > wait_sig sets or resets a manual event object to indicate if there are
> > signals pending in the queue, even after trying to handle them the
> > normal way. That usually means they are blocked.
> >
> > select() uses the event to wake up from WFMO, if at least one signalfd
> > is present in the read descriptor set. The rest is done via the peek
> > and verify functions in select, which basically just check if this
> > signalfd is waiting for one of the pending signals.
> >
> > The reversion of my patch from a couple days ago is not required as
> > such, but after thinking about this a while I'm convinced that this was
> > just me not getting the full picture. Also, reverting this patch would
> > revert to seeing a SEGV in your testcase and thus a bug in the new code,
> > too.
> >
> > I attached both patches. It would be pretty nice if you could test them
> > and point out any problems you get with this new code.
> >
> > Please note that you should ideally perform a full rebuild due to the
> > slight change in TLS layout.
>
> I confirmed that my STC and script command works as expected with these
> patches.
>
> Thank you for greate work!
Great, thank you, and thanks for testing!
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-18 11:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 18:55 Corinna Vinschen
2019-08-11 7:28 ` Thorsten Kampe
2019-08-12 13:01 ` Corinna Vinschen
2019-08-12 19:44 ` Takashi Yano
2019-08-13 22:27 ` Thorsten Kampe
2019-08-13 21:45 ` Thorsten Kampe
2019-08-13 21:51 ` Thorsten Kampe
2019-08-14 7:23 ` Takashi Yano
2019-08-12 13:44 ` Takashi Yano
2019-08-12 15:36 ` Corinna Vinschen
2019-08-13 10:48 ` Corinna Vinschen
2019-08-14 11:41 ` Takashi Yano
2019-08-14 11:47 ` Takashi Yano
2019-08-14 13:49 ` Corinna Vinschen
2019-08-14 19:21 ` Takashi Yano
2019-08-15 7:49 ` Corinna Vinschen
2019-08-15 10:36 ` Corinna Vinschen
2019-08-15 15:04 ` Corinna Vinschen
2019-08-15 15:09 ` Corinna Vinschen
2019-08-16 14:58 ` Corinna Vinschen
2019-08-17 16:59 ` Takashi Yano
2019-08-18 12:07 ` Corinna Vinschen [this message]
2019-08-18 12:08 ` Achim Gratz
2019-08-18 14:29 ` Corinna Vinschen
2019-08-18 14:51 ` Achim Gratz
2019-08-19 8:56 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818115849.GE11632@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=takashi.yano@nifty.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).