Re: stdin pipe rename in 3.2.0

[Takashi Yano <takashi.yano@nifty.ne.jp>]

On Thu, 18 Mar 2021 21:28:40 +0100
Christoph Reiter wrote:
> I noticed that the stdin pipe was renamed from
> 
> "\msys-dd50a72ab4668b33-pty1-from-master" to
> "\msys-dd50a72ab4668b33-pty0-to-slave" in
> https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439

Actually, this is not renamed but newly introduced only
for non-cygwin (native) apps.

> This trips up https://github.com/k-takata/ptycheck to detect the
> cygpty which is used in various code bases.

If this change is affected, your process seems to be
a non-cygwin process.

> Is there a reason it was renamed?
> 
> And while grepping I noticed the old name is still checked for in
> other places like
> https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/tty.cc;h=3c016315cdedb1dcca44cb3f3f96b87fd0b90a97;hb=HEAD#l162
> which seems weird.

The name "from-master" is still used for cygwin
processes.

However, the naming was not appropriate.
The name of output pipes are:
"ptyNNNN-to-master-cyg" for cygwin process,
and
"ptyNNNN-to-master" for non-cygwin process.

However, the name of input pipes are:
"ptyNNNN-from-master" for cygwin process,
and
"ptyNNNN-to-slave" for non-cygwin process.
This is not only consistent but also very confusing.

I would like to rename these pipes to:
"ptyNNNN-from-master-cyg" for cygwin process,
"ptyNNNN-from-master" for non-cygwin process.

Corinna, is it possble to apply the patch for 3.2.0 release?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>