[PATCH 0/1] libbrotli has broken pkg-config

[PATCH 0/1] libbrotli has broken pkg-config

[David McFarland]

I'm a little lost on the exact process for sending patches for packages,
so excuse me if I'm in the wrong place. I found this problem when trying
to build something that depends on libbrotli.

This patch pulls the fix from this PR:
https://github.com/google/brotli/pull/838

David McFarland (1):
  cherry-pick fix for pkg-config

 brotli.cygport | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.31.1

[PATCH 1/1] cherry-pick fix for pkg-config

[David McFarland]

This PR removes a recently added -R/usr/lib from the linker flags, which is
incompatible with gcc:

    $ cc $(pkg-config --libs libbrotlidec)
    cc: error: unrecognized command-line option ‘-R’
---
 brotli.cygport | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/brotli.cygport b/brotli.cygport
index dbf43b7..91deb5c 100644
--- a/brotli.cygport
+++ b/brotli.cygport
@@ -4,7 +4,7 @@ inherit cmake python-wheel
 
 NAME="brotli"
 VERSION=1.0.9
-RELEASE=1
+RELEASE=2
 CATEGORY="Libs"
 SUMMARY="Brotli compression format library"
 DESCRIPTION="Brotli is a generic-purpose lossless compression algorithm that
@@ -14,6 +14,7 @@ comparable to the best currently available general-purpose compression methods.
 It is similar in speed with deflate but offers more dense compression."
 HOMEPAGE="https://github.com/google/brotli"
 SRC_URI="${HOMEPAGE}/archive/v${VERSION}/brotli-v${VERSION}.tar.gz"
+PATCH_URI="${HOMEPAGE}/commit/092446fafb4bfb81738853b7c7f76b293cd92a80.patch"
 
 BUILD_REQUIRES="\
   cmake\
-- 
2.31.1

Re: [PATCH 1/1] cherry-pick fix for pkg-config

[Lemures Lemniscati]

On Mon, 19 Apr 2021 16:12:24 -0300, David McFarland
> This PR removes a recently added -R/usr/lib from the linker flags, which is
> incompatible with gcc:
> 
Hi, David McFarland!

Thank you for the report and the patch.

I've updated brotli packages [1].

And, support for python 2.7 is dropped.

Regards,

Lem

[1]: https://www.cygwin.com/packages/summary/brotli-src.html

Re: [PATCH 0/1] libbrotli has broken pkg-config

[Andrey Repin]

Greetings, David McFarland!

> I'm a little lost on the exact process for sending patches for packages,

I think the cygwin-patches is an appropriate place for these.

> so excuse me if I'm in the wrong place. I found this problem when trying
> to build something that depends on libbrotli.

> This patch pulls the fix from this PR:
> https://github.com/google/brotli/pull/838

> David McFarland (1):
>   cherry-pick fix for pkg-config

>  brotli.cygport | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)



-- 
With best regards,
Andrey Repin
Tuesday, April 20, 2021 7:57:11

Sorry for my terrible english...

Re: [PATCH 0/1] libbrotli has broken pkg-config

[Marco Atzeri]

On 20.04.2021 06:57, Andrey Repin wrote:
> Greetings, David McFarland!
> 
>> I'm a little lost on the exact process for sending patches for packages,
> 
> I think the cygwin-patches is an appropriate place for these.

that is only for patches to the cygwin itself.
For packages, here is fine