Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

[Francesco Pretto]

Hello,

I want to report a bug in mintty that is mostly suffered by "Git for
Windows" users, which in version 2.39.0.2 they are using mintty 3.6.1.
The bug has been reported in this "Git for Windows" issue[1].
Basically maximizing the mintty window during a "git log" session
locks the tty session and the window must be quit/killed. I can
reproduce within a vanilla cygwin mintty 3.6.3 session, which is
present in the latest cygwin 3.4.3, using the same "Git for Windows"
git binary. To reproduce;

- Open a cygwin mintty window, keep it **default** size, don't maximize here;
- Go to a git repository directory;
- Enter "git log" (I'm using the git binary from "Git for Windows",
location "/cygdrive/c/Program Files/Git/cmd/git";
- Maximize the window;
- Try to exit "git log" by pressing "q" -> lock!

There was some debate of who was supposed to report the issue to this
ML. Please, ask for more details "Git for Windows" maintainers, if you
need, either by contacting them here/privately or writing to their
Github issue.

Regards,
Francesco Pretto

[1] https://github.com/git-for-windows/git/issues/4060

Re: Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

[Takashi Yano]

On Tue, 10 Jan 2023 16:50:26 +0100
Francesco Pretto wrote:
> I want to report a bug in mintty that is mostly suffered by "Git for
> Windows" users, which in version 2.39.0.2 they are using mintty 3.6.1.
> The bug has been reported in this "Git for Windows" issue[1].
> Basically maximizing the mintty window during a "git log" session
> locks the tty session and the window must be quit/killed. I can
> reproduce within a vanilla cygwin mintty 3.6.3 session, which is
> present in the latest cygwin 3.4.3, using the same "Git for Windows"
> git binary. To reproduce;
> 
> - Open a cygwin mintty window, keep it **default** size, don't maximize here;
> - Go to a git repository directory;
> - Enter "git log" (I'm using the git binary from "Git for Windows",
> location "/cygdrive/c/Program Files/Git/cmd/git";
> - Maximize the window;
> - Try to exit "git log" by pressing "q" -> lock!

What does "uname -a" in Git for Windows say?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

Re: Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

[Francesco Pretto]

On Tue, 10 Jan 2023 at 18:03, Takashi Yano <takashi.yano@nifty.ne.jp> wrote:
> What does "uname -a" in Git for Windows say?
>

MINGW64_NT-10.0-19045 LAPTOPBBK2 3.3.6-341.x86_64 2022-09-05 20:28 UTC
x86_64 Msys

Re: Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

[Takashi Yano]

On Tue, 10 Jan 2023 22:24:39 +0100
Francesco Pretto wrote:
> On Tue, 10 Jan 2023 at 18:03, Takashi Yano <takashi.yano@nifty.ne.jp> wrote:
> > What does "uname -a" in Git for Windows say?
> >
> 
> MINGW64_NT-10.0-19045 LAPTOPBBK2 3.3.6-341.x86_64 2022-09-05 20:28 UTC
> x86_64 Msys

Thanks. Actually, I already fixed that issue on 22 Dec. 2022.
https://cygwin.com/pipermail/cygwin-patches/2022q4/012107.html

Even you start git in Git for Windows from cygwin, msys-2.0.dll
in Git for Windows is used for less called from git. Therefore,
applying this patch for msys-2.0.dll will fixes the isseu.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

Re: Maximizing windows during "git log" locks mintty both in "Git for Windows" and cygwin 3.4.3

[Adam Dinwoodie]

On Tue, Jan 10, 2023 at 04:50:26PM +0100, Francesco Pretto via Cygwin wrote:
> Hello,
> 
> I want to report a bug in mintty that is mostly suffered by "Git for
> Windows" users, which in version 2.39.0.2 they are using mintty 3.6.1.
> The bug has been reported in this "Git for Windows" issue[1].
> Basically maximizing the mintty window during a "git log" session
> locks the tty session and the window must be quit/killed. I can
> reproduce within a vanilla cygwin mintty 3.6.3 session, which is
> present in the latest cygwin 3.4.3, using the same "Git for Windows"
> git binary. To reproduce;
> 
> - Open a cygwin mintty window, keep it **default** size, don't maximize here;
> - Go to a git repository directory;
> - Enter "git log" (I'm using the git binary from "Git for Windows",
> location "/cygdrive/c/Program Files/Git/cmd/git";
> - Maximize the window;
> - Try to exit "git log" by pressing "q" -> lock!

I've tried this, as described, using both Cygwin's git and MinTTY, and
using the Git for Windows versions, and both work just fine for me.
However...

> There was some debate of who was supposed to report the issue to this
> ML. Please, ask for more details "Git for Windows" maintainers, if you
> need, either by contacting them here/privately or writing to their
> Github issue.
> 
> Regards,
> Francesco Pretto
> 
> [1] https://github.com/git-for-windows/git/issues/4060

...this is the same issue on GitHub as was reported at [0], however
in that email thread the problem occurred only when using the Windows
terminal emulators, calling git or less from within a PowerShell or cmd
window, *not* when using MinTTY.  I believe that's fixed in an upcoming
Cygwin release, per [1], although I don't know when that release will
happen, or how long it will take downstream projects like Git for
Windows to pick it up.

[0]: https://cygwin.com/pipermail/cygwin/2022-December/252737.html
[1]: https://cygwin.com/pipermail/cygwin/2022-December/252745.html

I'll put a comment on the Git for Windows issue now, more-or-less
duplicating the above.

Adam