public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Mark Geisert <mark@maxrnd.com>
To: cygwin@cygwin.com
Subject: Re: [pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing return type
Date: Thu, 7 Sep 2023 22:18:32 -0700	[thread overview]
Message-ID: <3e525bb6-ce45-4e0c-fd65-29f4ae69454e@maxrnd.com> (raw)
In-Reply-To: <CANNqMjCjZYPKw2XQjWhqmen6cVhYFjROg+oo5DDZpL52ppGngw@mail.gmail.com>

Hi Marco,

Marco Mason via Cygwin wrote:
> I just updated to 3.4.9-1 and compiled some code, and it complained about
> cpuset.h.
> Specifically, "C++ requires a type specifier for all declarations", and
> sure enough, there's no return type on line 52.  So I changed my local copy
> to the following, and it cleared things up:
> 
> #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
> static __inline /*MCM*/ void /*MCM*/
> __cpuset_zero_s (__size_t siz, cpu_set_t *set)
> {

Thanks for the report; right you are.

> I looked at a couple mailing list archives and saw that the cpuset.h header
> was worked on recently, but couldn't track it down any closer.  I also
> tried to find a git repository so I could find the commit so I could check
> for similar errors on other headers, but couldn't find the repo for
> cygwin-devel anywhere.

This error was introduced with the most recent update to cpuset.h.  There is a 
public-visible mirror of the Cygwin tree at
     https://github.com/cygwin/cygwin/blob/main/winsup/cygwin
and the problematic file can be found at
     include/sys/cpuset.h
within.

Your bug report and proposed correction are all we need for the issue you ran 
into.  I'll submit a patch shortly.
Thanks again,

..mark

  reply	other threads:[~2023-09-08  5:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 17:54 Marco Mason
2023-09-08  5:18 ` Mark Geisert [this message]
2023-09-08 13:21   ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e525bb6-ce45-4e0c-fd65-29f4ae69454e@maxrnd.com \
    --to=mark@maxrnd.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).