* Installing sshd on W7 reveals errors in CSIH_SCRIPT
@ 2017-05-26 19:38 Houder
2017-05-27 11:35 ` Houder
2017-05-27 15:55 ` Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master Houder
0 siblings, 2 replies; 9+ messages in thread
From: Houder @ 2017-05-26 19:38 UTC (permalink / raw)
To: cygwin
Hi,
Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
CSIH_SCRIPT = /usr/share/csih/cygwin-service-installation-helper.sh
Just now I installed the sshd daemon on my W7 (64-bits Cygwin); I am
still
using /etc/{passwd,group} as the "database" (i.e. NOT Windows SAM).
Invocation of /usr/bin/ssh-host-config (in an elevated shell)
genenerated
the following TWO warnings:
= 1st warning =
passwd: unknown user cyg_server
*** Warning: Setting password expiry for user 'cyg_server' failed!
*** Warning: Please check that password never expires or set it to your
needs.
= 2nd warning =
*** Warning: Expected privileged user 'cyg_server' does not exist.
*** Warning: Defaulting to 'SYSTEM' <===== no what I had in mind!
-----
ssh-host-config sources CSIH-SCRIPT
The function if interest in ssh-host-config is: install_service()
install_service() # skeleton of function as executed in my case
csih_create_privileged_user
csih_service_should_run_as
# ======================================================================
# Action!
# ======================================================================
... lot of statements
install_service || let warning_cnt+=$? # almost at bottom of file
-----
So the functions of interest in CSIH-SCRIPT are:
- csih_create_privileged_user
- csih_service_should_run_as
Near the bottom of csih_create_privileged_use(), "cyg_server" (the
privileged
user) is ADDED to /etc/passwd ... too late and using the wrong
statement.
Too late, because the privileged user ("cyg_server") should already have
been
added near the beginning of this function ...
- that is why the 1st warning is issued (from
csih_create_privileged_user() )
- and because of the wrong statement, "cyg_server" is NOT added to
/etc/passwd
The 2nd warning is generated from csih_service_should_run_as() for the
same
reason ("cyg_server" missing from /etc/passwd).
As a side-effect, the sshd service will be created using the "SYSTEM"
account
i.s.o. "cyg_server" account -- not what was intended!
BTW, the comment at the top of csih_use_file_etc() is WRONG: it should
read:
# ======================================================================
# Routine: csih_use_file_etc passwd|group
...
# Returns 1 if files shall be used, 0 otherwise.
# ======================================================================
Regards,
Henri
=
= Skeleton of both functions as executed in my case
=
1.
csih_create_privileged_user() # in case user cyg_server must be created
# privileged user ("cyg_server") already present?
csih_privileged_account_exists "$csih_PRIVILEGED_USERNAME"
# No, it is NOT! Create user ...
csih_call_winsys32 net user "${csih_PRIVILEGED_USERWINNAME}"
# make the passwd of the privileged user never expire ...
if ! passwd -e "${csih_PRIVILEGED_USERNAME}"
then
... WARNING: Setting password expiry for user "cyg_server" failed!
fi
# Hold on, has user already been added to /etc/passwd (if files is
preferred
# as the "database")? No, the user has NOT been added yet!
=====> This is why Henri gets his 1st warning ...
=====> ... and why he HAD to add user "cyg_server" to /etc/passwd
=====> ... and has to change the service
(no, not the "SYSTEM" account, but the "cyg_server" account!)
... a lot more statements
# TOO LATE and using the WRONG variable name!
# add cyg_server to /etc/passwd ... if and only if files are used as
database
if csih_use_file_etc passwd # yes, Henri uses files as the "database"
then
# HUH?
/usr/bin/mkpasswd -l -u "${username}" >> "${SYSCONFDIR}/passwd"
# I believe the statement should have read: i.e. WRONG variable used
/usr/bin/mkpasswd -l -u "${{csih_PRIVILEGED_USERNAME}" >>
"${SYSCONFDIR}/passwd"
fi
2.
csih_service_should_run_as()
... a lot of statements
if csih_privileged_account_exists "$csih_PRIVILEGED_USERNAME" 1>&2
then
# it already existed before this script was launched (comment by
Corinna)
echo "$csih_PRIVILEGED_USERNAME"
return
elif /usr/bin/getent passwd "${csih_PRIVILEGED_USERNAME}"
then
... ok
else
... Warning: Expected privileged user "cyg_server" does not exist
echo "SYSTEM" # meaning service will use the SYSTEM account (and not
the
# cyg_server account) -- which is NOT was intended!
fi
=====
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT
2017-05-26 19:38 Installing sshd on W7 reveals errors in CSIH_SCRIPT Houder
@ 2017-05-27 11:35 ` Houder
2017-05-27 15:55 ` Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master Houder
1 sibling, 0 replies; 9+ messages in thread
From: Houder @ 2017-05-27 11:35 UTC (permalink / raw)
To: cygwin
On 2017-05-26 21:35, Houder wrote:
> Hi,
>
> Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
>
> CSIH_SCRIPT = /usr/share/csih/cygwin-service-installation-helper.sh
>
> Just now I installed the sshd daemon on my W7 (64-bits Cygwin); I am
> still
> using /etc/{passwd,group} as the "database" (i.e. NOT Windows SAM).
>
> Invocation of /usr/bin/ssh-host-config (in an elevated shell)
> genenerated
> the following TWO warnings:
The error in csih_create_privileged_user() appears to have been
corrected
already om March 11 2016 (Achim Gratz) ...
commit: 128ed704ed13cda2f3b2e336dba4aeb27a70bdd6
https://cygwin.com/git/?p=cygwin-apps/csih.git;a=commit;f=cygwin-service-installation-helper.sh;h=128ed704ed13cda2f3b2e336dba4aeb27a70bdd6
HOWEVER the whole statement (mkpasswd -l ...)must be moved UPWARDS in
the function, as I described in my first post.
The error was originally reported by Nick Batlle in
https://cygwin.com/ml/cygwin/2016-03/msg00154.html
Regards,
Henri
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-05-26 19:38 Installing sshd on W7 reveals errors in CSIH_SCRIPT Houder
2017-05-27 11:35 ` Houder
@ 2017-05-27 15:55 ` Houder
2017-05-28 13:46 ` Houder
2017-06-07 9:15 ` Corinna Vinschen
1 sibling, 2 replies; 9+ messages in thread
From: Houder @ 2017-05-27 15:55 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
On 2017-05-26 21:35, Houder wrote:
> Hi,
>
> Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
>
> CSIH_SCRIPT = /usr/share/csih/cygwin-service-installation-helper.sh
Retrieved CSIH_SCRIPT from the master (January 19 2017) here:
https://cygwin.com/git/?p=cygwin-apps/csih.git;a=summary
Attached patch file against master ...
Regards,
Henri
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: csih.patch --]
[-- Type: text/x-diff; name=csih.patch, Size: 1477 bytes --]
diff --git a/master/cygwin-service-installation-helper.sh b/henri/cygwin-service-installation-helper.sh
index a0b6216..14a40c1 100644
--- a/master/cygwin-service-installation-helper.sh
+++ b/henri/cygwin-service-installation-helper.sh
@@ -2566,7 +2566,7 @@ readonly -f csih_old_cygwin
#
# Otherwise, we need the files.
#
-# Returns 0 if files shall be used, 1 otherwise.
+# Returns 1 if files shall be used, 0 otherwise.
# ======================================================================
csih_use_file_etc()
{
@@ -3003,6 +3003,12 @@ csih_create_privileged_user()
csih_inform "the '${csih_PRIVILEGED_USERNAME}' account."
echo ""
+ # If we use /etc account DB only, write new account to /etc/passwd
+ if csih_use_file_etc passwd
+ then
+ /usr/bin/mkpasswd -l -u "${csih_PRIVILEGED_USERNAME}" >> "${SYSCONFDIR}/passwd"
+ fi
+
if ! passwd -e "${csih_PRIVILEGED_USERNAME}" >/dev/null
then
csih_warning "Setting password expiry for user '${csih_PRIVILEGED_USERNAME}' failed!"
@@ -3063,12 +3069,6 @@ csih_create_privileged_user()
fi
fi
- # If we use /etc account DB only, write new account to /etc/passwd
- if csih_use_file_etc passwd
- then
- /usr/bin/mkpasswd -l -u "${csih_PRIVILEGED_USERNAME}" >> "${SYSCONFDIR}/passwd"
- fi
-
return "${ret}"
fi # ! username_in_sam
return 1 # failed to create user (or prevented by auto-answer veto)
[-- Attachment #3: Type: text/plain, Size: 219 bytes --]
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-05-27 15:55 ` Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master Houder
@ 2017-05-28 13:46 ` Houder
2017-06-07 9:15 ` Corinna Vinschen
1 sibling, 0 replies; 9+ messages in thread
From: Houder @ 2017-05-28 13:46 UTC (permalink / raw)
To: cygwin
On Sat, 27 May 2017 14:01:09, Houder wrote:
> --=_f8e475c11eb2497bb7b3a74fbbff7888
> Content-Transfer-Encoding: 7bit
> Content-Type: text/plain; charset=US-ASCII;
> format=flowed
>
> On 2017-05-26 21:35, Houder wrote:
> > Hi,
> >
> > Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
> >
> > CSIH_SCRIPT = /usr/share/csih/cygwin-service-installation-helper.sh
>
> Retrieved CSIH_SCRIPT from the master (January 19 2017) here:
>
> https://cygwin.com/git/?p=cygwin-apps/csih.git;a=summary
>
> Attached patch file against master ...
Oh, by the way ...
My sshd daemon works flawlessly on W7 ... despite the fact the I am still
using /etc/passwd and /etc/group as the "database" (i.s.o. Windows' SAM).
(despite F-Secure SAFE, being a mandatory requirement for my machine).
(and, of course, despite the consequences of the errors in CSIH_SCRIPT; I
took care of them).
Regards,
Henri
-----
/etc/nsswitch.conf:
# 31 10 2014
# "db" = any 'place' where Windows keeps account info (my case: local SAM?)
# as far as I can tell, the next two lines forces the Cygwin1.dll to retrieve the account
# info solely from /etc/passwd and /etc/group, i.e. Windows' "db" is ignored ...
#
passwd: files
group: files
# as far as I can tell, this line applies to getent (i.e. getpwent() and getgrent())
db_enum: files
/etc/passwd:
SYSTEM:*:18:18:U-NT AUTHORITY\SYSTEM,S-1-5-18:/home/SYSTEM:/bin/bash
LOCAL SERVICE:*:19:19:,S-1-5-19:/:/sbin/nologin
NETWORK SERVICE:*:20:20:,S-1-5-20:/:/sbin/nologin
Administrators:*:544:544:,S-1-5-32-544:/:/sbin/nologin
..
cyg_server:*:1014:513:Privileged server,U-Seven\cyg_server,S-1-5-21-91509220-1575020443-2714799223-1014:/var/empty:/bin/bash
Henri:*:1000:513:U-Seven\Henri,S-1-5-21-91509220-1575020443-2714799223-1000:/home/Henri:/bin/bash
..
sshd:*:1013:513:U-Seven\sshd,S-1-5-21-91509220-1575020443-2714799223-1013:/var/empty:/bin/bash
/etc/group:
SYSTEM:S-1-5-18:18:
..
Administrators:S-1-5-32-544:544:
..
None:S-1-5-21-91509220-1575020443-2714799223-513:513:
..
@@ ls -ld ~ ~/.ssh
drwxr-xr-x+ 1 Henri None 0 May 27 08:16 /home/Henri
# modified by me? (744 => 700) ... not really required ...
drwx------+ 1 Henri None 0 May 26 13:22 /home/Henri/.ssh
@@ ls -l /etc/ssh*
-rw-r--r-- 1 cyg_server Administrators 1680 May 26 13:15 /etc/ssh_config
-rw------- 1 cyg_server Administrators 668 Jul 25 2016 /etc/ssh_host_<X-key>
-rw-r--r-- 1 cyg_server Administrators 601 Jul 25 2016 /etc/ssh_host_<X-key>.pub
-rw-r--r-- 1 cyg_server Administrators 3225 May 26 16:44 /etc/sshd_config
@@ ls -ld /var/empty /var/run
drwxr-xr-x+ 1 cyg_server Administrators 0 May 26 12:45 /var/empty
drwxrwxrwt+ 1 Henri None 0 May 26 21:28 /var/run
- "/var/empty must be owned by root and not group or world-writable."
- that is, owned by "cyg_server" (the privileged account, acting as the root user here)
@@ ls -l /var/run
-rw-r--r-- 1 cyg_server None 5 May 27 07:54 sshd.pid
# modified permissions to 660 for aestetic reason only
-rw-rw---- 1 Henri None 640 May 26 18:50 utmp
@@ ls -l /var/log/sshd.log # file exists if one has redirected the output of sshd.exe ...
-rw-r--r-- 1 cyg_server None 1767 May 26 21:28 /var/log/sshd.log
@@ getfacl /var/tmp # relevant here is ownership by cyg_server ...
# file: /var/empty
# owner: cyg_server
# group: Administrators
user::rwx
group::r-x
group:SYSTEM:r-x
group:Administrators:r-x
mask:r-x
other:r-x
default:user::rwx
default:group::r-x
default:other:r-x
@@ getfacl /var/run
# file: /var/run
# owner: Henri
# group: None
# flags: --t
user::rwx
group::rwx
group:SYSTEM:rwx
group:Administrators:rwx
mask:rwx
other:rwx
default:user::rwx
default:group::r-x
default:other:r-x
=====
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-05-27 15:55 ` Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master Houder
2017-05-28 13:46 ` Houder
@ 2017-06-07 9:15 ` Corinna Vinschen
2017-06-07 11:58 ` Houder
1 sibling, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-06-07 9:15 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Hi Houder,
On May 27 14:01, Houder wrote:
> On 2017-05-26 21:35, Houder wrote:
> > Hi,
> >
> > Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
> >
> > CSIH_SCRIPT = /usr/share/csih/cygwin-service-installation-helper.sh
>
> Retrieved CSIH_SCRIPT from the master (January 19 2017) here:
>
> https://cygwin.com/git/?p=cygwin-apps/csih.git;a=summary
>
> Attached patch file against master ...
Can you please recreate the patch with `git format-patch' and attach
it to your reply? That would be most helpful.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-06-07 9:15 ` Corinna Vinschen
@ 2017-06-07 11:58 ` Houder
2017-06-07 14:35 ` Corinna Vinschen
0 siblings, 1 reply; 9+ messages in thread
From: Houder @ 2017-06-07 11:58 UTC (permalink / raw)
To: cygwin
On Wed, 7 Jun 2017 11:15:01, Corinna Vinschen wrote:
> --24zk1gE8NUlDmwG9
> Content-Type: text/plain; charset=utf-8
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> Hi Houder,
>
> On May 27 14:01, Houder wrote:
> > On 2017-05-26 21:35, Houder wrote:
> > > Hi,
> > >=20
> > > Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
> > >=20
> > > CSIH_SCRIPT =3D /usr/share/csih/cygwin-service-installation-helper.sh
> >=20
> > Retrieved CSIH_SCRIPT from the master (January 19 2017) here:
> >=20
> > https://cygwin.com/git/?p=3Dcygwin-apps/csih.git;a=3Dsummary
> >=20
> > Attached patch file against master ...
>
> Can you please recreate the patch with `git format-patch' and attach
> it to your reply? That would be most helpful.
Sigh! ... it has been years and YEARS! since I exercised git. So I attempted
to do what you are asking for ...
- cloned csih
- branched
- created TWO fixes in that branch
- invoked 'git format-patch -n HEAD^^' # which is completely new to
Two files were created ... I included them here. Sufficient?
Regards,
Henri
-----
File 0001-Amend-prologue-of-csih_use_file_etc.patch:
From 2d96db1b32df33b142aa23afaa90ad21db74cc3d Mon Sep 17 00:00:00 2001
From: "J.H. van de Water" <houder@xs4all.nl>
Date: Wed, 7 Jun 2017 13:28:21 +0200
Subject: [PATCH 1/2] Amend prologue of csih_use_file_etc
Prologue (bottom) of csih_use_file_etc should state:
Returns 1 if files shall be used, 0 otherwise.
Currently it states the reverse.
---
cygwin-service-installation-helper.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cygwin-service-installation-helper.sh b/cygwin-service-installation-helper.sh
index a0b6216..f291edc 100755
--- a/cygwin-service-installation-helper.sh
+++ b/cygwin-service-installation-helper.sh
@@ -2566,7 +2566,7 @@ readonly -f csih_old_cygwin
#
# Otherwise, we need the files.
#
-# Returns 0 if files shall be used, 1 otherwise.
+# Returns 1 if files shall be used, 0 otherwise.
# ======================================================================
csih_use_file_etc()
{
--
2.7.5
-----
File 0002-Move-call-of-mkpasswd-UPwards-in-csih_create_privile.patch:
From d07d3a567f063d22c9eba381cbcc987b63a8eabb Mon Sep 17 00:00:00 2001
From: "J.H. van de Water" <houder@xs4all.nl>
Date: Wed, 7 Jun 2017 13:36:27 +0200
Subject: [PATCH 2/2] Move call of mkpasswd UPwards in
csih_create_privileged_user
Move call of mkpasswd UPwards in csih_create_privileged_user, and place it
before the 1st call of passwd.
---
cygwin-service-installation-helper.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/cygwin-service-installation-helper.sh b/cygwin-service-installation-helper.sh
index f291edc..14a40c1 100755
--- a/cygwin-service-installation-helper.sh
+++ b/cygwin-service-installation-helper.sh
@@ -3003,6 +3003,12 @@ csih_create_privileged_user()
csih_inform "the '${csih_PRIVILEGED_USERNAME}' account."
echo ""
+ # If we use /etc account DB only, write new account to /etc/passwd
+ if csih_use_file_etc passwd
+ then
+ /usr/bin/mkpasswd -l -u "${csih_PRIVILEGED_USERNAME}" >> "${SYSCONFDIR}/passwd"
+ fi
+
if ! passwd -e "${csih_PRIVILEGED_USERNAME}" >/dev/null
then
csih_warning "Setting password expiry for user '${csih_PRIVILEGED_USERNAME}' failed!"
@@ -3063,12 +3069,6 @@ csih_create_privileged_user()
fi
fi
- # If we use /etc account DB only, write new account to /etc/passwd
- if csih_use_file_etc passwd
- then
- /usr/bin/mkpasswd -l -u "${csih_PRIVILEGED_USERNAME}" >> "${SYSCONFDIR}/passwd"
- fi
-
return "${ret}"
fi # ! username_in_sam
return 1 # failed to create user (or prevented by auto-answer veto)
--
2.7.5
=====
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-06-07 11:58 ` Houder
@ 2017-06-07 14:35 ` Corinna Vinschen
2017-06-07 18:17 ` Houder
0 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-06-07 14:35 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]
On Jun 7 13:57, Houder wrote:
> On Wed, 7 Jun 2017 11:15:01, Corinna Vinschen wrote:
> > --24zk1gE8NUlDmwG9
> > Content-Type: text/plain; charset=utf-8
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> >
> > Hi Houder,
> >
> > On May 27 14:01, Houder wrote:
> > > On 2017-05-26 21:35, Houder wrote:
> > > > Hi,
> > > >=20
> > > > Installing sshd on W7 reveals errors in CSIH_SCRIPT ...
> > > >=20
> > > > CSIH_SCRIPT =3D /usr/share/csih/cygwin-service-installation-helper.sh
> > >=20
> > > Retrieved CSIH_SCRIPT from the master (January 19 2017) here:
> > >=20
> > > https://cygwin.com/git/?p=3Dcygwin-apps/csih.git;a=3Dsummary
> > >=20
> > > Attached patch file against master ...
> >
> > Can you please recreate the patch with `git format-patch' and attach
> > it to your reply? That would be most helpful.
>
> Sigh! ... it has been years and YEARS! since I exercised git. So I attempted
> to do what you are asking for ...
>
> - cloned csih
> - branched
> - created TWO fixes in that branch
> - invoked 'git format-patch -n HEAD^^' # which is completely new to
>
> Two files were created ... I included them here. Sufficient?
Well, this is pretty awkward. I have to extract the patches from the
mail and apply them then. It's easier to have them as *real* attachments,
or just sent as patch series by `git send-email'C, so they apply without
having to edit them.
But, either way, for now I just extracted them and pushed your patches.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-06-07 14:35 ` Corinna Vinschen
@ 2017-06-07 18:17 ` Houder
2017-06-07 18:56 ` Corinna Vinschen
0 siblings, 1 reply; 9+ messages in thread
From: Houder @ 2017-06-07 18:17 UTC (permalink / raw)
To: cygwin
On Wed, 7 Jun 2017 16:35:57, Corinna Vinschen wrote:
[snip]
> > Sigh! ... it has been years and YEARS! since I exercised git. So I attemp=
> ted
> > to do what you are asking for ...
> >=20
> > - cloned csih
> > - branched
> > - created TWO fixes in that branch
> > - invoked 'git format-patch -n HEAD^^' # which is completely new to
> >=20
> > Two files were created ... I included them here. Sufficient?
>
> Well, this is pretty awkward. I have to extract the patches from the
> mail and apply them then. It's easier to have them as *real* attachments,
> or just sent as patch series by `git send-email'C, so they apply without
> having to edit them.
Sorry ...
My regular MUA does not support 'In-Reply-to' ...
Therefore I cannot use my regular MUA, as I am NOT subcribed to the list; for
this reason, I make use of a kludge, which allows me to respond to the thread.
However this kludge does not support sending attachments.
Next time I will do both. Respond to the thread with a reply that will refer
to a message (sent by my regular MUA) which will have the attachements.
Would that fullfil all requirements?
Regards,
Henri
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master
2017-06-07 18:17 ` Houder
@ 2017-06-07 18:56 ` Corinna Vinschen
0 siblings, 0 replies; 9+ messages in thread
From: Corinna Vinschen @ 2017-06-07 18:56 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]
On Jun 7 20:17, Houder wrote:
> On Wed, 7 Jun 2017 16:35:57, Corinna Vinschen wrote:
>
> [snip]
> > > Sigh! ... it has been years and YEARS! since I exercised git. So I attemp=
> > ted
> > > to do what you are asking for ...
> > >=20
> > > - cloned csih
> > > - branched
> > > - created TWO fixes in that branch
> > > - invoked 'git format-patch -n HEAD^^' # which is completely new to
> > >=20
> > > Two files were created ... I included them here. Sufficient?
> >
> > Well, this is pretty awkward. I have to extract the patches from the
> > mail and apply them then. It's easier to have them as *real* attachments,
> > or just sent as patch series by `git send-email'C, so they apply without
> > having to edit them.
>
> Sorry ...
>
> My regular MUA does not support 'In-Reply-to' ...
>
> Therefore I cannot use my regular MUA, as I am NOT subcribed to the list; for
> this reason, I make use of a kludge, which allows me to respond to the thread.
`git send-email' creates the correct information automatically and it
doesn't use your MUA at all, so that's the easiest way to send patches
to a list, usually.
> However this kludge does not support sending attachments.
>
> Next time I will do both. Respond to the thread with a reply that will refer
> to a message (sent by my regular MUA) which will have the attachements.
>
> Would that fullfil all requirements?
It's not about "requirements" per se, it's just about making the stuff
easy for the typical, lazy maintainer ;)
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-06-07 18:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 19:38 Installing sshd on W7 reveals errors in CSIH_SCRIPT Houder
2017-05-27 11:35 ` Houder
2017-05-27 15:55 ` Installing sshd on W7 reveals errors in CSIH_SCRIPT -- patch file against master Houder
2017-05-28 13:46 ` Houder
2017-06-07 9:15 ` Corinna Vinschen
2017-06-07 11:58 ` Houder
2017-06-07 14:35 ` Corinna Vinschen
2017-06-07 18:17 ` Houder
2017-06-07 18:56 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).