Cygwin installer does not terminate

Cygwin installer does not terminate

[Stefan Smorra]

Hello,

I am running the x86 installer under 64bit Windows 10 (as administrator) 
as follows:

setup-x86.exe -q -P rsync -R C:\smo-cygwin


-q is quiet

"-P rsync" means install rsync package

"-R C:\smo-cygwin" is the destination installation path


The problem is that the installer does not terminate. It stays open in 
the background (hidden) what can be seen in the task manager.

Also it's consuming 90% CPU and the generated log file under 
C:\smo-cygwin\var\log\setup.log is about 12GiB after 5min.

The log file looks like this:

...
2021/11/29 13:21:38 Changing gid back to original
...
2021/11/29 13:22:05 running: C:\smo-cygwin\bin\dash.exe 
"/etc/postinstall/zp_man-db-update-index.dash"
2021/11/29 13:22:05 Changing gid to AdministratorsEnding cygwin install
...

The line "Changing gid to AdministratorsEnding cygwin install" then 
appears millions of times. It never ends and there are no other log 
lines coming.

Note that this only happens if I run the installer as administrator.


There seems to be problem when the installer changes gid. This can be 
seen in the log. The fact that it only happens if the installer is run 
as administrator approves this.

I also created a stackoverflow thread here 
https://superuser.com/questions/1689682/cygwin-installer-does-not-terminate-if-run-as-administrator


Best Regards

Stefan

Re: Cygwin installer does not terminate

[Jon Turney]

On 30/11/2021 09:09, Stefan Smorra wrote:
> Hello,
> 
> I am running the x86 installer under 64bit Windows 10 (as administrator) 
> as follows:
> 
[...]
> 
> The problem is that the installer does not terminate. It stays open in 
> the background (hidden) what can be seen in the task manager.
> 
> Also it's consuming 90% CPU and the generated log file under 
> C:\smo-cygwin\var\log\setup.log is about 12GiB after 5min.
> 
> The log file looks like this:
> 
> ...
> 2021/11/29 13:21:38 Changing gid back to original
> ...
> 2021/11/29 13:22:05 running: C:\smo-cygwin\bin\dash.exe 
> "/etc/postinstall/zp_man-db-update-index.dash"
> 2021/11/29 13:22:05 Changing gid to AdministratorsEnding cygwin install
> ...
> 
> The line "Changing gid to AdministratorsEnding cygwin install" then 
> appears millions of times. It never ends and there are no other log 
> lines coming.
> 
> Note that this only happens if I run the installer as administrator.
> 
> There seems to be problem when the installer changes gid. This can be 
> seen in the log. The fact that it only happens if the installer is run 
> as administrator approves this.

Thanks for reporting this problem.

After some staring at the code, I think the problem is perhaps that the 
linked list of log entries can get corrupted if multiple threads add 
messages to it simultaneously.

I built an updated setup with a change to avoid that in this case:

https://cygwin.com/setup/setup-2.910-3-g217aad.x86_64.exe
https://cygwin.com/setup/setup-2.910-3-g217aad.x86.exe

Perhaps you could try that and see if it improves things for you?

Re: Cygwin installer does not terminate

[Stefan Smorra]

Hello,

I don't know why you posted two corrected versions.

Because the x64 installer has always run smooth.


But I have tried your x86 installer and it now works well under 64bit 
Windows 10.

(It now terminates well.)

Maybe you can push this bug fix into the official Cygwin release.


Best regards

Re: Cygwin installer does not terminate

[Marco Atzeri]

On 08.12.2021 10:31, Stefan Smorra wrote:
> Hello,
> 
> I don't know why you posted two corrected versions.

Hi  Stefan,

because Jon, as very efficient setup maintainer,
is always providing build for both architectures
for further testing.


> Because the x64 installer has always run smooth.
> 
> 
> But I have tried your x86 installer and it now works well under 64bit 
> Windows 10.
> 
> (It now terminates well.)
> 
> Maybe you can push this bug fix into the official Cygwin release.

No doubt about it ;-)

> Best regards

Regards
Marco