Failed assertion in path.cc (path_conv::check)

Failed assertion in path.cc (path_conv::check)

[Charles Wilson]

The following statement:

char * tmp_path =
    (char *) cygwin_create_path (CCP_POSIX_TO_WIN_A, newargz[0]);

Results in this error popup (and a coredump), when newargz[0] is NULL. 
Sure, it's a bug in my program to do that...but shouldn't it be handled 
more gracefully?  Like...return a NULL, rather than SIGABRT?

Failed assertion
	src
at line 675 of file
/home/corinna/src/cygwin/cygwin-1.7.21/64/cygwin-1.7.21-5/src
/src/winsup/cygwin/path.cc
in function void path_conv::check(const char*, unsigned int, const 
suffix_info*)

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Failed assertion in path.cc (path_conv::check)

[Corinna Vinschen]

On Jun 21 03:26, Charles Wilson wrote:
> The following statement:
> 
> char * tmp_path =
>    (char *) cygwin_create_path (CCP_POSIX_TO_WIN_A, newargz[0]);
> 
> Results in this error popup (and a coredump), when newargz[0] is
> NULL. Sure, it's a bug in my program to do that...but shouldn't it
> be handled more gracefully?  Like...return a NULL, rather than
> SIGABRT?

I changed the underlying cygwin_conv_path to handle NULL gracefully
by returning -1 and setting errno to EINVAL.  This results in a NULL
return from cygwin_create_path.


HTH,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Failed assertion in path.cc (path_conv::check)

[Charles Wilson]

On 6/21/2013 4:21 AM, Corinna Vinschen wrote:
> On Jun 21 03:26, Charles Wilson wrote:
>> The following statement:
>>
>> char * tmp_path =
>>     (char *) cygwin_create_path (CCP_POSIX_TO_WIN_A, newargz[0]);
>>
>> Results in this error popup (and a coredump), when newargz[0] is
>> NULL. Sure, it's a bug in my program to do that...but shouldn't it
>> be handled more gracefully?  Like...return a NULL, rather than
>> SIGABRT?
>
> I changed the underlying cygwin_conv_path to handle NULL gracefully
> by returning -1 and setting errno to EINVAL.  This results in a NULL
> return from cygwin_create_path.

Using the old (buggy) version of my program, this change to the 
cygwin1.dll DTRT and I don't see the coredump anymore.  Thanks.

'Course, I've fixed my program to not do that, but this was still a 
cygwin bug IMO so thanks for fixing it.

--
Chuck



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple