* Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
@ 2013-10-24 14:17 Adam Cécile
2013-10-24 15:19 ` Corinna Vinschen
0 siblings, 1 reply; 11+ messages in thread
From: Adam Cécile @ 2013-10-24 14:17 UTC (permalink / raw)
To: cygwin
Hello,
I'm unable to rebuild current cygwin1.dll:
Running:
rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
./configure && LANG=C make
Fails after a while with the following error:
make[2]: Entering directory
'/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/winsup'
make[3]: Entering directory
'/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/winsup/cygwin'
../../.././winsup/cygwin/gentls_offsets
../../.././winsup/cygwin/cygtls.h ../../.././winsup/cygwin/tlsoffsets.h
i686 c++wrap -O2 -g -fno-rtti -fno-exceptions -Wall -Wstrict-aliasing
-Wwrite-strings -fno-common -pipe -fbuiltin -fmessage-length=0 -MMD
-Werror -fmerge-constants -ftracer -c
+ g++ -L/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/winsup/cygwin
-isystem /cygdrive/c/cygwin-rebuild/src/winsup/cygwin/include
-B/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/newlib/ -isystem
/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/newlib/targ-include
-isystem /cygdrive/c/cygwin-rebuild/src/newlib/libc/include -xc++
-nostdinc -I. -I../../.././winsup/cygwin -isystem
/cygdrive/c/cygwin-rebuild/src/winsup/cygwin/include -isystem
/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/newlib/targ-include
-isystem /cygdrive/c/cygwin-rebuild/src/newlib/libc/include -isystem
/cygdrive/c/cygwin-rebuild/src/winsup/cygwin/include -isystem
/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/newlib/targ-include
-isystem /cygdrive/c/cygwin-rebuild/src/newlib/libc/include -isystem
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include/c++ -isystem
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include/c++/i686-pc-cygwin -isystem
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include/c++/backward -isystem
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include -isystem
/usr/lib/gcc/i686-pc-cygwin/4.7.3/include-fixed -isystem /usr/include
-isystem /usr/include/w32api -O2 -g -fno-rtti -fno-exceptions -Wall
-Wstrict-aliasing -Wwrite-strings -fno-common -pipe -fbuiltin
-fmessage-length=0 -MMD -Werror -fmerge-constants -ftracer -c
-D_XMMINTRIN_H_INCLUDED -D_ADXINTRIN_H_INCLUDED -D_EMMINTRIN_H_INCLUDED
-D_X86INTRIN_H_INCLUDED -o /tmp/2576-1.cc -E /tmp/2576.cc
../../.././winsup/cygwin/gendef --cpu=i686 --output-def=cygwin.def
--tlsoffsets=../../.././winsup/cygwin/tlsoffsets.h
../../.././winsup/cygwin/i686.din ../../.././winsup/cygwin/common.din
../../.././winsup/cygwin/mkglobals_h ../../.././winsup/cygwin/globals.cc
> globals.h
c++wrap -O2 -g -fno-rtti -fno-exceptions -Wall -Wstrict-aliasing
-Wwrite-strings -fno-common -pipe -fbuiltin -fmessage-length=0 -MMD
-Werror -fmerge-constants -ftracer -c -o _cygwin_crt0_common.o
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc
In file included from ../../.././winsup/cygwin/cygtls.h:279:0,
from ./globals.h:5,
from ../../.././winsup/cygwin/winsup.h:302,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
../../.././winsup/cygwin/ntdll.h:72:0: error: "TRANSACTION_ALL_ACCESS"
redefined [-Werror]
In file included from /usr/include/w32api/minwindef.h:146:0,
from /usr/include/w32api/windef.h:8,
from /usr/include/w32api/windows.h:69,
from ../../.././winsup/cygwin/winlean.h:52,
from ../../.././winsup/cygwin/winsup.h:76,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
/usr/include/w32api/winnt.h:8184:0: note: this is the location of the
previous definition
In file included from ../../.././winsup/cygwin/cygtls.h:279:0,
from ./globals.h:5,
from ../../.././winsup/cygwin/winsup.h:302,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
../../.././winsup/cygwin/ntdll.h:1117:14: error: multiple definition of
'enum _THREAD_INFORMATION_CLASS'
In file included from ../../.././winsup/cygwin/winbase.h:9:0,
from /usr/include/w32api/windows.h:70,
from ../../.././winsup/cygwin/winlean.h:52,
from ../../.././winsup/cygwin/winsup.h:76,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
/usr/include/w32api/winbase.h:1160:16: error: previous definition here
In file included from ../../.././winsup/cygwin/cygtls.h:279:0,
from ./globals.h:5,
from ../../.././winsup/cygwin/winsup.h:302,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
../../.././winsup/cygwin/ntdll.h:1122:27: error: invalid type in
declaration before ',' token
../../.././winsup/cygwin/ntdll.h:1122:27: error: conflicting declaration
'typedef int THREAD_INFORMATION_CLASS'
In file included from ../../.././winsup/cygwin/winbase.h:9:0,
from /usr/include/w32api/windows.h:70,
from ../../.././winsup/cygwin/winlean.h:52,
from ../../.././winsup/cygwin/winsup.h:76,
from
../../.././winsup/cygwin/lib/_cygwin_crt0_common.cc:12:
/usr/include/w32api/winbase.h:1164:5: error: 'THREAD_INFORMATION_CLASS'
has a previous declaration as 'typedef enum _THREAD_INFORMATION_CLASS
THREAD_INFORMATION_CLASS'
cc1plus: all warnings being treated as errors
../../.././winsup/cygwin/../Makefile.common:43: recipe for target
'_cygwin_crt0_common.o' failed
make[3]: *** [_cygwin_crt0_common.o] Error 1
make[3]: Leaving directory
'/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/winsup/cygwin'
Makefile:82: recipe for target 'cygwin' failed
make[2]: *** [cygwin] Error 1
make[2]: Leaving directory
'/cygdrive/c/cygwin-rebuild/src/i686-pc-cygwin/winsup'
Makefile:8381: recipe for target 'all-target-winsup' failed
make[1]: *** [all-target-winsup] Error 2
make[1]: Leaving directory '/cygdrive/c/cygwin-rebuild/src'
Makefile:833: recipe for target 'all' failed
make: *** [all] Error 2
Thanks in advance!
--
Adam CÉCILE
Mandriva / Linbox
1, Rue Pierre Simon de Laplace : 0 810 LINBOX
F-57070 Metz direct : +33 1 76 64 16 65
FRANCE www.mandriva.com
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-24 14:17 Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror] Adam Cécile
@ 2013-10-24 15:19 ` Corinna Vinschen
2013-10-24 19:50 ` Alexey Pavlov
2013-10-30 9:49 ` Adam Cécile
0 siblings, 2 replies; 11+ messages in thread
From: Corinna Vinschen @ 2013-10-24 15:19 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Oct 24 16:16, Adam Cécile wrote:
> Hello,
>
> I'm unable to rebuild current cygwin1.dll:
>
> Running:
>
> rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
1.7.25 is current, not 1.7.24.
You won't be able to build 1.7.25 with the most recent w32api packages
either. They introduced this incompatibility. Either downgrade
the w32api-* packages to the previous version, or try to build Cygwin
from CVS HEAD instead:
http://cygwin.com/cvs.html
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-24 15:19 ` Corinna Vinschen
@ 2013-10-24 19:50 ` Alexey Pavlov
2013-10-26 6:25 ` Alexey Pavlov
2013-10-30 9:49 ` Adam Cécile
1 sibling, 1 reply; 11+ messages in thread
From: Alexey Pavlov @ 2013-10-24 19:50 UTC (permalink / raw)
To: cygwin
2013/10/24 Corinna Vinschen:
> On Oct 24 16:16, Adam Cécile wrote:
>> Hello,
>>
>> I'm unable to rebuild current cygwin1.dll:
>>
>> Running:
>>
>> rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
>
> 1.7.25 is current, not 1.7.24.
>
> You won't be able to build 1.7.25 with the most recent w32api packages
> either. They introduced this incompatibility. Either downgrade
> the w32api-* packages to the previous version, or try to build Cygwin
> from CVS HEAD instead:
>
> http://cygwin.com/cvs.html
>
>
Same errors from last cvs revision.
Regards,
Alexey.
> Corinna
>
> --
> Corinna Vinschen Please, send mails regarding Cygwin to
> Cygwin Maintainer cygwin AT cygwin DOT com
> Red Hat
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-24 19:50 ` Alexey Pavlov
@ 2013-10-26 6:25 ` Alexey Pavlov
2013-10-26 6:32 ` Christopher Faylor
0 siblings, 1 reply; 11+ messages in thread
From: Alexey Pavlov @ 2013-10-26 6:25 UTC (permalink / raw)
To: cygwin
2013/10/24 Alexey Pavlov:
> 2013/10/24 Corinna Vinschen:
>> On Oct 24 16:16, Adam Cécile wrote:
>>> Hello,
>>>
>>> I'm unable to rebuild current cygwin1.dll:
>>>
>>> Running:
>>>
>>> rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
>>
>> 1.7.25 is current, not 1.7.24.
>>
>> You won't be able to build 1.7.25 with the most recent w32api packages
>> either. They introduced this incompatibility. Either downgrade
>> the w32api-* packages to the previous version, or try to build Cygwin
>> from CVS HEAD instead:
>>
>> http://cygwin.com/cvs.html
>>
>>
>
> Same errors from last cvs revision.
>
I see that some errors are gone by yesterday commits but new one present now:
In file included from /work/Cygwin/winsup/cygwin/cygtls.cc:20:0:
/work/Cygwin/winsup/cygwin/exception.h:12:25: error: redefinition of
‘struct _EXCEPTION_REGISTRATION_RECORD’
#define _exception_list _EXCEPTION_REGISTRATION_RECORD
^
In file included from /usr/include/w32api/minwindef.h:146:0,
from /usr/include/w32api/windef.h:8,
from /usr/include/w32api/windows.h:69,
from /work/Cygwin/winsup/cygwin/winlean.h:52,
from /work/Cygwin/winsup/cygwin/winsup.h:76,
from /work/Cygwin/winsup/cygwin/cygtls.cc:10:
/usr/include/w32api/winnt.h:3541:20: error: previous definition of
‘struct _EXCEPTION_REGISTRATION_RECORD’
typedef struct _EXCEPTION_REGISTRATION_RECORD {
^
In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
type in declaration before ‘;’ token
} exception_list;
^
/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
'cygtls.o' failed
make[3]: *** [cygtls.o] Error 1
> Regards,
> Alexey.
>
>> Corinna
>>
>> --
>> Corinna Vinschen Please, send mails regarding Cygwin to
>> Cygwin Maintainer cygwin AT cygwin DOT com
>> Red Hat
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-26 6:25 ` Alexey Pavlov
@ 2013-10-26 6:32 ` Christopher Faylor
2013-10-26 10:00 ` Corinna Vinschen
0 siblings, 1 reply; 11+ messages in thread
From: Christopher Faylor @ 2013-10-26 6:32 UTC (permalink / raw)
To: cygwin
On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
>2013/10/24 Alexey Pavlov:
>> 2013/10/24 Corinna Vinschen:
>>> On Oct 24 16:16, Adam C?cile wrote:
>>>> Hello,
>>>>
>>>> I'm unable to rebuild current cygwin1.dll:
>>>>
>>>> Running:
>>>>
>>>> rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
>>>
>>> 1.7.25 is current, not 1.7.24.
>>>
>>> You won't be able to build 1.7.25 with the most recent w32api packages
>>> either. They introduced this incompatibility. Either downgrade
>>> the w32api-* packages to the previous version, or try to build Cygwin
>>> from CVS HEAD instead:
>>>
>>> http://cygwin.com/cvs.html
>>>
>>>
>>
>> Same errors from last cvs revision.
>>
>I see that some errors are gone by yesterday commits but new one present now:
>
>In file included from /work/Cygwin/winsup/cygwin/cygtls.cc:20:0:
>/work/Cygwin/winsup/cygwin/exception.h:12:25: error: redefinition of
>?struct _EXCEPTION_REGISTRATION_RECORD?
> #define _exception_list _EXCEPTION_REGISTRATION_RECORD
> ^
>In file included from /usr/include/w32api/minwindef.h:146:0,
> from /usr/include/w32api/windef.h:8,
> from /usr/include/w32api/windows.h:69,
> from /work/Cygwin/winsup/cygwin/winlean.h:52,
> from /work/Cygwin/winsup/cygwin/winsup.h:76,
> from /work/Cygwin/winsup/cygwin/cygtls.cc:10:
>/usr/include/w32api/winnt.h:3541:20: error: previous definition of
>?struct _EXCEPTION_REGISTRATION_RECORD?
> typedef struct _EXCEPTION_REGISTRATION_RECORD {
> ^
>In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
> from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
>/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
>type in declaration before ?;? token
> } exception_list;
> ^
>/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
>'cygtls.o' failed
>make[3]: *** [cygtls.o] Error 1
Feel free to provide patches. Simple compilation issues do not
require copyright assignment.
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-26 6:32 ` Christopher Faylor
@ 2013-10-26 10:00 ` Corinna Vinschen
2013-10-27 5:01 ` Christopher Faylor
0 siblings, 1 reply; 11+ messages in thread
From: Corinna Vinschen @ 2013-10-26 10:00 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]
On Oct 26 02:25, Christopher Faylor wrote:
> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
> >/usr/include/w32api/winnt.h:3541:20: error: previous definition of
> >?struct _EXCEPTION_REGISTRATION_RECORD?
> > typedef struct _EXCEPTION_REGISTRATION_RECORD {
> > ^
> >In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
> > from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
> >/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
> >type in declaration before ?;? token
> > } exception_list;
> > ^
> >/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
> >'cygtls.o' failed
> >make[3]: *** [cygtls.o] Error 1
>
> Feel free to provide patches. Simple compilation issues do not
> require copyright assignment.
I applied a patch. The redefinition of _exception_list to
_EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
"just build, goddammit" porting stage. Later on it turned out that
x86_64 doesn't use frame based exception handling anyway so all the
code using _exception_list is unused on x86_64 anyway.
I also changed the public header <exceptions.h> so that it only
applies if !x86_64.
That leads to a question:
Why on earth do we have a *public* header exposing the exception
handling on a certain CPU? This isn't a standard header, neither POSIX
nor Linux nor BSD systems have it.
If there isn't a compelling reason to keep the header, I would opt
for folding the content into the private Cygwin header exception.h
and drop the public header entirely.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-26 10:00 ` Corinna Vinschen
@ 2013-10-27 5:01 ` Christopher Faylor
2013-10-27 13:05 ` Corinna Vinschen
0 siblings, 1 reply; 11+ messages in thread
From: Christopher Faylor @ 2013-10-27 5:01 UTC (permalink / raw)
To: cygwin
On Sat, Oct 26, 2013 at 11:47:04AM +0200, Corinna Vinschen wrote:
>On Oct 26 02:25, Christopher Faylor wrote:
>> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
>> >/usr/include/w32api/winnt.h:3541:20: error: previous definition of
>> >?struct _EXCEPTION_REGISTRATION_RECORD?
>> > typedef struct _EXCEPTION_REGISTRATION_RECORD {
>> > ^
>> >In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
>> > from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
>> >/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
>> >type in declaration before ?;? token
>> > } exception_list;
>> > ^
>> >/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
>> >'cygtls.o' failed
>> >make[3]: *** [cygtls.o] Error 1
>>
>> Feel free to provide patches. Simple compilation issues do not
>> require copyright assignment.
>
>I applied a patch. The redefinition of _exception_list to
>_EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
>"just build, goddammit" porting stage. Later on it turned out that
>x86_64 doesn't use frame based exception handling anyway so all the
>code using _exception_list is unused on x86_64 anyway.
>
>I also changed the public header <exceptions.h> so that it only
>applies if !x86_64.
>
>That leads to a question:
>
>Why on earth do we have a *public* header exposing the exception
>handling on a certain CPU? This isn't a standard header, neither POSIX
>nor Linux nor BSD systems have it.
>
>If there isn't a compelling reason to keep the header, I would opt
>for folding the content into the private Cygwin header exception.h
>and drop the public header entirely.
I think its existence predates me. I vote to nuke it.
cgf
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-27 5:01 ` Christopher Faylor
@ 2013-10-27 13:05 ` Corinna Vinschen
2013-10-28 17:01 ` Larry Hall (Cygwin)
0 siblings, 1 reply; 11+ messages in thread
From: Corinna Vinschen @ 2013-10-27 13:05 UTC (permalink / raw)
To: cygwin
[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]
On Oct 26 21:27, Christopher Faylor wrote:
> On Sat, Oct 26, 2013 at 11:47:04AM +0200, Corinna Vinschen wrote:
> >On Oct 26 02:25, Christopher Faylor wrote:
> >> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
> >> >/usr/include/w32api/winnt.h:3541:20: error: previous definition of
> >> >?struct _EXCEPTION_REGISTRATION_RECORD?
> >> > typedef struct _EXCEPTION_REGISTRATION_RECORD {
> >> > ^
> >> >In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
> >> > from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
> >> >/work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
> >> >type in declaration before ?;? token
> >> > } exception_list;
> >> > ^
> >> >/work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
> >> >'cygtls.o' failed
> >> >make[3]: *** [cygtls.o] Error 1
> >>
> >> Feel free to provide patches. Simple compilation issues do not
> >> require copyright assignment.
> >
> >I applied a patch. The redefinition of _exception_list to
> >_EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
> >"just build, goddammit" porting stage. Later on it turned out that
> >x86_64 doesn't use frame based exception handling anyway so all the
> >code using _exception_list is unused on x86_64 anyway.
> >
> >I also changed the public header <exceptions.h> so that it only
> >applies if !x86_64.
> >
> >That leads to a question:
> >
> >Why on earth do we have a *public* header exposing the exception
> >handling on a certain CPU? This isn't a standard header, neither POSIX
> >nor Linux nor BSD systems have it.
> >
> >If there isn't a compelling reason to keep the header, I would opt
> >for folding the content into the private Cygwin header exception.h
> >and drop the public header entirely.
>
> I think its existence predates me. I vote to nuke it.
2 pro votes, 0 dissenting votes. Done. I just hope the voting period
wasn't too short...
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-27 13:05 ` Corinna Vinschen
@ 2013-10-28 17:01 ` Larry Hall (Cygwin)
2013-10-28 17:17 ` Christopher Faylor
0 siblings, 1 reply; 11+ messages in thread
From: Larry Hall (Cygwin) @ 2013-10-28 17:01 UTC (permalink / raw)
To: cygwin
On 10/27/2013 5:51 AM, Corinna Vinschen wrote:
> On Oct 26 21:27, Christopher Faylor wrote:
>> On Sat, Oct 26, 2013 at 11:47:04AM +0200, Corinna Vinschen wrote:
>>> On Oct 26 02:25, Christopher Faylor wrote:
>>>> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
>>>>> /usr/include/w32api/winnt.h:3541:20: error: previous definition of
>>>>> ?struct _EXCEPTION_REGISTRATION_RECORD?
>>>>> typedef struct _EXCEPTION_REGISTRATION_RECORD {
>>>>> ^
>>>>> In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
>>>>> from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
>>>>> /work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
>>>>> type in declaration before ?;? token
>>>>> } exception_list;
>>>>> ^
>>>>> /work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
>>>>> 'cygtls.o' failed
>>>>> make[3]: *** [cygtls.o] Error 1
>>>>
>>>> Feel free to provide patches. Simple compilation issues do not
>>>> require copyright assignment.
>>>
>>> I applied a patch. The redefinition of _exception_list to
>>> _EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
>>> "just build, goddammit" porting stage. Later on it turned out that
>>> x86_64 doesn't use frame based exception handling anyway so all the
>>> code using _exception_list is unused on x86_64 anyway.
>>>
>>> I also changed the public header <exceptions.h> so that it only
>>> applies if !x86_64.
>>>
>>> That leads to a question:
>>>
>>> Why on earth do we have a *public* header exposing the exception
>>> handling on a certain CPU? This isn't a standard header, neither POSIX
>>> nor Linux nor BSD systems have it.
>>>
>>> If there isn't a compelling reason to keep the header, I would opt
>>> for folding the content into the private Cygwin header exception.h
>>> and drop the public header entirely.
>>
>> I think its existence predates me. I vote to nuke it.
>
> 2 pro votes, 0 dissenting votes. Done. I just hope the voting period
> wasn't too short...
I demand a recount! ;-)
--
Larry
_____________________________________________________________________
A: Yes.
> Q: Are you sure?
>> A: Because it reverses the logical flow of conversation.
>>> Q: Why is top posting annoying in email?
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-28 17:01 ` Larry Hall (Cygwin)
@ 2013-10-28 17:17 ` Christopher Faylor
0 siblings, 0 replies; 11+ messages in thread
From: Christopher Faylor @ 2013-10-28 17:17 UTC (permalink / raw)
To: cygwin
On Mon, Oct 28, 2013 at 12:43:04PM -0400, Larry Hall (Cygwin) wrote:
>On 10/27/2013 5:51 AM, Corinna Vinschen wrote:
>> On Oct 26 21:27, Christopher Faylor wrote:
>>> On Sat, Oct 26, 2013 at 11:47:04AM +0200, Corinna Vinschen wrote:
>>>> On Oct 26 02:25, Christopher Faylor wrote:
>>>>> On Sat, Oct 26, 2013 at 10:14:01AM +0400, Alexey Pavlov wrote:
>>>>>> /usr/include/w32api/winnt.h:3541:20: error: previous definition of
>>>>>> ?struct _EXCEPTION_REGISTRATION_RECORD?
>>>>>> typedef struct _EXCEPTION_REGISTRATION_RECORD {
>>>>>> ^
>>>>>> In file included from /work/Cygwin/winsup/cygwin/exception.h:15:0,
>>>>>> from /work/Cygwin/winsup/cygwin/cygtls.cc:20:
>>>>>> /work/Cygwin/winsup/cygwin/include/exceptions.h:109:17: error: invalid
>>>>>> type in declaration before ?;? token
>>>>>> } exception_list;
>>>>>> ^
>>>>>> /work/Cygwin/winsup/cygwin/../Makefile.common:43: recipe for target
>>>>>> 'cygtls.o' failed
>>>>>> make[3]: *** [cygtls.o] Error 1
>>>>>
>>>>> Feel free to provide patches. Simple compilation issues do not
>>>>> require copyright assignment.
>>>>
>>>> I applied a patch. The redefinition of _exception_list to
>>>> _EXCEPTION_REGISTRATION_RECORD for x86_64 was cruft from a very early
>>>> "just build, goddammit" porting stage. Later on it turned out that
>>>> x86_64 doesn't use frame based exception handling anyway so all the
>>>> code using _exception_list is unused on x86_64 anyway.
>>>>
>>>> I also changed the public header <exceptions.h> so that it only
>>>> applies if !x86_64.
>>>>
>>>> That leads to a question:
>>>>
>>>> Why on earth do we have a *public* header exposing the exception
>>>> handling on a certain CPU? This isn't a standard header, neither POSIX
>>>> nor Linux nor BSD systems have it.
>>>>
>>>> If there isn't a compelling reason to keep the header, I would opt
>>>> for folding the content into the private Cygwin header exception.h
>>>> and drop the public header entirely.
>>>
>>> I think its existence predates me. I vote to nuke it.
>>
>> 2 pro votes, 0 dissenting votes. Done. I just hope the voting period
>> wasn't too short...
>
>I demand a recount! ;-)
Looks like, with 2 people responding, the votes are now 5 pro, 0
dissenting. Luckily for us we use Diebold voting machines so there is
no possibility of error.
cgf
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror]
2013-10-24 15:19 ` Corinna Vinschen
2013-10-24 19:50 ` Alexey Pavlov
@ 2013-10-30 9:49 ` Adam Cécile
1 sibling, 0 replies; 11+ messages in thread
From: Adam Cécile @ 2013-10-30 9:49 UTC (permalink / raw)
To: cygwin
Le 24/10/2013 17:09, Corinna Vinschen a écrit :
> On Oct 24 16:16, Adam Cécile wrote:
>> Hello,
>>
>> I'm unable to rebuild current cygwin1.dll:
>>
>> Running:
>>
>> rm -rf src/ && tar xvjf winsup-1.7.24.tar.bz2 && cd src && LANG=C
> 1.7.25 is current, not 1.7.24.
>
> You won't be able to build 1.7.25 with the most recent w32api packages
> either. They introduced this incompatibility. Either downgrade
> the w32api-* packages to the previous version, or try to build Cygwin
> from CVS HEAD instead:
>
> http://cygwin.com/cvs.html
>
>
> Corinna
>
Hello,
Indeed, downgrading w32api packages fixed the issue. Thanks for your help!
Regards, Adam.
--
Adam CÉCILE
Mandriva / Linbox
1, Rue Pierre Simon de Laplace : 0 810 LINBOX
F-57070 Metz direct : +33 1 76 64 16 65
FRANCE www.mandriva.com
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-10-30 9:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-24 14:17 Rebuilding cygwin1.dll - error: "TRANSACTION_ALL_ACCESS" redefined [-Werror] Adam Cécile
2013-10-24 15:19 ` Corinna Vinschen
2013-10-24 19:50 ` Alexey Pavlov
2013-10-26 6:25 ` Alexey Pavlov
2013-10-26 6:32 ` Christopher Faylor
2013-10-26 10:00 ` Corinna Vinschen
2013-10-27 5:01 ` Christopher Faylor
2013-10-27 13:05 ` Corinna Vinschen
2013-10-28 17:01 ` Larry Hall (Cygwin)
2013-10-28 17:17 ` Christopher Faylor
2013-10-30 9:49 ` Adam Cécile
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).