[PATCH] cygcheck-dep 2.0-1: Bogus output from -l option

[PATCH] cygcheck-dep 2.0-1: Bogus output from -l option

[Christian Franke]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

The 'cygcheck-dep -l' output also lists various packages which are 
actually required by other packages.

Testcase:

$ cygcheck -f /bin/cygcheck-dep
cygcheck-dep-2.0-1

$ cygcheck-dep -c -N ncursesw
  ncursesw: is recursively needed for ( )

$ cygcheck-dep -c -N ncurses
  ncurses: is recursively needed for ( ncursesw )

$ cygcheck-dep -c -l | grep '^ ncurses'
  ncurses
  ncursesw

The attached patch should fix that.

Christian


[-- Attachment #2: cygcheck-dep-2.0-1.option-l.patch --]
[-- Type: text/x-patch, Size: 417 bytes --]

--- cygcheck-dep.orig	2013-12-06 22:08:41.000000000 +0100
+++ cygcheck-dep	2015-03-25 07:25:10.336495900 +0100
@@ -581,7 +581,7 @@
 fi
 
 if [ "$f_nonleaves_be_necessary" ]; then
-  nonleaf_pkgs="$(IFS=$'\n' sort -n <<<"${pkg_drequisites[*]}" | sed '/^$/d' | uniq -c | sort -r | sed 's/^.* //')"
+  nonleaf_pkgs="$(IFS=$'\n'; tr ' ' '\n' <<<"${pkg_drequisites[*]}" | sed '/^$/d' | sort -n | uniq)"
 fi
 ####### */
 


[-- Attachment #3: Type: text/plain, Size: 218 bytes --]

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [PATCH] cygcheck-dep 2.0-1: Bogus output from -l option

[Mikhail Usenko]

On Wed, 25 Mar 2015 07:34:32 +0100
Christian Franke <...> wrote:

> The 'cygcheck-dep -l' output also lists various packages which are 
> actually required by other packages.
> 
> The attached patch should fix that.
> 
> Christian
 
Hello, Christian.

Sorry for not responding earlier.
Thank you very much for reporting the bug.
There is a semicolon that is missed after IFS assignment in the subshell.
I will upload a bug fix release.


-- 
Mike

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple