public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Christian Franke <Christian.Franke@t-online.de>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1
Date: Sun, 04 Sep 2016 11:10:00 -0000	[thread overview]
Message-ID: <57CC0128.3080900@t-online.de> (raw)
In-Reply-To: <announce.878tv914ya.fsf@Rainer.invalid>

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Achim Gratz wrote:
> 4.3-1 (feature release)
>      * Cygwin.bat: Add to base-files.  This version is independent of
>        the actual install path, see:
>        cygwin.com/ml/cygwin/2016-08/msg00617.html

Thanks for accepting the patch.

Unfortunately I missed a detail: The postinstall script does not 
preserve the x-permission of Cygwin.bat. This is required if run from 
explorer or with 'cygstart /Cygwin.bat'.

Possible fix attached. Alternatively remove the 'touch' command and the 
x-permission from etc/defaults/etc/profile.

Thanks,
Christian


[-- Attachment #2: base-files-4.3-1-x-perm.patch --]
[-- Type: text/x-patch, Size: 496 bytes --]

--- base-files-profile.sh.orig	2016-09-03 13:37:59.000000000 +0200
+++ base-files-profile.sh	2016-09-04 12:42:40.805222900 +0200
@@ -18,7 +18,7 @@
   if [ ! -e ${fDest} -a ! -L ${fDest} ]; then
     echo "Using the default version of ${fDest} (${fSrc})"
     /usr/bin/mkdir -p $(dirname ${fDest})
-    /usr/bin/touch ${fDest}
+    test "${fDest}" = "/Cygwin.bat" || /usr/bin/touch ${fDest}
     /usr/bin/cp ${fSrc} ${fDest}
   else
     echo "${fDest} is already in existence, not overwriting."


[-- Attachment #3: Type: text/plain, Size: 218 bytes --]

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

  reply	other threads:[~2016-09-04 11:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-03 15:38 Achim Gratz
2016-09-04 11:10 ` Christian Franke [this message]
2016-09-04 11:30   ` Achim Gratz
2016-09-04 12:13     ` Christian Franke
2016-09-04 14:37       ` Achim Gratz
2016-09-04 14:47         ` Christian Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57CC0128.3080900@t-online.de \
    --to=christian.franke@t-online.de \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).