From: Christian Franke <Christian.Franke@t-online.de>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1
Date: Sun, 04 Sep 2016 12:13:00 -0000 [thread overview]
Message-ID: <57CC0FD6.9000006@t-online.de> (raw)
In-Reply-To: <87k2ersy04.fsf@Rainer.invalid>
Achim Gratz wrote:
> Christian Franke writes:
>> --- base-files-profile.sh.orig 2016-09-03 13:37:59.000000000 +0200
>> +++ base-files-profile.sh 2016-09-04 12:42:40.805222900 +0200
>> @@ -18,7 +18,7 @@
>> if [ ! -e ${fDest} -a ! -L ${fDest} ]; then
>> echo "Using the default version of ${fDest} (${fSrc})"
>> /usr/bin/mkdir -p $(dirname ${fDest})
>> - /usr/bin/touch ${fDest}
>> + test "${fDest}" = "/Cygwin.bat" || /usr/bin/touch ${fDest}
>> /usr/bin/cp ${fSrc} ${fDest}
>> else
>> echo "${fDest} is already in existence, not overwriting."
> I have no idea why it's touching the file first, but I'd rather use
>
> cp --preserve=mode
>
> and fix the mode bits in /etc/defaults if necessary.
I guess the touch command is from the early days to ensure that all
files get same default permissions regardless of source file permissions.
Removing the touch command would be sufficient. A 'cp' without options
uses the permission mask from source file when a new file is created
(POSIX requirement). Cygport's make_etc_defaults also generates plain
/usr/bin/cp commands.
"cp --preserve" would also copy owner and timestamps.
Regards,
Christian
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2016-09-04 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 15:38 Achim Gratz
2016-09-04 11:10 ` Christian Franke
2016-09-04 11:30 ` Achim Gratz
2016-09-04 12:13 ` Christian Franke [this message]
2016-09-04 14:37 ` Achim Gratz
2016-09-04 14:47 ` Christian Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CC0FD6.9000006@t-online.de \
--to=christian.franke@t-online.de \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).