From: Mark Geisert <mark@maxrnd.com>
To: cygwin@cygwin.com
Subject: Re: util-linux-2.39.3-1: libblkid returns invalid physical_sector_size
Date: Tue, 2 Apr 2024 01:57:19 -0700 [thread overview]
Message-ID: <72594c25-f142-42f0-b4cd-e2650e8044db@maxrnd.com> (raw)
In-Reply-To: <0fb74540-3878-206d-b623-15437fe79b01@t-online.de>
Hi Christian,
On 3/31/2024 1:11 AM, Christian Franke via Cygwin wrote:
> Testcase:
>
> # cygcheck -f /sbin/fdisk.exe
> util-linux-2.39.3-1
>
> # /sbin/fdisk.exe -l /dev/sdd
> Disk /dev/sdd: 465.76 GiB, 500107862016 bytes, 976773168 sectors
> Units: sectors of 1 * 512 = 512 bytes
> Sector size (logical/physical): 512 bytes / 34359738880 bytes
> I/O size (minimum/optimal): 34359738880 bytes / 34359738880 bytes
[...valuable investigation and patch suggestion elided...]
Your suggested patch looks fine to me. I have added it to the patch
deck for a new util-linux 2.39.3-2, which has just been uploaded. The
patch allows fdisk.exe to report the three correct values in my limited
testing.
Thanks for the report and the patch!
..mark
next prev parent reply other threads:[~2024-04-02 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 8:11 Christian Franke
2024-04-02 8:57 ` Mark Geisert [this message]
2024-04-02 9:27 ` Christian Franke
2024-04-02 16:50 ` Christian Franke
2024-04-03 23:15 ` Mark Geisert
2024-04-02 12:46 Bruce Jerrick
2024-04-02 16:38 ` Christian Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72594c25-f142-42f0-b4cd-e2650e8044db@maxrnd.com \
--to=mark@maxrnd.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).