Cygwin test 3.5.0 tar symlinks error messages and failure status

Cygwin test 3.5.0 tar symlinks error messages and failure status

[Brian Inglis]

Problem writing tar (with Cygwin default sys) symlinks before target created 
under Cygwin 3.5.0 - error messages are issued and tar exits with failure status!

Also failed with the same issues under my own dev build based off origin/main 
commit 2023-05-01 3bee68248fc8e164a8bb6bba3f105b10fdec8a71 Cygwin: Fix compiling 
with w32api-headers v11.0.0.

The only likely culprit between 3.4.6 and that commit seems to be commit 
2023-04-18 fa84aa4dd2fb43eaf7fcdfb040aef854f2f19d01 Cygwin: fix errno values set 
by readlinkat.

Still seems to work as expected despite the error messages and failure status.

Runs without any messages or failure under Cygwin stable 3.4.6.

Symlinks are captoinfo and infotocap -> tic, reset -> tset, ncurses6-config -> 
ncursesw6-config.

$ uname -srvmo
CYGWIN_NT-10.0-19044 3.5.0-0.303.g4840a5632520.x86_64 2023-05-24 21:41 UTC 
x86_64 Cygwin
$ tar -xvf ncurses-6.4-6.20230520.x86_64/dist/ncurses/ncurses-6.4-6.20230520.tar.xz
usr/bin/captoinfo
/bin/tar: usr/bin/captoinfo: Cannot change mode to rwxr-xr-x: Not a directory
usr/bin/clear.exe
usr/bin/infocmp.exe
usr/bin/infotocap
/bin/tar: usr/bin/infotocap: Cannot change mode to rwxr-xr-x: Not a directory
usr/bin/reset
/bin/tar: usr/bin/reset: Cannot change mode to rwxr-xr-x: Not a directory
usr/bin/tabs.exe
usr/bin/tic.exe
usr/bin/toe.exe
usr/bin/tput.exe
usr/bin/tset.exe
usr/share/doc/ncurses/
usr/share/doc/ncurses/ANNOUNCE
usr/share/doc/ncurses/AUTHORS
usr/share/doc/ncurses/COPYING
usr/share/doc/ncurses/NEWS
usr/share/doc/ncurses/README
usr/share/man/man1/captoinfo.1m.gz
usr/share/man/man1/clear.1.gz
usr/share/man/man1/infocmp.1m.gz
usr/share/man/man1/infotocap.1m.gz
usr/share/man/man1/reset.1.gz
usr/share/man/man1/tabs.1.gz
usr/share/man/man1/tic.1m.gz
usr/share/man/man1/toe.1m.gz
usr/share/man/man1/tput.1.gz
usr/share/man/man1/tset.1.gz
/bin/tar: Exiting with failure status due to previous errors
$ tar -xvf 
ncurses-6.4-6.20230520.x86_64/dist/ncurses/libncurses-devel/libncurses-devel-6.4-6.20230520.tar.xz: 
extracting...
usr/bin/ncurses6-config
/bin/tar: usr/bin/ncurses6-config: Cannot change mode to rwxr-xr-x: Not a directory

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

Re: Cygwin test 3.5.0 tar symlinks error messages and failure status

[Achim Gratz]

Brian Inglis via Cygwin writes:
> Problem writing tar (with Cygwin default sys) symlinks before target
> created under Cygwin 3.5.0 - error messages are issued and tar exits
> with failure status!
[…]
> The only likely culprit between 3.4.6 and that commit seems to be
> commit 2023-04-18 fa84aa4dd2fb43eaf7fcdfb040aef854f2f19d01 Cygwin: fix
> errno values set by readlinkat.
>
> Still seems to work as expected despite the error messages and failure status.
>
> Runs without any messages or failure under Cygwin stable 3.4.6.

The interface mentioned above is known to be wonky on various systems.
You might need to re-build tar in oder for it to detect any changed
level of wonkiness and adapt accordingly.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: Cygwin test 3.5.0 tar symlinks error messages and failure status

[David Allsopp]

Achim Gratz wrote:
> Brian Inglis writes:
> > Problem writing tar (with Cygwin default sys) symlinks before target
> > created under Cygwin 3.5.0 - error messages are issued and tar exits
> > with failure status!
> […]
> > The only likely culprit between 3.4.6 and that commit seems to be
> > commit 2023-04-18 fa84aa4dd2fb43eaf7fcdfb040aef854f2f19d01 Cygwin: fix
> > errno values set by readlinkat.
> >
> > Still seems to work as expected despite the error messages and failure status.
> >
> > Runs without any messages or failure under Cygwin stable 3.4.6.
>
> The interface mentioned above is known to be wonky on various systems.
> You might need to re-build tar in oder for it to detect any changed
> level of wonkiness and adapt accordingly.

On Cygwin 3.4.7, recompiling tar from the source package fixes this
problem; the resulting binary then seems to be fine on Cygwin 3.4.6 as
well.

Please could tar 1.34 be re-packaged?

All best,


David

Cygwin test 3.5.0 tar symlinks error messages and failure status

[Daniel Abrahamsson]

("Manually" replying to an email in the archive (https://cygwin.com/pipermail/cygwin/2023-May/253742.html) since I don't have the original email anymore).

Achim Gratz wrote:
> Brian Inglis via Cygwin writes:
> > Problem writing tar (with Cygwin default sys) symlinks before target
> > created under Cygwin 3.5.0 - error messages are issued and tar exits
> > with failure status!
> […]
> > The only likely culprit between 3.4.6 and that commit seems to be
> > commit 2023-04-18 fa84aa4dd2fb43eaf7fcdfb040aef854f2f19d01 Cygwin: fix
> > errno values set by readlinkat.
> >
> > Still seems to work as expected despite the error messages and failure status.
> >
> > Runs without any messages or failure under Cygwin stable 3.4.6.

We started seeing the same problem after cygwin 3.4.7 was released (I note it includes the commit Brian mentions). As a workaround, we just ignore the exit code of the tar command, but understandably we would rather not do that. Extracting the same archive works fine without warnings or errors on Linux.

> The interface mentioned above is known to be wonky on various systems.
> You might need to re-build tar in oder for it to detect any changed
> level of wonkiness and adapt accordingly.

Do you mean that the tar package would need an update?

// Daniel