From: Jon Turney <jon.turney@dronecode.org.uk>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: lulatex problems after update of zlib
Date: Tue, 22 Aug 2023 22:14:46 +0100 [thread overview]
Message-ID: <8e307403-508d-ff16-f1ae-d2cb79c285eb@dronecode.org.uk> (raw)
In-Reply-To: <875y57yq20.fsf@Rainer.invalid>
On 22/08/2023 17:55, ASSI via Cygwin wrote:
> Ken Brown via Cygwin writes:
>> On 8/21/2023 11:02 AM, ASSI via Cygwin wrote:
>>> (although in this case maybe i got spooked by the change
>>> from 1.2.x to 1.3)
>>
>> It looks like that's exactly what happened. The version check
>> compares the first 4 characters of the version string.
>
> Almost exactly the same problem happened 13 years ago or so. Instead of
> heeding the comment right in the file that only the first character of
> the version string should be examined (or else compare ZLIB_VERNUM),
> they chose to shorten the comparison from 5 to 4 characters…
I've been made aware of what seems to be a similar problem in cmake's
"find_package(ZLIB)", see:
https://gitlab.kitware.com/cmake/cmake/-/issues/25200
I think that means we need a cmake update with a fix for that...
prev parent reply other threads:[~2023-08-22 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 7:31 Per Larsson
2023-08-21 14:23 ` Ken Brown
2023-08-21 15:02 ` ASSI
2023-08-21 19:21 ` Ken Brown
2023-08-22 16:55 ` ASSI
2023-08-22 21:14 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e307403-508d-ff16-f1ae-d2cb79c285eb@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).