Update request for rdiff-backup

Update request for rdiff-backup

[qrasmfu8f4]

Cygwin currently contains version 1.2.8-6 of rdiff-backup.  Based on what I see at https://github.com/rdiff-backup/rdiff-backup/releases, 1.2.8 is about 11 years old (you'll have to click "Show 7 other tags), although it appears there were no releases for 10 years. There has, however been some recent activity, and version 2.0,0 was released on March 15th.  Would it be possible to update cygwin to version 2.0.0 of rdiff-update?

Thanks.

Re: Update request for rdiff-backup

[David Rothenberger]

On 4/28/2020 11:43 PM, qrasmfu8f4@snkmail.com wrote:
> Cygwin currently contains version 1.2.8-6 of rdiff-backup.  Based on what I see at https://github.com/rdiff-backup/rdiff-backup/releases, 1.2.8 is about 11 years old (you'll have to click "Show 7 other tags), although it appears there were no releases for 10 years. There has, however been some recent activity, and version 2.0,0 was released on March 15th.  Would it be possible to update cygwin to version 2.0.0 of rdiff-update?

I have updated rdiff-backup to 2.0.0 and pushed the new package as a 
TEST release (since I don't use rdiff-backup anymore). Please test and 
report back if you find any problems. I'll plan to promote it to 
official status in a couple weeks unless you have problems.


-- 
David Rothenberger  ----  daveroth@acm.org

Lost: gray and white female cat.  Answers to electric can opener.

Re: Re: Update request for rdiff-backup

[Cygwin]

> On 4/28/2020 11:43 PM,qrasmfu8f4@snkmail.com  <mailto:qrasmfu8f4@snkmail.com>  wrote:
> >/Cygwin currently contains version 1.2.8-6 of rdiff-backup. Based on 
> what I see at https://github.com/rdiff-backup/rdiff-backup/releases, 
> 1.2.8 is about 11 years old (you'll have to click "Show 7 other tags), 
> although it appears there were no releases for 10 years. There has, 
> however been some recent activity, and version 2.0,0 was released on 
> March 15th. Would it be possible to update cygwin to version 2.0.0 of 
> rdiff-update? /
> I have updated rdiff-backup to 2.0.0 and pushed the new package as a
> TEST release (since I don't use rdiff-backup anymore). Please test and
> report back if you find any problems. I'll plan to promote it to
> official status in a couple weeks unless you have problems.
>
>
> -- 
> David Rothenberger  ----daveroth@acm.org  <mailto:daveroth@acm.org>

Thanks for doing the update David.  I upgraded to rdiff-backup-2.0.0-1 
and found that running "rdiff-backup --help" produced

    Exception 'name 'local' is not defined' raised of class '<class
    'NameError'>':
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 391, in error_check_Main
         Main(arglist)
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 406, in Main
         local.setlocale(locale.LC_ALL, '')

    Traceback (most recent call last):
       File "/usr/bin/rdiff-backup", line 32, in <module>
         rdiff_backup.Main.error_check_Main(sys.argv[1:])
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 391, in error_check_Main
         Main(arglist)
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 406, in Main
         local.setlocale(locale.LC_ALL, '')
    NameError: name 'local' is not defined

Attempting a real use of rdiff-backup gave a similar result. Looking at 
the rdiff-backup source in github as well as the python 3.6 docs, it 
looks you added line 406 in Main.py and I think it has a typo.  "local" 
should be "locale".

BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago, 
and while it seemed to work fine when the destination was on a local 
drive, I couldn't figure out how to get it to work when the destination 
is a network share If I specify the destination as 
'//192.168.1.250/finance-backup/finance.rdiff-backup' I get:

      Fatal Error: Unable to create directory
    /192.168.1.250/finance-backup/finance.rdiff-backup

but "mkdir //192.168.1.250/finance-backup/finance.rdiff-backup" works fine.

If I specify the destination as 
'\\192.168.1.250\finance-backup\finance.rdiff-backup' I get:

    Exception '' raised of class '<type 'exceptions.AssertionError'>':
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 305, in error_check_Main
         try: Main(arglist)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 326, in Main
         take_action(rps)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 281, in take_action
         elif action == "backup": Backup(rps[0], rps[1])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 336, in Backup
         rpout.conn.fs_abilities.backup_set_globals(rpin, force)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 922, in backup_set_globals
         dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 167, in init_readwrite
         self.set_symlink_perms(subdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 547, in set_symlink_perms
         sym_dest.symlink("symlinked_file1")
       File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
    line 1004, in symlink
         assert self.issym()

    Traceback (most recent call last):
       File "/usr/bin/rdiff-backup", line 30, in <module>
         rdiff_backup.Main.error_check_Main(sys.argv[1:])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 305, in error_check_Main
         try: Main(arglist)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 326, in Main
         take_action(rps)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 281, in take_action
         elif action == "backup": Backup(rps[0], rps[1])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 336, in Backup
         rpout.conn.fs_abilities.backup_set_globals(rpin, force)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 922, in backup_set_globals
         dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 167, in init_readwrite
         self.set_symlink_perms(subdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 547, in set_symlink_perms
         sym_dest.symlink("symlinked_file1")
       File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
    line 1004, in symlink
         assert self.issym()
    AssertionError

Would you have any suggestions about how to put the output on a network 
share?

Also, if you don't use rdiff-backup any more, have you found something 
you like better?

Re: Update request for rdiff-backup

[Andrey Repin]

Greetings, Cygwin!

> BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago,
> and while it seemed to work fine when the destination was on a local 
> drive, I couldn't figure out how to get it to work when the destination 
> is a network share If I specify the destination as 
> '//192.168.1.250/finance-backup/finance.rdiff-backup' I get:

>       Fatal Error: Unable to create directory
>     /192.168.1.250/finance-backup/finance.rdiff-backup

Note the single leading slash.
Most likely, the program performs manual "normalization" of the path, which is
not POSIX-compatible.
POSIX explicitly declare that double leading slash is a special case, and its
behavior is defined by the underlying system.
If 2.0 would exhibit the same behavior, it is worth reporting upstream.

> but "mkdir //192.168.1.250/finance-backup/finance.rdiff-backup" works fine.

Indeed.

> If I specify the destination as 
> '\\192.168.1.250\finance-backup\finance.rdiff-backup' I get:

Try doubling the backslashes.

>     Exception '' raised of class '<type 'exceptions.AssertionError'>':
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 305, in error_check_Main
>          try: Main(arglist)
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 326, in Main
>          take_action(rps)
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 281, in take_action
>          elif action == "backup": Backup(rps[0], rps[1])
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 336, in Backup
>          rpout.conn.fs_abilities.backup_set_globals(rpin, force)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 922, in backup_set_globals
>          dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 167, in init_readwrite
>          self.set_symlink_perms(subdir)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 547, in set_symlink_perms
>          sym_dest.symlink("symlinked_file1")
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
>     line 1004, in symlink
>          assert self.issym()

>     Traceback (most recent call last):
>        File "/usr/bin/rdiff-backup", line 30, in <module>
>          rdiff_backup.Main.error_check_Main(sys.argv[1:])
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 305, in error_check_Main
>          try: Main(arglist)
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 326, in Main
>          take_action(rps)
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 281, in take_action
>          elif action == "backup": Backup(rps[0], rps[1])
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
>     line 336, in Backup
>          rpout.conn.fs_abilities.backup_set_globals(rpin, force)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 922, in backup_set_globals
>          dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 167, in init_readwrite
>          self.set_symlink_perms(subdir)
>        File
>     "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
>     line 547, in set_symlink_perms
>          sym_dest.symlink("symlinked_file1")
>        File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
>     line 1004, in symlink
>          assert self.issym()
>     AssertionError

> Would you have any suggestions about how to put the output on a network 
> share?

> Also, if you don't use rdiff-backup any more, have you found something 
> you like better?

> --
> Problem reports:      https://cygwin.com/problems.html
> FAQ:                  https://cygwin.com/faq/
> Documentation:        https://cygwin.com/docs.html
> Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple


-- 
With best regards,
Andrey Repin
Tuesday, May 5, 2020 12:17:35

Sorry for my terrible english...

Re: Update request for rdiff-backup

[Brian Inglis]

On 2020-05-04 22:17, Cygwin wrote:
>> On 4/28/2020 11:43 PM,qrasmfu8f4@snkmail.com  <mailto:qrasmfu8f4@snkmail.com> 
>> wrote:
>> >/Cygwin currently contains version 1.2.8-6 of rdiff-backup. Based on what I
>> see at https://github.com/rdiff-backup/rdiff-backup/releases, 1.2.8 is about
>> 11 years old (you'll have to click "Show 7 other tags), although it appears
>> there were no releases for 10 years. There has, however been some recent
>> activity, and version 2.0,0 was released on March 15th. Would it be possible
>> to update cygwin to version 2.0.0 of rdiff-update? /
>> I have updated rdiff-backup to 2.0.0 and pushed the new package as a
>> TEST release (since I don't use rdiff-backup anymore). Please test and
>> report back if you find any problems. I'll plan to promote it to
>> official status in a couple weeks unless you have problems.
>>
>>
>> -- 
>> David Rothenberger  ----daveroth@acm.org  <mailto:daveroth@acm.org>
> 
> Thanks for doing the update David.  I upgraded to rdiff-backup-2.0.0-1 and found
> that running "rdiff-backup --help" produced
> 
>    Exception 'name 'local' is not defined' raised of class '<class
>    'NameError'>':
>       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>    line 391, in error_check_Main
>         Main(arglist)
>       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>    line 406, in Main
>         local.setlocale(locale.LC_ALL, '')
> 
>    Traceback (most recent call last):
>       File "/usr/bin/rdiff-backup", line 32, in <module>
>         rdiff_backup.Main.error_check_Main(sys.argv[1:])
>       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>    line 391, in error_check_Main
>         Main(arglist)
>       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>    line 406, in Main
>         local.setlocale(locale.LC_ALL, '')
>    NameError: name 'local' is not defined
> 
> Attempting a real use of rdiff-backup gave a similar result. Looking at the
> rdiff-backup source in github as well as the python 3.6 docs, it looks you added
> line 406 in Main.py and I think it has a typo.  "local" should be "locale".
> 
> BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago, and while
> it seemed to work fine when the destination was on a local drive, I couldn't
> figure out how to get it to work when the destination is a network share If I
> specify the destination as '//192.168.1.250/finance-backup/finance.rdiff-backup'
> I get:
> 
>      Fatal Error: Unable to create directory
>    /192.168.1.250/finance-backup/finance.rdiff-backup
> 
> but "mkdir //192.168.1.250/finance-backup/finance.rdiff-backup" works fine.
> 
> If I specify the destination as
> '\\192.168.1.250\finance-backup\finance.rdiff-backup' I get:

> Would you have any suggestions about how to put the output on a network share?

The ssh, rsync, and most Unix remote access utilities use [[user@]host:]path;
and rsync daemon processes and rdiff-backup use [[user]@host::]path specs or
URIs; see:

	http://rdiff-backup.nongnu.org/rdiff-backup.1.html

	https://rdiff-backup.net/docs/examples.html

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.

Re: Update request for rdiff-backup

[David Rothenberger]

On 5/4/2020 9:17 PM, Cygwin wrote:
> Thanks for doing the update David.  I upgraded to rdiff-backup-2.0.0-1 
> and found that running "rdiff-backup --help" produced
> 
>     Exception 'name 'local' is not defined' raised of class '<class
>     'NameError'>':
>        File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>     line 391, in error_check_Main
>          Main(arglist)
>        File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>     line 406, in Main
>          local.setlocale(locale.LC_ALL, '')
> 
>     Traceback (most recent call last):
>        File "/usr/bin/rdiff-backup", line 32, in <module>
>          rdiff_backup.Main.error_check_Main(sys.argv[1:])
>        File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>     line 391, in error_check_Main
>          Main(arglist)
>        File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
>     line 406, in Main
>          local.setlocale(locale.LC_ALL, '')
>     NameError: name 'local' is not defined

I've fixed this and uploaded 2.0.0-2 with the fix. Please test.

> BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago, 
> and while it seemed to work fine when the destination was on a local 
> drive, I couldn't figure out how to get it to work when the destination 
> is a network share If I specify the destination as 
> '//192.168.1.250/finance-backup/finance.rdiff-backup' I get:
> 
>       Fatal Error: Unable to create directory
>     /192.168.1.250/finance-backup/finance.rdiff-backup
> 
> but "mkdir //192.168.1.250/finance-backup/finance.rdiff-backup" works fine.

I'm don't have time to investigate this. If you think it's a bug and 
have a patch you'd like me to include in the package, please let me know.

> Would you have any suggestions about how to put the output on a network 
> share?

You could try mounting the network share to a local patch using /etc/fstab.

> Also, if you don't use rdiff-backup any more, have you found something 
> you like better?

I don't remember why I stopped using it. It was a long time ago. I think 
I just use rsync now.

-- 
David Rothenberger  ----  daveroth@acm.org

disbar, n:
         As distinguished from some other bar.

Re: Re: Update request for rdiff-backup

[Cygwin]

> The ssh, rsync, and most Unix remote access utilities use [[user@]host:]path;
> and rsync daemon processes and rdiff-backup use [[user]@host::]path specs or
> URIs; see:
>
> 	http://rdiff-backup.nongnu.org/rdiff-backup.1.html
>
> 	https://rdiff-backup.net/docs/examples.html
>
> -- 
> Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

Thanks for the suggestion Brian.

I would prefer to use[[user]@host::]path , but based on my reading of 
the man page and examples, it requires rdiff-backup to be available on 
the remote server which unfortunately is not the case in my situation.

I don't see anything in the rdiff-backup man page or examples indicating 
you can use URIs.  Can you be more specific about where it shows that?

Re: Update request for rdiff-backup

[Brian Inglis]

On 2020-05-05 23:23, Cygwin wrote:
>> The ssh, rsync, and most Unix remote access utilities use [[user@]host:]path;
>> and rsync daemon processes and rdiff-backup use [[user]@host::]path specs or
>> URIs; see:
>>
>>     http://rdiff-backup.nongnu.org/rdiff-backup.1.html
>>
>>     https://rdiff-backup.net/docs/examples.html

> Thanks for the suggestion Brian.
> 
> I would prefer to use[[user]@host::]path , but based on my reading of the man
> page and examples, it requires rdiff-backup to be available on the remote server
> which unfortunately is not the case in my situation.

It is impossible to use any rsync, rdiff, or rdiff-backup commands against a
remote server without the corresponding daemon running on that server, as the
commands omit sending as many data blocks as possible by sending block
signatures instead, then on signature mismatch sending the data black and
storing it in the new file copy, an incremental diff, and/or a date-time stamped
backup.

> I don't see anything in the rdiff-backup man page or examples indicating you can
> use URIs.  Can you be more specific about where it shows that?

I would expect it to support specs in the form of rsync URIs, not general URI
schemes as supported by curl or duplicity e.g.

rsync(1):
"	Access via rsync daemon:
         Pull: rsync [OPTION...] [USER@]HOST::SRC... [DEST]
               rsync [OPTION...] rsync://[USER@]HOST[:PORT]/SRC... [DEST]
         Push: rsync [OPTION...] SRC... [USER@]HOST::DEST
               rsync [OPTION...] SRC... rsync://[USER@]HOST[:PORT]/DEST

       Usages with just one SRC arg and no DEST arg will list the source files
instead of copying."

similar to ssh(1):
	"or a URI of the form ssh://[user@]hostname[:port]"

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in IEC units and prefixes, physical quantities in SI.]

Re: Re: Update request for rdiff-backup

[Cygwin]

> >/BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago, />/and while it seemed to work fine when the destination was on a local />/drive, I couldn't figure out how to get it to work when the destination />/is a network share If I specify the destination as />/'//192.168.1.250/finance-backup/finance.rdiff-backup' I get: /
> >/ Fatal Error: Unable to create directory />//192.168.1.250/finance-backup/finance.rdiff-backup /
> Note the single leading slash.
> Most likely, the program performs manual "normalization" of the path, which is
> not POSIX-compatible.
> POSIX explicitly declare that double leading slash is a special case, and its
> behavior is defined by the underlying system.
> If 2.0 would exhibit the same behavior, it is worth reporting upstream.

Based on my limited testing, 2.0.0-2 works fine with local directories.  
As far as i can tell it works at least as well as version 1.2.8-6.

2.0.0-2 does exhibit the same behavior for network shares.  I 
discovered, however, that there is a "native" windows version of 
rdiff-backup 
(https://github.com/rdiff-backup/rdiff-backup/releases/tag/v2.0.0), so I 
downloaded, installed, tried it.  It also exhibits the same behavior for 
network shares, so the issue is clearly not introduced by the cygwin port.

I created an issue upstream 
(https://github.com/rdiff-backup/rdiff-backup/issues/353).

Thanks to everyone for your assistance.

Re: Update request for rdiff-backup

[David Rothenberger]

On 5/7/2020 11:15 PM, Cygwin wrote:
> Based on my limited testing, 2.0.0-2 works fine with local directories. 
> As far as i can tell it works at least as well as version 1.2.8-6.

Thanks for testing. I'll promote 2.0.0-2.

> 2.0.0-2 does exhibit the same behavior for network shares.  I 
> discovered, however, that there is a "native" windows version of 
> rdiff-backup 
> (https://github.com/rdiff-backup/rdiff-backup/releases/tag/v2.0.0), so I 
> downloaded, installed, tried it.  It also exhibits the same behavior for 
> network shares, so the issue is clearly not introduced by the cygwin port.
> 
> I created an issue upstream 
> (https://github.com/rdiff-backup/rdiff-backup/issues/353).

Thanks for that, too.

-- 
David Rothenberger  ----  daveroth@acm.org