From: Houder <houder@xs4all.nl>
To: cygwin@cygwin.com
Subject: Re: [ANNOUNCEMENT] TEST RELEASE: Cygwin 2.11.0-0.1
Date: Mon, 13 Aug 2018 22:26:00 -0000 [thread overview]
Message-ID: <9a902fe9715b173671599a2e32eca26d@xs4all.nl> (raw)
In-Reply-To: <f9b36ce5-9027-b7a5-fd06-baa951f6812e@redhat.com>
On 2018-08-14 00:16, Eric Blake wrote:
> On 08/13/2018 04:29 PM, Houder wrote:
>
>>> The modication would require changing:
>>>
>>> winsup/cygwin/fenv.cc (_feinitialise() )
>>> winsup/cygwin/include/fenv.h (FE_ALL_EXCEPT)
>>
>> GRRR! The file encoding of fenv.h is "cp1252" because of 2 characters
>> in this
>> line:
>>
>>     Intel® 64 and IA-32 Architectures Software Developerâs Manuals:
>>
>> ... part of a comment at the beginning of the file.
>>
>> (the registered trademark sign (u00ae) is encoded as 0xae (cp1252),
>> while it
>> Â would be: 0xc2 0xae, in utf-8,
>> Â the right single quotation mark (u2019) is encoded as 0x92 (cp1252),
>> but in
>> Â utf-8 it would be: 0xc2 0x80 0x98)
>>
>> I intend to convert the file encoding of fenv.h to utf-8. Is that a
>> "No-No"
>> or is it allowed? (I assume GIT will notice).
>
> In general, git doesn't care if you change a file's encoding - that's
> just another content change. In practice, you may get weird effects
> when viewing that particular patch (as the patch is not well-formed in
> the new multibyte locale, and looks funky when displayed in the old
> locale), and emailing a patch may require care in telling git which
> encoding to use for the email; but that's cosmetic, and shouldn't
> matter in the long run. Updating the code base to uniformly use UTF-8
> seems reasonable to me.
... and emailing a patch may require care in telling git which encoding
to use for the email ... Huh, huh ?????
Last time I used:
- git format-patch
- git send-mail
Am I safe here?
Regards,
Henri
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2018-08-13 22:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 20:27 Corinna Vinschen
2018-08-10 0:05 ` Andrey Repin
2018-08-10 11:05 ` Houder
2018-08-10 11:43 ` Corinna Vinschen
2018-08-10 12:43 ` Houder
2018-08-13 7:47 ` Corinna Vinschen
2018-08-13 8:03 ` Houder
2018-08-13 8:23 ` Corinna Vinschen
2018-08-13 21:29 ` Houder
2018-08-13 22:16 ` Houder
2018-08-13 22:16 ` Eric Blake
2018-08-13 22:26 ` Houder [this message]
2018-08-14 6:09 ` john doe
2018-08-14 9:50 ` Corinna Vinschen
2018-08-14 11:38 ` Houder
2018-08-13 20:27 ` Achim Gratz
2018-08-10 16:01 ` Marco Atzeri
2018-08-13 7:48 ` Corinna Vinschen
2018-08-13 8:36 ` Thomas Wolff
2018-08-13 11:25 ` Corinna Vinschen
2018-08-16 21:33 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a902fe9715b173671599a2e32eca26d@xs4all.nl \
--to=houder@xs4all.nl \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).