From: Ismail Donmez <ismail@i10z.com>
To: cygwin@cygwin.com
Subject: Re: Problem with new acl code and cdrtools
Date: Mon, 08 Feb 2016 13:31:00 -0000 [thread overview]
Message-ID: <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg@mail.gmail.com> (raw)
In-Reply-To: <20160208131835.GC12975@calimero.vinschen.de>
On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
<corinna-cygwin@cygwin.com> wrote:
> On Feb 8 12:01, Ismail Donmez wrote:
>> Hi,
>>
>> cdrtools has some code to detect Solaris style ACLs:
>>
>> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
>> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
>> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */
>> #endif
>>
>> Since cygwin still seems to be defining aclfromtext() and acltotext()
>> functions (which are not defined in POSIX) cdrtools thinks this a
>> Solaris-style system and get up getting a compile error later on.
>
> Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h
> help? Or changing the above check to prefer POSIX ACLs over Solaris
> ACLs?
This is a generic code so I don't want to add a cygwin specific
dependency there. Is there a preprocessor definition for cygwin
version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>
>> Since we are switching to POSIX ACLs it would be nice to remove
>> Solaris-only ACL functions.
>
> We can't do that for backward compatibility. The Solaris function
> have to stay available, not the least for Cygwin's getfacl/setfacl
> which still use them.
I see, thanks.
ismail
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
next prev parent reply other threads:[~2016-02-08 13:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 10:02 Ismail Donmez
2016-02-08 13:18 ` Corinna Vinschen
2016-02-08 13:31 ` Ismail Donmez [this message]
2016-02-08 14:10 ` Corinna Vinschen
2016-02-08 14:14 ` Ismail Donmez
2016-02-08 14:36 ` Corinna Vinschen
2016-02-08 16:10 ` Ismail Donmez
2016-02-08 19:24 ` Yaakov Selkowitz
2016-02-09 9:36 ` Corinna Vinschen
2016-02-08 16:29 ` Peter Rosin
2016-02-08 17:00 ` Ismail Donmez
2016-02-09 4:14 ` Warren Young
2016-02-09 7:57 ` Ismail Donmez
2016-02-09 8:46 ` Warren Young
2016-02-09 8:50 ` Ismail Donmez
2016-02-09 8:57 ` Peter Rosin
2016-02-09 9:06 ` Ismail Donmez
2016-02-09 10:13 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg@mail.gmail.com' \
--to=ismail@i10z.com \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).