compilation errors trying to build unzip on cygwin

compilation errors trying to build unzip on cygwin

[Soren]

HI. HI!. I've been away from cygwin (and all computer programming
/messing-about) fro several years. Still love Cygwin.

I've gotan archive with the source for `unzip' and I am having trouble
compiling that program. The is the output on the console:

$ make
gcc -c -DASM_CRC -DWIN32 -D__GW32__ -D_LARGEFILE_SOURCE=1
-D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -Wall -O3 -fms-extensions
-mms-bitfi
elds  -fno-exceptions -fomit-frame-pointer -march=i386 -mcpu=i686
-idirafter e:/progra~1/gnuwin32/include -idirafter h:/glibc/include -DUNIXB
ACKUP -DUSE_UNSHRINK -DACORN_FTYPE_NFS -DOS2_EAS -DUSE_CRYPT  -Wall  -o
unzip.o  -O3 -mtune=native -march=native  unzip.c
In file included from win32/w32cfg.h:42,
                 from unzpriv.h:667,
                 from unzip.h:637,
                 from unzip.c:64:
win32/w32cfg.h:91:15: error: expected declaration specifiers or ‘...’
before ‘(’ token
   91 |    extern int setmode(int, int);        /* this is missing in
<fcntl.h> */
      |               ^~~~~~~
win32/w32cfg.h:91:15: error: expected declaration specifiers or ‘...’
before ‘(’ token
   91 |    extern int setmode(int, int);        /* this is missing in
<fcntl.h> */
      |               ^~~~~~~
In file included from unzip.h:637,
                 from unzip.c:64:
unzip.c: In function ‘unzip’:
unzpriv.h:787:22: warning: implicit declaration of function ‘strnicmp’; did
you mean ‘strncmp’? [-Wimplicit-function-declaration]
  787 | #    define STRNICMP strnicmp
      |                      ^~~~~~~~
unzip.c:832:9: note: in expansion of macro ‘STRNICMP’
  832 |     if (STRNICMP(p, LoadFarStringSmall(Zipnfo), 7) == 0 ||
      |         ^~~~~~~~
make: *** [unzip.o] Error 1

The release version of `unzip' is 5.51

Anyone got any ideas? TIA.
-- 
Soren 'tino

He's earthy, he's pithy, he's ...a bit astringent.
Think of him more as a "topical antiseptic" than as a snack
.
    somian08@gmail.com  https://instagram.com/samhain08/
   https://twitter.com/1oh1soren

Re: compilation errors trying to build unzip on cygwin

[Ken Brown]

On 2/13/2021 7:01 PM, Soren via Cygwin wrote:
> HI. HI!. I've been away from cygwin (and all computer programming
> /messing-about) fro several years. Still love Cygwin.
> 
> I've gotan archive with the source for `unzip' and I am having trouble
> compiling that program. The is the output on the console:
> 
> $ make
> gcc -c -DASM_CRC -DWIN32 -D__GW32__ -D_LARGEFILE_SOURCE=1
> -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -Wall -O3 -fms-extensions
> -mms-bitfi
> elds  -fno-exceptions -fomit-frame-pointer -march=i386 -mcpu=i686
> -idirafter e:/progra~1/gnuwin32/include -idirafter h:/glibc/include -DUNIXB
> ACKUP -DUSE_UNSHRINK -DACORN_FTYPE_NFS -DOS2_EAS -DUSE_CRYPT  -Wall  -o
> unzip.o  -O3 -mtune=native -march=native  unzip.c

You need to tell make to use the unix Makefile.  See the unzip.cygport file in 
the source for Cygwin's unzip package.  You can get it from

   https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/unzip.git

or by using Cygwin's setup program to download the source.

Ken

RE: compilation errors trying to build unzip on cygwin

[Soren]

Hi, again. I sent a request for help with this build. Then I put on my
thinking cap and snatched in the cygwin src for this pkg, which is new
(6.0). Yet I still cannot build. Thus, here is the output on my console:
But first, weirdly we are finding a different make:
$  which make
/usr/bin/make
 ((alright))
$ make -f unix/Makefile cygwin
C:/ix/gnuwin32/bin/make unzips CC=gcc LD=gcc AS=gcc\
         CFLAGS="-O3 -DASM_CRC -DNO_LCHOWN -DNO_LCHMOD"\
         AF="-Di386  " CRCA_O=crc_gcc.o\
         E=".exe" CP="cp" LN="ln -s"
C:\ix\gnuwin32\bin\make: invalid option -- A
C:\ix\gnuwin32\bin\make: invalid option -- M
C:\ix\gnuwin32\bin\make: invalid option -- _
C:\ix\gnuwin32\bin\make: invalid option -- N
C:\ix\gnuwin32\bin\make: invalid option -- O
C:\ix\gnuwin32\bin\make: invalid option -- _
C:\ix\gnuwin32\bin\make: invalid option -- N
C:\ix\gnuwin32\bin\make: invalid option -- O
C:\ix\gnuwin32\bin\make: invalid option -- _
Usage: make [options] [target] ...
Options:
 ...

My PATH before cygwin manages it looks like:
[1] C:\windows\system32
[2] C:\windows
[3] C:\windows\System32\Wbem
[4] C:\windows\System32\WindowsPowerShell\v1.0\
[5] C:\windows\System32\OpenSSH\
[6] C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
[7] C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR
[8] C:\ix\putty\
[9] C:\perl\c\bin
[10] C:\perl\perl\site\bin
[11] C:\perl\perl\bin
[12] C:\ix\gnuwin32\bin
[13] C:\Users\somia\AppData\Local\Microsoft\WindowsApps
[14] C:\ix\mingw\bin
[15] C:\Perl\bin

After diving into Cygwin-dom:
PATH=/usr/local/bin:/usr/bin:/cygdrive/c/windows/system32:/cygdrive/c/windows:/cygdrive/c/windows/System32/Wbem
:/cygdrive/c/windows/System32/WindowsPowerShell/v1.0:/cygdrive/c/windows/System32/OpenSSH:/cygdrive/c/Program
F
iles (x86)/NVIDIA Corporation/PhysX/Common:/cygdrive/c/Program Files/NVIDIA
Corporation/NVIDIA NvDLISR:/cygdriv
e/c/ix/putty:/cygdrive/c/perl/c/bin:/cygdrive/c/perl/perl/site/bin:/cygdrive/c/perl/perl/bin:/cygdrive/c/ix/gnu
win32/bin:/cygdrive/c/Users/somia/AppData/Local/Microsoft/WindowsApps:/cygdrive/c/ix/mingw/bin:/cygdrive/c/Perl
/bin

Hmmm, right? Why would make spawn submakes that don't come earlier in PATH?

Re: compilation errors trying to build unzip on cygwin

[Marco Atzeri]

On 14.02.2021 03:34, Soren via Cygwin wrote:
> Hi, again. I sent a request for help with this build. Then I put on my
> thinking cap and snatched in the cygwin src for this pkg, which is new
> (6.0). Yet I still cannot build. Thus, here is the output on my console:
> But first, weirdly we are finding a different make:
> $  which make
> /usr/bin/make
>   ((alright))
> $ make -f unix/Makefile cygwin
> C:/ix/gnuwin32/bin/make unzips CC=gcc LD=gcc AS=gcc\
>           CFLAGS="-O3 -DASM_CRC -DNO_LCHOWN -DNO_LCHMOD"\
>           AF="-Di386  " CRCA_O=crc_gcc.o\
>           E=".exe" CP="cp" LN="ln -s"
> C:\ix\gnuwin32\bin\make: invalid option -- A
> C:\ix\gnuwin32\bin\make: invalid option -- M
> C:\ix\gnuwin32\bin\make: invalid option -- _
> C:\ix\gnuwin32\bin\make: invalid option -- N
> C:\ix\gnuwin32\bin\make: invalid option -- O
> C:\ix\gnuwin32\bin\make: invalid option -- _
> C:\ix\gnuwin32\bin\make: invalid option -- N
> C:\ix\gnuwin32\bin\make: invalid option -- O
> C:\ix\gnuwin32\bin\make: invalid option -- _
> Usage: make [options] [target] ...
> Options:
>   ...
> 
> My PATH before cygwin manages it looks like:
> [1] C:\windows\system32
> [2] C:\windows
> [3] C:\windows\System32\Wbem
> [4] C:\windows\System32\WindowsPowerShell\v1.0\
> [5] C:\windows\System32\OpenSSH\
> [6] C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
> [7] C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR
> [8] C:\ix\putty\
> [9] C:\perl\c\bin
> [10] C:\perl\perl\site\bin
> [11] C:\perl\perl\bin
> [12] C:\ix\gnuwin32\bin
> [13] C:\Users\somia\AppData\Local\Microsoft\WindowsApps
> [14] C:\ix\mingw\bin
> [15] C:\Perl\bin
> 
> After diving into Cygwin-dom:
> PATH=/usr/local/bin:/usr/bin:/cygdrive/c/windows/system32:/cygdrive/c/windows:/cygdrive/c/windows/System32/Wbem
> :/cygdrive/c/windows/System32/WindowsPowerShell/v1.0:/cygdrive/c/windows/System32/OpenSSH:/cygdrive/c/Program
> F
> iles (x86)/NVIDIA Corporation/PhysX/Common:/cygdrive/c/Program Files/NVIDIA
> Corporation/NVIDIA NvDLISR:/cygdriv
> e/c/ix/putty:/cygdrive/c/perl/c/bin:/cygdrive/c/perl/perl/site/bin:/cygdrive/c/perl/perl/bin:/cygdrive/c/ix/gnu
> win32/bin:/cygdrive/c/Users/somia/AppData/Local/Microsoft/WindowsApps:/cygdrive/c/ix/mingw/bin:/cygdrive/c/Perl
> /bin
> 
> Hmmm, right? Why would make spawn submakes that don't come earlier in PATH?

what about a simple PATH=/usr/local/bin:/usr/bin ?

Re: compilation errors trying to build unzip on cygwin

[Marco Atzeri]

back on mailing list

On 15.02.2021 00:36, Soren wrote:
> 
> On Sat, Feb 13, 2021 at 11:20 PM Marco Atzeri wrote:
> 
> 

> Well, that would be a simple fix, although it leaves the mystery PATH 
> behavior unsolved. I'll mention that I moved gnwin32-make out of the way 
> and then got compiler (assembler) errors. Here is my console output:
> 
> $ /usr/bin/make -f unix/Makefile cygwin
> ln: failed to create hard link './Makefile': File exists
> /usr/bin/make unzips CC=gcc LD=gcc AS=gcc\
>   CFLAGS="-O3 -DASM_CRC -DNO_LCHOWN -DNO_LCHMOD"\
>   AF="-Di386  " CRCA_O=crc_gcc.o\
>   E=".exe" CP="cp" LN="ln -s"
> make[1]: Entering directory '/usr/src/unzip-6.0-17.src/unzip60'
> gcc -Di386   -x assembler-with-cpp -c -o crc_gcc.o crc_i386.S
> crc_i386.S: Assembler messages:
> crc_i386.S:203: Error: invalid instruction suffix for `push'
> crc_i386.S:204: Error: invalid instruction suffix for `push'
> crc_i386.S:205: Error: invalid instruction suffix for `push'
> crc_i386.S:206: Error: invalid instruction suffix for `push'
> crc_i386.S:207: Error: invalid instruction suffix for `push'
> crc_i386.S:208: Error: invalid instruction suffix for `push'
> crc_i386.S:292: Error: invalid instruction suffix for `pop'
> crc_i386.S:293: Error: invalid instruction suffix for `pop'
> crc_i386.S:294: Error: invalid instruction suffix for `pop'
> crc_i386.S:295: Error: invalid instruction suffix for `pop'
> crc_i386.S:296: Error: invalid instruction suffix for `pop'
> crc_i386.S:297: Error: invalid instruction suffix for `pop'
> make[1]: *** [Makefile:381: crc_gcc.o] Error 1
> make[1]: Leaving directory '/usr/src/unzip-6.0-17.src/unzip60'
> make: *** [unix/Makefile:749: cygwin] Error 2
> 
> Thanks to any persons who are following this thread.

compiling the latest source shows no issue at all
from my side with a recent 64bit Cygwin.

$ cygport unzip.cygport all
...
Stripping executables:
         usr/bin/funzip.exe
         usr/bin/unzip.exe
         usr/bin/unzipsfx.exe
Preparing debuginfo source files:
         18 files
 >>> Packaging unzip-6.0-17.x86_64
 >>> Creating binary package(s)
 >>> unzip-6.0-17.tar.xz
...
 >>> unzip requires: bash cygwin libbz2_1

have you tried to use cygport for
repeating the patching and compiling step as current build ?

Re: compilation errors trying to build unzip on cygwin

[Soren]

On Mon, Feb 15, 2021 at 11:10 AM Marco Atzeri <marco.atzeri@gmail.com>
wrote:

>
> $ cygport unzip.cygport all
> ...
> Stripping executables:
>          usr/bin/funzip.exe
>          usr/bin/unzip.exe
>          usr/bin/unzipsfx.exe
> Preparing debuginfo source files:
>          18 files
>  >>> Packaging unzip-6.0-17.x86_64
>  >>> Creating binary package(s)
>  >>> unzip-6.0-17.tar.xz
> ...
>  >>> unzip requires: bash cygwin libbz2_1
>
> have you tried to use cygport for
> repeating the patching and compiling step as current build ?
>

No. Oh! cygport! Well, I mentioned I'd been away from cygwin and all system
projects for several years. It seemed like a good idea, and so I installed
cygport and ran it, and got a clean successful build. Thank you very much
for your time, for testing the build for me, Marco. Onward and upward now.

    Best,
        Soren A.

Re: compilation errors trying to build unzip on cygwin

[Brian Inglis]

On 2021-02-13 19:34, Soren via Cygwin wrote:
> Hi, again. I sent a request for help with this build. Then I put on my
> thinking cap and snatched in the cygwin src for this pkg, which is new
> (6.0). Yet I still cannot build. Thus, here is the output on my console:
> But first, weirdly we are finding a different make:
> $  which make
> /usr/bin/make
>   ((alright))
> $ make -f unix/Makefile cygwin
> C:/ix/gnuwin32/bin/make unzips CC=gcc LD=gcc AS=gcc\
>           CFLAGS="-O3 -DASM_CRC -DNO_LCHOWN -DNO_LCHMOD"\
>           AF="-Di386  " CRCA_O=crc_gcc.o\
>           E=".exe" CP="cp" LN="ln -s"
> C:\ix\gnuwin32\bin\make: invalid option -- A
> C:\ix\gnuwin32\bin\make: invalid option -- M
> C:\ix\gnuwin32\bin\make: invalid option -- _
> C:\ix\gnuwin32\bin\make: invalid option -- N
> C:\ix\gnuwin32\bin\make: invalid option -- O
> C:\ix\gnuwin32\bin\make: invalid option -- _
> C:\ix\gnuwin32\bin\make: invalid option -- N
> C:\ix\gnuwin32\bin\make: invalid option -- O
> C:\ix\gnuwin32\bin\make: invalid option -- _
> Usage: make [options] [target] ...
> Options:
>   ...
> 
> My PATH before cygwin manages it looks like:
> [1] C:\windows\system32
> [2] C:\windows
> [3] C:\windows\System32\Wbem
> [4] C:\windows\System32\WindowsPowerShell\v1.0\
> [5] C:\windows\System32\OpenSSH\
> [6] C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
> [7] C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR
> [8] C:\ix\putty\
> [9] C:\perl\c\bin
> [10] C:\perl\perl\site\bin
> [11] C:\perl\perl\bin
> [12] C:\ix\gnuwin32\bin
> [13] C:\Users\somia\AppData\Local\Microsoft\WindowsApps
> [14] C:\ix\mingw\bin
> [15] C:\Perl\bin
> 
> After diving into Cygwin-dom:
> PATH=/usr/local/bin:/usr/bin:/cygdrive/c/windows/system32:/cygdrive/c/windows:/cygdrive/c/windows/System32/Wbem
> :/cygdrive/c/windows/System32/WindowsPowerShell/v1.0:/cygdrive/c/windows/System32/OpenSSH:/cygdrive/c/Program
> F
> iles (x86)/NVIDIA Corporation/PhysX/Common:/cygdrive/c/Program Files/NVIDIA
> Corporation/NVIDIA NvDLISR:/cygdriv
> e/c/ix/putty:/cygdrive/c/perl/c/bin:/cygdrive/c/perl/perl/site/bin:/cygdrive/c/perl/perl/bin:/cygdrive/c/ix/gnu
> win32/bin:/cygdrive/c/Users/somia/AppData/Local/Microsoft/WindowsApps:/cygdrive/c/ix/mingw/bin:/cygdrive/c/Perl
> /bin
> 
> Hmmm, right? Why would make spawn submakes that don't come earlier in PATH?

Install cygport, libbz2-devel, and any other unzip build dependencies, then in 
the source unzip.cygport directory, run:

	$ cygport unzip.cygport download all check

and you should have a successful build in five minutes or less.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]

Re: compilation errors trying to build unzip on cygwin

[Soren]

Hi!
Brian wrote:

Install cygport, libbz2-devel, and any other unzip build dependencies, then in

the source unzip.cygport directory, run:

	$ cygport unzip.cygport download all check

and you should have a successful build in five minutes or less.

Thanks very much. It all went as you described.

Soren A