ilogbl(NaN) is wrong

ilogbl(NaN) is wrong

[Bruno Haible]

POSIX [1] specifies that the return value of the functions ilogbf(), ilogb(),
ilogbl() for a NaN argument should all be the same, namely FP_ILOGBNAN.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/ilogb.html

In Cygwin 3.4.6, the value of ilogbl(NaN) is not right.

How to reproduce:
============================== foo.c ==============================
#include <math.h>
#include <float.h>
#include <limits.h>
#include <stdio.h>
#include <stdlib.h>

int
main (void)
{
  volatile double x1;
  volatile long double x2;
  int y1;
  int y2;

  x1 = 0.0 / 0.0;
  y1 = ilogb (x1);

  x2 = 0.0L / 0.0L;
  y2 = ilogbl (x2);

  printf ("%d %d %d\n", y1, y2, FP_ILOGBNAN);

  if (!(y1 == FP_ILOGBNAN))
    abort ();

  /* This test fails in Cygwin 3.4.6.  */
  if (!(y2 == FP_ILOGBNAN))
    abort ();

  if (!(FP_ILOGBNAN == INT_MAX || FP_ILOGBNAN == INT_MIN))
    abort ();
}
===================================================================
$ gcc -Wall foo.c
$ ./a.exe

Expected output:
2147483647 2147483647 2147483647

Actual output:
2147483647 -2147483648 2147483647
Aborted (core dumped)

Bruno

PS: This is about the same function, but not the argument value, as in
https://cygwin.com/pipermail/cygwin/2019-December/243205.html

Re: ilogbl(NaN) is wrong

[Corinna Vinschen]

On Apr 18 13:21, Bruno Haible via Cygwin wrote:
> POSIX [1] specifies that the return value of the functions ilogbf(), ilogb(),
> ilogbl() for a NaN argument should all be the same, namely FP_ILOGBNAN.
> 
> [1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/ilogb.html
> 
> In Cygwin 3.4.6, the value of ilogbl(NaN) is not right.

Thanks, I pushed a patch.

A test release cygwin-3.5.0-0.283.gfa84aa4dd2fb containing this patch
is building right now.  You can install it via setup as soon as it's
available (roughly in an hour).


Thanks again,
Corinna