From: Jon Turney <jon.turney@dronecode.org.uk>
To: The Cygwin Mailing List <cygwin@cygwin.com>
Subject: Re: Cygwin package search and cygcheck -p urlencoding still broken on new web server
Date: Thu, 16 Jul 2020 14:42:44 +0100 [thread overview]
Message-ID: <acc98a4e-68e5-d70e-6271-50c6f0dfb364@dronecode.org.uk> (raw)
In-Reply-To: <f6e7d3b9-eef8-5991-59f8-905db3a8fc53@gmail.com>
On 16/07/2020 08:44, Marco Atzeri via Cygwin wrote:
> On 16.07.2020 06:25, Brian Inglis wrote:
>> On 2020-07-15 14:13, Marco Atzeri via Cygwin wrote:
>>> Problem: I want to search for
>>> libssh/libssh.h
>>> Using https://cygwin.com/packages/
>>> If I put the name and press Go the URL is changed in
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh%2Flibssh.h&arch=x86_64
>>>
>>> and the output is
>>> Found 0 matches for libsshx2Flibssh.h
>>> ^^^
>>> Instead if I modify directly the URL in:
>>> https://cygwin.com/cgi-bin2/package-grep.cgi?grep=libssh/libssh.h&arch=x86_64
I think that this is an invalid URL, that just happens to work, so it's
correct that the link we produce is urlencoded.
(See e.g. https://en.wikipedia.org/wiki/Query_string#URL_encoding)
>>> Found 3 matches for libssh/libssh.h
>>> ....
>>> I guess that the current incapability is due to spurious urlencode in
>>> cgi-bin2/package-grep.cgi
>>> that is modifing the $param_grep
>>> echo '<li><a href="package-cat.cgi?file='`urlencode
>>> $partfile`'&grep='`urlencode $param_grep`'">'$file'</a> -
>>> '$desc'</li>'
>>> Could someone double check my guess ?
So it seems the urlencode is correct, but the urldecode isn't working.
I've applied a one-character change which appears to fix things.
> the git logs says that only Frank and Jon have recently worked on
>
> cgi-bin2/package-grep.cgi
>
> I would like to double check any possible modification before proposing a
> patch to change the web server...
This was actually fairly easy to reproduce locally, once I realized what
was going on:
$ export url="libssh%2Flibssh.h" ; printf '%b' "${url//%/\x}"
libsshx2Flibssh.h
$ export url="libssh%2Flibssh.h" ; printf '%b' "${ur//%/\\x}"
libssh/libssh.h
next prev parent reply other threads:[~2020-07-16 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 20:13 Broken search on webserver Marco Atzeri
2020-07-16 4:25 ` Cygwin package search and cygcheck -p urlencoding still broken on new web server Brian Inglis
2020-07-16 7:44 ` Marco Atzeri
2020-07-16 13:42 ` Jon Turney [this message]
2020-07-16 18:48 ` Marco Atzeri
2020-07-16 20:22 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc98a4e-68e5-d70e-6271-50c6f0dfb364@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).