From: Brian Inglis <Brian.Inglis@Shaw.ca>
To: Corinna Vinschen via Cygwin <cygwin@cygwin.com>,
Bruno Haible <bruno@clisp.org>
Subject: Re: fnmatch improvements
Date: Thu, 27 Jul 2023 14:25:29 -0600 [thread overview]
Message-ID: <b653bf78-fc57-d984-e0d4-dad7db26c072@Shaw.ca> (raw)
In-Reply-To: <ZMLADRFGUuvEnCT+@calimero.vinschen.de>
On 2023-07-27 13:05, Corinna Vinschen via Cygwin wrote:
> On Jul 27 20:24, Corinna Vinschen via Cygwin wrote:
>> On Jul 27 12:15, Bruno Haible via Cygwin wrote:
>> I'm looking into that. First thing, your testsuite uncovered a bug in
>> the latest fnmatch in the C locale. Comparing pointers instead of
>> comparing characters was never a good idea for pattern matching...
>>
>> When I'm done I hope that our 3.5 fnmatch won't be overridden by the
>> gnulib version :}
>>
>>> I can't easily install a Cygwin 3.5.0 snapshot. If one of you would like to
>>> help, here's how to:
>>> 1. Create an environment for working with a Cygwin 3.5.0 snapshot (from
>>> March 2023 or newer).
>>> 2. wget https://haible.de/bruno/gnu/testdir-fnmatch.tar.gz
>>> 3. tar xfz testdir-fnmatch.tar.gz
>>> 4. cd testdir-fnmatch-posix
>>> ./configure 2>&1 | tee log1
>>> make
>>> make check
>
> I fixed the above problem and the POSIX check now works fine:
>
>>> grep fnmatch log1
>
> checking for fnmatch.h... yes
> checking for fnmatch... yes
> checking for working POSIX fnmatch... yes
>
> I also extraced the fnmatch configure testcase and ran it manually.
> It returns 0 now. But:
>
>>> grep REPLACE_FNMATCH config.status
>
> S["REPLACE_FNMATCH"]="1"
>
> Looks like the reason is that we don't have a uchar.h file? Seems
> like this is of interest for AIX, but why should this be of
> interest for fnmatch on other systems?
It was added in C99 TR19769, integrated in C/++11, available in libicu-devel:
https://cplusplus.com/reference/cuchar/
https://open-std.org/jtc1/sc22/open/n3579.pdf
https://open-std.org/jtc1/sc22/wg14/www/docs/n1326.pdf
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf#page=416
$ find /usr/include/ -name uchar.h
/usr/include/unicode/uchar.h
$ cygcheck -f /usr/include/unicode/uchar.h
libicu-devel-72.1-1
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
next prev parent reply other threads:[~2023-07-27 20:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 10:15 Bruno Haible
2023-07-27 18:24 ` Corinna Vinschen
2023-07-27 19:05 ` Corinna Vinschen
2023-07-27 20:25 ` Brian Inglis [this message]
2023-07-27 21:22 ` Bruno Haible
2023-07-27 22:17 ` Brian Inglis
2023-07-28 9:00 ` Corinna Vinschen
2023-07-28 9:53 ` Corinna Vinschen
2023-07-27 21:40 ` Bruno Haible
2023-07-28 8:53 ` Corinna Vinschen
2023-07-28 10:56 ` Bruno Haible
2023-07-28 11:14 ` Corinna Vinschen
2023-07-28 18:59 ` Corinna Vinschen
2023-07-28 19:33 ` Bruno Haible
2023-07-28 19:54 ` GB18030 locale Bruno Haible
2023-07-29 9:23 ` Corinna Vinschen
2023-07-29 9:53 ` Bruno Haible
2023-07-31 10:07 ` Corinna Vinschen
2023-07-31 13:38 ` Corinna Vinschen
2023-07-31 14:06 ` character class "alpha" Bruno Haible
2023-07-31 17:46 ` Corinna Vinschen
2023-07-31 18:20 ` Corinna Vinschen
2023-07-31 18:43 ` Bruno Haible
2023-07-31 21:12 ` Corinna Vinschen
2023-08-01 16:29 ` Brian Inglis
2023-08-02 7:56 ` Corinna Vinschen
2023-08-02 15:06 ` Corinna Vinschen
2023-07-31 21:13 ` Brian Inglis
2023-07-31 21:37 ` Bruno Haible
2023-07-28 11:12 ` fnmatch improvements Corinna Vinschen
2023-07-28 11:22 ` Bruno Haible
2023-07-28 21:42 ` Bill Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b653bf78-fc57-d984-e0d4-dad7db26c072@Shaw.ca \
--to=brian.inglis@shaw.ca \
--cc=bruno@clisp.org \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).