From: Chet Ramey <chet.ramey@case.edu>
To: Eric Blake <eblake@redhat.com>,
cygwin@cygwin.com, bug-bash <bug-bash@gnu.org>,
Steven Penny <svnpenn@gmail.com>
Cc: chet.ramey@case.edu
Subject: Re: [ANNOUNCEMENT] Updated: libreadline7-7.0.3-3
Date: Mon, 15 May 2017 20:46:00 -0000 [thread overview]
Message-ID: <c09644f3-cbf6-cab0-b534-8615285f2af9@case.edu> (raw)
In-Reply-To: <d76a140e-5c80-6990-b5df-661bd010e9da@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1342 bytes --]
On 5/15/17 2:19 PM, Eric Blake wrote:
>> git checkout readline-7.0-alpha
>>
>> for the first bad commit, I found that the change to the "rl_insert"
>> function in
>> "text.c" breaks pasting and Alt codes with "chcp.com 65001". Can you
>> work with
>> this?
>>
>> http://git.savannah.gnu.org/cgit/readline.git/tree/text.c?h=readline-7.0-alpha#n891
>
> It's code I'm not familiar with, so I'm adding upstream bug-bash in the
> hopes that Chet might have an answer to why this code was changed, and
> if he is aware that the change may have broken things on Cygwin.
It was inspired by the discussion starting with
http://lists.gnu.org/archive/html/bug-readline/2015-05/msg00007.html
The idea is to optimize pasted input using the assumption that it will be
mostly composed of characters that map to self-insert, and you can batch
read those characters and perform one display update.
The way to test whether or not a character will be inserted into the
editing buffer is to see whether or not it maps directly to self-insert.
If that's the problem, there will have to be a cygwin-specific fix; it
works elsewhere.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 264 bytes --]
next prev parent reply other threads:[~2017-05-15 20:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 19:53 [ANNOUNCEMENT] Updated: libreadline7-7.0.3-3, libreadline-devel-7.0.3-3 Eric Blake (cygwin)
2017-03-25 0:46 ` Steven Penny
2017-04-13 19:07 ` [ANNOUNCEMENT] Updated: libreadline7-7.0.3-3 Steven Penny
2017-04-14 8:27 ` Eric Blake
2017-04-15 10:59 ` Steven Penny
2017-05-15 18:21 ` Eric Blake
2017-05-15 20:46 ` Chet Ramey [this message]
2017-06-18 15:53 ` Steven Penny
2017-07-04 21:53 ` Steven Penny
2017-07-27 21:37 ` Eric Blake
2017-07-27 21:39 ` Eric Blake
2017-07-27 21:46 ` Steven Penny
2017-07-28 8:28 ` Eric Blake
2017-07-28 14:55 ` Steven Penny
2017-07-28 18:31 ` Eric Blake
2017-07-28 18:39 ` Steven Penny
2017-07-28 23:55 ` Eric Blake
2017-07-29 1:55 ` Cygwin.bat (was: [ANNOUNCEMENT] Updated: libreadline7-7.0.3-3) Achim Gratz
2017-07-29 2:48 ` [ANNOUNCEMENT] Updated: libreadline7-7.0.3-3 Doug Henderson
2017-07-29 4:23 ` Steven Penny
2017-07-30 18:38 ` Doug Henderson
2017-07-30 19:54 ` Steven Penny
2017-07-29 8:45 ` Steven Penny
2017-07-29 10:08 ` Eric Blake
2017-07-31 18:36 ` Corinna Vinschen
2017-07-31 20:01 ` Steven Penny
2017-07-31 20:05 ` David Macek
2017-07-31 21:13 ` David Macek
[not found] ` <20170731200146.GD18950@calimero.vinschen.de>
[not found] ` <20170731211327.GG18950@calimero.vinschen.de>
2017-08-01 0:56 ` Steven Penny
2017-08-01 8:45 ` Corinna Vinschen
2017-08-01 14:48 ` Corinna Vinschen
2017-08-01 18:20 ` Steven Penny
2017-08-01 18:54 ` Achim Gratz
2017-08-01 19:02 ` Eric Blake
2017-08-01 7:22 ` David Macek
2017-08-01 8:46 ` Corinna Vinschen
[not found] ` <160b3569-d448-1898-3dcd-b7133a772527@SystematicSw.ab.ca>
2017-08-01 8:44 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09644f3-cbf6-cab0-b534-8615285f2af9@case.edu \
--to=chet.ramey@case.edu \
--cc=bug-bash@gnu.org \
--cc=cygwin@cygwin.com \
--cc=eblake@redhat.com \
--cc=svnpenn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).