Re: cygwin coreutils 9.4 install.exe issue

Re: cygwin coreutils 9.4 install.exe issue

[Brian Inglis]

On 2023-09-22 07:07, Christoph Reiter wrote:
> it did a quick test of the coreutils rebase here
> https://cygwin.com/cgit/cygwin-packages/coreutils/log/?h=playground
> and noticed that "install" has a regression, in that "install <file>
> <destdir>" fails in case the target filename already exits.
> 
> I did a bit of debugging and it seems the two `cygwin_spelling
> (drelname)` in copy.c are at fault. coreutils switched to destination
> relative paths there, but cygwin_spelling() doesn't deal with them,
> returning an error.
> 
> Maybe this information is useful to you in some way.
> 
> regards & thanks for your work

[Please do not DM developers or maintainers directly, email the list Chris!]

Thanks for the hints, but I believe I have handled all of those with updated 
patches, and coreutils 9.1..9.4 still miss handling existing files, fail on all 
copy operations over existing files, and I have been unable to track down how 
and where it is now missing gathering or handling that information.

It is likely it could be some difference between Cygwin winsup libc and glibc 
file operations, some other location(s) may need cygwin_spelling() added, or 
some other Cygwin feature is interfering with expected operation.

When I have some time, I will have another review of the copy code, for possible 
Cygwin additions or changes needed, then see what strace and gdb can show me.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry