public inbox for
 help / color / mirror / Atom feed
From: Yasutaka Atarashi <>
Subject: Re: subversion problem
Date: Wed, 25 Apr 2018 13:11:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi David,

I had some doubt that the modification suggested in my mail:
Cygwin subversion and UNC path
would cause the failure.
However, this would not be the case.

I'm afraid to say that it seems to be an oversight in 05-retry-loop.patch.

The first call of the loop target function must be made BEFORE the call of WIN32_RETRY_LOOP() while Cygwin branch of svn_io_file_rename2() calls WIN32_RETRY_LOOP() directly. 

I've made just simple tests only but applying the following patch additionally and replacing cygsvn_subr-1-0.dll seems to fix the issues.

--- origsrc/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 15:58:49.920742300 +0900
+++ src/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 21:16:56.215447100 +0900
@@ -4294,6 +4294,7 @@ svn_io_file_rename2(const char *from_pat
       status = apr_file_rename(from_path_apr, to_path_apr, pool);
 #elif defined (__CYGWIN__)
+  status = apr_file_rename(from_path_apr, to_path_apr, pool);
   WIN32_RETRY_LOOP(status, apr_file_rename(from_path_apr, to_path_apr, pool));
   status = apr_file_rename(from_path_apr, to_path_apr, pool);


Problem reports:
Unsubscribe info:

  parent reply	other threads:[~2018-04-25 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 20:20 Rockefeller, Harry
2018-04-23 20:31 ` David Rothenberger
2018-04-22 14:04   ` Cygwin subversion and UNC path Yasutaka Atarashi
2018-04-22 15:58     ` David Rothenberger
2018-04-25 13:11     ` Yasutaka Atarashi [this message]
2018-04-25 17:03       ` subversion problem David Rothenberger
2018-04-23 21:28   ` Rockefeller, Harry
2018-04-23 21:05 ` Andrey Repin
2018-04-23 21:28   ` Rockefeller, Harry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).