From: Prarit Bhargava <prarit@redhat.com>
To: Mark Wielaard <mark@klomp.org>, debugedit@sourceware.org
Subject: Re: [PATCH] scripts/find-debuginfo.in: Add --no-per-file-msg
Date: Thu, 26 Jan 2023 10:21:36 -0500 [thread overview]
Message-ID: <b2c776d8-39fe-07bd-d644-62bacafc6796@redhat.com> (raw)
In-Reply-To: <345248abd55a2ebc9aa89f3d87f9ce0405b8caa5.camel@klomp.org>
On 1/26/23 10:02, Mark Wielaard wrote:
> Hi Prarit,
>
> On Mon, 2023-01-23 at 15:27 -0500, Prarit Bhargava wrote:
>> Projects with a large number of compiled files end up with a large number
>> of 'extracting debug info from' messages in the build log. In the case of
>> the Fedora kernel these messages account for 8504 lines in the log, or 61%
>> of the entire log [1].
>>
>> Removing these lines make the log easier to view and comprehend for some
>> projects, however, not all projects will want to silence these messages so
>> suppressing them must be optional.
>>
>> Add a --no-per-file-msg which allows users to disable the per file
>> scanning message and in its place output a single general message in the
>> log.
>
> I appreciate the idea, but I think it is better to have a more standard
> -q, --quiet option that simply suppresses all none error/warnings.
> find-debuginfo already has too many specialized options IMHO.
>
Heh, I thought about doing this but wasn't sure if there needed to be a
quiet option. It's good to know you're open to this idea.
> Besides this "per file" output that is just these three extra output
> lines:
>
> echo "symlinked /usr/lib/debug$t to /usr/lib/debug${f}.debug"
> echo "hard linked $link to $debugfn"
> echo "original debug info size: ${size_before}kB, size after
> compression: ${size_after}kB"
>
> (For that last one, you can then also hide the size_before
> and size_after calculations behind $quiet &&)
I'll look at this and post a --quiet option.
Thanks,
P.
prev parent reply other threads:[~2023-01-26 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 20:27 Prarit Bhargava
2023-01-26 15:02 ` Mark Wielaard
2023-01-26 15:21 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c776d8-39fe-07bd-d644-62bacafc6796@redhat.com \
--to=prarit@redhat.com \
--cc=debugedit@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).