[Bug debugedit/27639] New: Unknown DWARF DW_FORM_0x1f20 and DWARF DW_FORM_0x1f21

[Bug debugedit/27639] New: Unknown DWARF DW_FORM_0x1f20 and DWARF DW_FORM_0x1f21

[doko at debian dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27639

            Bug ID: 27639
           Summary: Unknown DWARF DW_FORM_0x1f20 and DWARF DW_FORM_0x1f21
           Product: debugedit
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debugedit
          Assignee: unassigned at sourceware dot org
          Reporter: doko at debian dot org
                CC: debugedit at sourceware dot org
  Target Milestone: ---

debugedit warns about unknown sections DWARF DW_FORM_0x1f20 and DWARF
DW_FORM_0x1f21, when called for a binary which has been processed by dwz.

These warnings should not be emitted when debugedit is just called to change
the build-id.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debugedit/27639] Unknown DWARF DW_FORM_0x1f20 (GNU_ref_alt) and DWARF DW_FORM_0x1f21 (strp_alt)

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27639

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org
            Summary|Unknown DWARF               |Unknown DWARF
                   |DW_FORM_0x1f20 and DWARF    |DW_FORM_0x1f20
                   |DW_FORM_0x1f21              |(GNU_ref_alt) and DWARF
                   |                            |DW_FORM_0x1f21 (strp_alt)

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Matthias Klose from comment #0)
> debugedit warns about unknown sections DWARF DW_FORM_0x1f20 and DWARF
> DW_FORM_0x1f21, when called for a binary which has been processed by dwz.
> 
> These warnings should not be emitted when debugedit is just called to change
> the build-id.

How exactly are you calling debugedit? Which arguments are used?

And what exact warning do you see? unknown section names or unknown DWARF
FORMs?

In theory warnings about unknown forms should only be emitted when edit_dwarf2
is called. Which is guarded by:

          if (!(do_build_id && no_recompute_build_id && !base_dir && !dest_dir)
              && name != NULL && strcmp (name, ".debug_info") == 0)
            edit_dwarf2 (dso);

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debugedit/27639] Unknown DWARF DW_FORM_0x1f20 (GNU_ref_alt) and DWARF DW_FORM_0x1f21 (strp_alt)

[lool at dooz dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27639

Loïc Minier <lool at dooz dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lool at dooz dot org

--- Comment #2 from Loïc Minier <lool at dooz dot org> ---
I believe it's called by debhelper/dh_strip like this:
debugedit --build-id --build-id-seed=$seed $file

https://git.launchpad.net/ubuntu/+source/debhelper/tree/dh_strip#n300

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debugedit/27639] Unknown DWARF DW_FORM_0x1f20 (GNU_ref_alt) and DWARF DW_FORM_0x1f21 (strp_alt)

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27639

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Loïc Minier from comment #2)
> I believe it's called by debhelper/dh_strip like this:
> debugedit --build-id --build-id-seed=$seed $file
> 
> https://git.launchpad.net/ubuntu/+source/debhelper/tree/dh_strip#n300

Aha, I see the logic for when to skip parsing the DIE tree is wrong.
It only skips dwarf_edit2 when debugedit is invoked with -n -i and no base and
destdir are given, but it should skip calling dwarf_edit2 when no base and
dessst dir are given and we aren't listing the source files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug debugedit/27639] Unknown DWARF DW_FORM_0x1f20 (GNU_ref_alt) and DWARF DW_FORM_0x1f21 (strp_alt)

[mark at klomp dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27639

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Mark Wielaard <mark at klomp dot org> ---
commit 379b2b95df49d6cebedad3562391c3350882f1a3
Author: Mark Wielaard <mark@klomp.org>
Date:   Wed Dec 28 22:23:01 2022 +0100

    debugedit: Skip calling edit_dwarf2 if not rewriting and/or listing source

    We skipped calling edit_dwarf2 when no base and dest dir were given and
    debugedit was invoked with -i -n. But we never need to call edit_dwarf2
    if we aren't rewriting paths and we don't want to list the source files.

       * tools/debugedit.c (main): Adjust edit_dwarf2 call guard.

    https://sourceware.org/bugzilla/show_bug.cgi?id=27639

-- 
You are receiving this mail because:
You are on the CC list for the bug.