[Bug debugedit/31504] New: debugedit writes out ELF file even when nothing has been updated

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31504

            Bug ID: 31504
           Summary: debugedit writes out ELF file even when nothing has
                    been updated
           Product: debugedit
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: debugedit
          Assignee: unassigned at sourceware dot org
          Reporter: mark at klomp dot org
                CC: debugedit at sourceware dot org
  Target Milestone: ---

See also
https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/issues/19#note_171380
(warning javascript)

Basically what happens is that these .net ELF files are not really ELF files,
but are ELF files with some extra data tagged on. Since libelf doesn't know
anything about this extra data in the file it will simply truncate it after all
known ELF data structures are written out. This is normally harmless because
elf_update ELF_C_WRITE doesn't really write out anything that hasn't changed.
But in this case it does.

What we could do at the end of main () is to check needs_update, and probably
all needs_xxx_update flags, and simply not call elf_update if all of them are
false.

Note that this doesn't help if anything does really (need) updates. This is
really not a valid ELF file. But it will help if someone only wants the
build-id or file list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.