public inbox for
 help / color / mirror / Atom feed
From: "mark at klomp dot org" <>
Subject: [Bug debugedit/31504] debugedit writes out ELF file even when nothing has been updated
Date: Thu, 21 Mar 2024 11:46:38 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Allan McRae from comment #2)
> This partially fixes the issue we are seeing in Arch Linux.  
> Debugedit keeps the extra data when using:
> LANG=C debugedit --no-recompute-build-id \
> 	--list-file /dev/stdout "$1"

Thanks for testing.

> But still removes the data when using:
> LANG=C debugedit --no-recompute-build-id \
> 	--base-dir "${srcdir}" \
> 	--dest-dir "${dbgsrcdir}" \
> 	--list-file /dev/stdout "$1"

Right. That is kind of expected since you are explicitly asking with --dest-dir
to rewrite the DWARF debuginfo.

> This happens even when there are no source files found, so debugedit would
> make no changes.

I can add a check to see if there actually were any changes and if there aren't
simply not call elf_update at all. But I suspect that is really a corner case
that doesn't occur that often. At least why would you call debugedit explicitly
asking to rewrite things and then expect it to not actually do that?

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-03-21 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-17 14:46 [Bug debugedit/31504] New: " mark at klomp dot org
2024-03-18  8:20 ` [Bug debugedit/31504] " sam at gentoo dot org
2024-03-18 22:40 ` mark at klomp dot org
2024-03-21  0:05 ` allan at archlinux dot org
2024-03-21 11:46 ` mark at klomp dot org [this message]
2024-03-21 12:07 ` mark at klomp dot org
2024-03-21 21:23 ` allan at archlinux dot org
2024-03-22 12:29 ` mark at klomp dot org
2024-03-22 22:13 ` allan at archlinux dot org
2024-03-22 23:47 ` mark at klomp dot org
2024-04-29 19:59 ` jamin.collins at gmail dot com
2024-05-15 11:34 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).