[Bug debugedit/31504] debugedit writes out ELF file even when nothing has been updated

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31504

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
(In reply to Allan McRae from comment #2)
> This partially fixes the issue we are seeing in Arch Linux.  
> 
> Debugedit keeps the extra data when using:
> 
> LANG=C debugedit --no-recompute-build-id \
> 	--list-file /dev/stdout "$1"

Thanks for testing.

> But still removes the data when using:
> 
> LANG=C debugedit --no-recompute-build-id \
> 	--base-dir "${srcdir}" \
> 	--dest-dir "${dbgsrcdir}" \
> 	--list-file /dev/stdout "$1"

Right. That is kind of expected since you are explicitly asking with --dest-dir
to rewrite the DWARF debuginfo.

> This happens even when there are no source files found, so debugedit would
> make no changes.

I can add a check to see if there actually were any changes and if there aren't
simply not call elf_update at all. But I suspect that is really a corner case
that doesn't occur that often. At least why would you call debugedit explicitly
asking to rewrite things and then expect it to not actually do that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.