public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>, dwz@sourceware.org
Subject: Re: [PATCH] Remove left over "negate" adjustment in compute_abbrevs.
Date: Mon, 15 Feb 2021 10:21:03 +0100	[thread overview]
Message-ID: <1d0a1408f71a7e4517c4a2fbd4f1158ec809a2ce.camel@klomp.org> (raw)
In-Reply-To: <32aa3bcc-a5ec-35ac-931a-1c288a636641@suse.de>

Hi Tom,

On Mon, 2021-02-15 at 09:32 +0100, Tom de Vries wrote:
> On 2/14/21 4:34 PM, Mark Wielaard wrote:
> > Before commit 47af8da7c "Assorted DW_FORM_implicit_const fixes" there
> > was a hack to track whether decl/call_file line numbers had been
> > translated already. This worked by negating the value once it was
> 
> I'd add "translated" here, reads easier.
> 
> > and
> > not translating again when the value was negative. Then in
> > compute_abbrevs all negated values we made positive again. Most of
> 
> we -> were
> 
> > this hack was removed in the above commit. Except for making all
> > negated values positive again in compute_abbrevs. Remove it there too.
> > No decl/call_file line number tables can ever be negative.
> > 
> 
> LGTM.

Thanks. Pushed with the suggested changes to the commit message.

Cheers,

Mark

      reply	other threads:[~2021-02-15  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14 15:34 Mark Wielaard
2021-02-15  8:32 ` Tom de Vries
2021-02-15  9:21   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d0a1408f71a7e4517c4a2fbd4f1158ec809a2ce.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).