From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Sort find result of hardlink.sh test.
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <20190303225608.GB30328@wildebeest.org> (raw)
In-Reply-To: <20190303214559.GE7611@tucnak>
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
On Sun, Mar 03, 2019 at 10:45:59PM +0100, Jakub Jelinek wrote:
> Maybe there should also export LC_ALL=C in check: in Makefile,
> so that there aren't any differences based on selected language?
Good idea. Added as attached.
Cheers,
Mark
[-- Attachment #2: 0001-Add-export-LC_ALL-C-to-make-check.patch --]
[-- Type: text/x-diff, Size: 829 bytes --]
From 5af44e055dee8cd13e9b987adfef32bbb4d46ad9 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Sun, 3 Mar 2019 23:52:44 +0100
Subject: [PATCH] Add export LC_ALL=C to make check.
Make sure there are no sorting differences by exporting LC_ALL=C.
2019-03-03 Mark Wielaard <mark@klomp.org>
* Makefile (check): Add export LC_ALL=C.
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index bc51ca2..b318fd7 100644
--- a/Makefile
+++ b/Makefile
@@ -25,6 +25,6 @@ hello:
check: dwz $(TEST_EXECS)
mkdir -p testsuite-bin
cd testsuite-bin; ln -sf $(PWD)/dwz .
- export PATH=$(PWD)/testsuite-bin:$$PATH; \
+ export PATH=$(PWD)/testsuite-bin:$$PATH; export LC_ALL=C; \
runtest --tool=dwz -srcdir testsuite
rm -Rf testsuite-bin $(TEST_EXECS)
--
2.20.1
next prev parent reply other threads:[~2019-03-03 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Mark Wielaard
2019-01-01 0:00 ` Jakub Jelinek
2019-01-01 0:00 ` Mark Wielaard [this message]
2019-01-01 0:00 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190303225608.GB30328@wildebeest.org \
--to=mark@klomp.org \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).