From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Honour errors when processing more than one file
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <20190304170957.GO7611@tucnak> (raw)
In-Reply-To: <20190304164925.GA27794@delia>
On Mon, Mar 04, 2019 at 05:49:26PM +0100, Tom de Vries wrote:
> 2019-03-04 Tom de Vries <tdevries@suse.de>
>
> PR dwz/24301
> * dwz.c (main): Handle dwz returning 1 if processing more than one file.
> * testsuite/dwz.tests/two-files-too-many-dies.sh: New test.
That looks wrong to me, that means once an error is reported for any single
one, the rest will not be processed. That was not the intent and is
undesirable for the distro compression, we want to compress as much as
possible.
Guess that
else if (resa[i - optind].res == 0)
successcount++;
should be
if (resa[i - optind].res == 0)
successcount++;
else
ret = 1;
or something similar, I must say I don't really remember the difference
between res->res value and return value from dwz etc., but it seems weird
that if if some file isn't processed in normal mode and when switched into lowmem
mode succeeds, we don't count it as successcount, while if we already are in
lowmem mode from the previous file, we count it.
Jakub
next prev parent reply other threads:[~2019-03-04 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Tom de Vries
2019-01-01 0:00 ` Jakub Jelinek [this message]
2019-01-01 0:00 ` Tom de Vries
2019-01-01 0:00 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304170957.GO7611@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).