From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Add pr24171.sh test-case
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <20190316082634.GO7611@tucnak> (raw)
In-Reply-To: <20190316022518.GA25300@delia>
On Sat, Mar 16, 2019 at 03:25:19AM +0100, Tom de Vries wrote:
> Hi,
>
> Add test-case for PR24171, using dw2-restrict.S from binutils-gdb repo.
>
> OK for trunk?
>
> Thanks,
> - Tom
>
> Add pr24171.sh test-case
>
> 2019-03-16 Tom de Vries <tdevries@suse.de>
>
> * Makefile (TEST_EXECS): Add dw2-restrict.
> (dw2-restrict): New target.
> * dw2-restrict.S: New file, copied from binutils-gdb repo.
> * testsuite/dwz.tests/dwz-tests.exp: Require dw2-restrict for
> pr24171.sh.
> * testsuite/dwz.tests/pr24171.sh: New test.
I just wonder if the test shouldn't be either in testsuite/dwz.tests/
or testsuite/dwz.tests/pr24171/ subdirectory. It would be better
if the toplevel directory contained just the sources and whatever is needed
to build them, plus testsuite subdirectory.
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2019-03-16 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Tom de Vries
2019-01-01 0:00 ` Jakub Jelinek [this message]
2019-01-01 0:00 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316082634.GO7611@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).