public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com
Subject: [committed] Handle null DIE in dump_die
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <20191203195536.GA24458@delia> (raw)

Hi,

Handle null DIE in dump_die:
...
(gdb) call dump_die (0)
 null
...
allowing us to do something like:
...
(gdb) call dump_die (child->die_nextdup)
 5a O 3737fe8a e3113fb8 bla class_type
(gdb) call dump_die (child->die_nextdup->die_nextdup)
 ef O 3737fe8a e3113fb8 bla class_type
(gdb) call dump_die (child->die_nextdup->die_nextdup->die_nextdup)
 null
...

Committed to trunk.

Thanks,
- Tom

Handle null DIE in dump_die

2019-12-02  Tom de Vries  <tdevries@suse.de>

	* dwz.c (dump_die_with_indent): Handle die == NULL.

---
 dwz.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dwz.c b/dwz.c
index 93c8736..00a08b0 100644
--- a/dwz.c
+++ b/dwz.c
@@ -4168,7 +4168,9 @@ dump_type (dw_die_ref die)
 static void
 dump_die_with_indent (int indent, dw_die_ref die)
 {
-  if (die->die_collapsed_child)
+  if (die == NULL)
+    fprintf (stderr, "%*s null", indent, "");
+  else if (die->die_collapsed_child)
     {
       fprintf (stderr, "%*s %x %c", indent, "", die->die_offset,
 	   die->die_ck_state == CK_KNOWN ? 'O' : 'X');

                 reply	other threads:[~2019-12-03 19:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203195536.GA24458@delia \
    --to=tdevries@suse.de \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).