public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
* [committed] Add assert to verify_dups for low-mem mode
@ 2020-01-01  0:00 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2020-01-01  0:00 UTC (permalink / raw)
  To: dwz, jakub

Hi,

In low-mem mode, toplevel DIEs can have collapsed children.  The head of a
duplicate chain though needs to be with uncollapsed children.

Add an assert to that effect to verify_dups.

Tested with --devel-verify-dups on by default.

Committed to trunk.

Thanks,
- Tom

Add assert to verify_dups for low-mem mode

2020-01-09  Tom de Vries  <tdevries@suse.de>

	* dwz.c (verify_dups): Assert die->die_collapsed_children == 0.

---
 dwz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dwz.c b/dwz.c
index 959033b..99ef704 100644
--- a/dwz.c
+++ b/dwz.c
@@ -4410,6 +4410,7 @@ verify_dups (dw_die_ref die, bool ordered)
   dw_die_ref d, prev;
 
   assert (die->die_dup == NULL);
+  assert (die->die_collapsed_children == 0);
 
   for (prev = die, d = prev->die_nextdup;
        d;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-09 13:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-01  0:00 [committed] Add assert to verify_dups for low-mem mode Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).