From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Break out of while loop correctly to make sure loclists are adjusted.
Date: Mon, 18 Jan 2021 09:11:04 +0100 [thread overview]
Message-ID: <20210118081104.GR1034503@tucnak> (raw)
In-Reply-To: <20210117222559.23364-1-mark@klomp.org>
On Sun, Jan 17, 2021 at 11:25:59PM +0100, Mark Wielaard wrote:
> The reading and adjusting of DWARF5 .debug_loclists was modelled on
> the DWARF4 .debug_loc section parsing. The .debug_loc parsing used
> a while loop and breaks out when done. But .debug_loclists use a
> switch statement inside the while loop, so break doesn't actually
> break out of the loop when done, and return on end of list exits
> the functions too early. This meant that although the loclists were
> parsed correctly, then were then not actually adjusted. Fix this
> by using gotos inside the switch statements.
>
> * dwz.c (read_loclist_low_mem_phase1): Use again and done
> labels to goto inside switch.
> (read_loclist): Likewise.
> (adjust_loclist): Likewise.
Ok, thanks.
Jakub
prev parent reply other threads:[~2021-01-18 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 22:25 Mark Wielaard
2021-01-18 8:11 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118081104.GR1034503@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).