From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, jakub@redhat.com
Subject: Re: [PATCH] Clean up die_odr_state interface
Date: Tue, 23 Feb 2021 11:14:49 +0100 [thread overview]
Message-ID: <20210223101449.GG2992@wildebeest.org> (raw)
In-Reply-To: <c35ea4b6-d1c0-8d03-5daa-fa4fd0433453@suse.de>
Hi Tom,
On Tue, Feb 23, 2021 at 11:00:24AM +0100, Tom de Vries wrote:
> On 2/22/21 11:27 PM, Mark Wielaard wrote:
> > (And if so, do we even need the function
> > call?)
>
> I've left it in for now, for the sake of the assert. Instead, I've
> dropped the cu parameter for the function.
>
> WDYT?
Makes sense to me, both the asserts and the dropping of the cu
argument to for die_odr_state.
Thanks,
Mark
prev parent reply other threads:[~2021-02-23 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 15:39 [committed] Don't call die_odr_state with unnecessarily defined cu arg Tom de Vries
2021-02-22 22:27 ` Mark Wielaard
2021-02-23 10:00 ` [PATCH] Clean up die_odr_state interface Tom de Vries
2021-02-23 10:14 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223101449.GG2992@wildebeest.org \
--to=mark@klomp.org \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).